From: Daniel Ruf Date: Sat, 5 Oct 2019 15:48:22 +0000 (+0200) Subject: refactor: reformat code and mark unused parameters X-Git-Tag: v6.6.2^2~37^2 X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F11829%2Fhead;p=thirdparty%2Ffoundation%2Ffoundation-sites.git refactor: reformat code and mark unused parameters --- diff --git a/docs/assets/img/gulpfile.js b/docs/assets/img/gulpfile.js index d90190856..79c7d7176 100755 --- a/docs/assets/img/gulpfile.js +++ b/docs/assets/img/gulpfile.js @@ -37,7 +37,7 @@ gulp.task('clean', function(done) { // Copy files out of the assets folder // This task skips over the "img", "js", and "scss" folders, which are parsed separately -gulp.task('copy', function(done) { +gulp.task('copy', function(_done) { gulp.src(paths.assets) .pipe(gulp.dest('./dist/assets')); }); diff --git a/js/foundation.core.js b/js/foundation.core.js index 8b7b88abe..330852950 100644 --- a/js/foundation.core.js +++ b/js/foundation.core.js @@ -159,8 +159,8 @@ var Foundation = { opts = {}; if($el.attr('data-options')){ - var thing = $el.attr('data-options').split(';').forEach(function(e, i){ - var opt = e.split(':').map(function(el){ return el.trim(); }); + $el.attr('data-options').split(';').forEach(function(option, _index){ + var opt = option.split(':').map(function(el){ return el.trim(); }); if(opt[0]) opts[opt[0]] = parseValue(opt[1]); }); } diff --git a/js/foundation.core.utils.js b/js/foundation.core.utils.js index b6778b72b..2a10f5675 100644 --- a/js/foundation.core.utils.js +++ b/js/foundation.core.utils.js @@ -51,7 +51,7 @@ function transitionend($elem){ end = transitions[t]; } } - if(end){ + if (end) { return end; }else{ end = setTimeout(function(){ diff --git a/js/foundation.responsiveAccordionTabs.js b/js/foundation.responsiveAccordionTabs.js index 8d73237b6..5a0fa0841 100644 --- a/js/foundation.responsiveAccordionTabs.js +++ b/js/foundation.responsiveAccordionTabs.js @@ -190,7 +190,7 @@ class ResponsiveAccordionTabs extends Plugin{ if (fromString === 'tabs') { $panels = $panels.children('.'+tabsPanel).removeClass(tabsPanel).removeAttr('role').removeAttr('aria-hidden').removeAttr('aria-labelledby'); $panels.children('a').removeAttr('role').removeAttr('aria-controls').removeAttr('aria-selected'); - }else{ + } else { $panels = $liHeads.children('[data-tab-content]').removeClass('accordion-content'); }; @@ -203,13 +203,13 @@ class ResponsiveAccordionTabs extends Plugin{ $liHeads.addClass('accordion-item').attr('data-accordion-item',''); $liHeadsA.addClass('accordion-title'); }); - }else if (toSet === 'tabs'){ + } else if (toSet === 'tabs') { var $tabsContent = $('[data-tabs-content='+_this.$element.attr('id')+']'); var $placeholder = $('#tabs-placeholder-'+_this.$element.attr('id')); if ($placeholder.length) { $tabsContent = $('
').insertAfter($placeholder).attr('data-tabs-content',_this.$element.attr('id')); $placeholder.remove(); - }else{ + } else { $tabsContent = $('
').insertAfter(_this.$element).attr('data-tabs-content',_this.$element.attr('id')); }; $panels.each(function(key,value){ @@ -219,7 +219,7 @@ class ResponsiveAccordionTabs extends Plugin{ if (hash !== id) { if (hash !== '') { $(value).attr('id',hash); - }else{ + } else { hash = id; $(value).attr('id',hash); $($liHeadsA.get(key)).attr('href',$($liHeadsA.get(key)).attr('href').replace('#','')+'#'+hash); @@ -241,7 +241,7 @@ class ResponsiveAccordionTabs extends Plugin{ * @see Tabs.selectTab * @function */ - open(target) { + open(_target) { if (this.currentRule && typeof this.currentRule.open === 'function') { return this.currentRule.open(this.currentPlugin, ...arguments); } @@ -253,7 +253,7 @@ class ResponsiveAccordionTabs extends Plugin{ * @see Accordion.up * @function */ - close(target) { + close(_target) { if (this.currentRule && typeof this.currentRule.close === 'function') { return this.currentRule.close(this.currentPlugin, ...arguments); } @@ -265,7 +265,7 @@ class ResponsiveAccordionTabs extends Plugin{ * @see Accordion.toggle * @function */ - toggle(target) { + toggle(_target) { if (this.currentRule && typeof this.currentRule.toggle === 'function') { return this.currentRule.toggle(this.currentPlugin, ...arguments); }