From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Thu, 29 Jun 2023 10:52:32 +0000 (+0200)
Subject: Take one suggestion form review. The others keep on producing clang-tidy
X-Git-Tag: rec-5.0.0-alpha1~138^2
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F12917%2Fhead;p=thirdparty%2Fpdns.git

Take one suggestion form review. The others keep on producing clang-tidy
issues.
---

diff --git a/pdns/recursordist/pdns_recursor.cc b/pdns/recursordist/pdns_recursor.cc
index 2ae64233b7..927cf06dd8 100644
--- a/pdns/recursordist/pdns_recursor.cc
+++ b/pdns/recursordist/pdns_recursor.cc
@@ -908,7 +908,7 @@ static uint32_t capPacketCacheTTL(const struct dnsheader& hdr, uint32_t ttl, boo
 
 void startDoResolve(void* arg) // NOLINT(readability-function-cognitive-complexity): https://github.com/PowerDNS/pdns/issues/12791
 {
-  auto comboWriter = std::unique_ptr<DNSComboWriter>(reinterpret_cast<DNSComboWriter*>(arg)); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
+  auto comboWriter = std::unique_ptr<DNSComboWriter>(static_cast<DNSComboWriter*>(arg));
   SyncRes resolver(comboWriter->d_now);
   try {
     if (t_queryring) {