From: Miod Vallat <miod.vallat@powerdns.com>
Date: Mon, 18 Aug 2025 07:40:30 +0000 (+0200)
Subject: Deserialize bool variables as bool.
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F15864%2Fhead;p=thirdparty%2Fpdns.git

Deserialize bool variables as bool.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index bfac4816b..eb111ae7d 100644
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -1072,14 +1072,16 @@ static inline size_t deserializeRRFromBuffer(const string_view& str, LMDBBackend
   if (str.size() < serialize_prefix_size + len + serialize_trailing_size) {
     return 0;
   }
+  // NOLINTBEGIN(cppcoreguidelines-pro-bounds-pointer-arithmetic): due to the above size check, this is safe
   data += sizeof(len);
   lrr.content.assign(data, len); // len bytes
   data += len;
   memcpy(&lrr.ttl, data, sizeof(uint32_t));
   data += sizeof(uint32_t);
-  lrr.auth = *data++;
-  lrr.disabled = *data++;
+  lrr.auth = *data++ != 0;
+  lrr.disabled = *data++ != 0;
   lrr.hasOrderName = *data++ != 0;
+  // NOLINTEND(cppcoreguidelines-pro-bounds-pointer-arithmetic)
   lrr.wildcardname.clear();
 
   return data - str.data();