From: Trenton H <797416+stumpylog@users.noreply.github.com>
Date: Fri, 11 Nov 2022 18:09:56 +0000 (-0800)
Subject: Don't do decoding work if not needed
X-Git-Tag: v1.10.0-beta.rc2~7^2
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1967%2Fhead;p=thirdparty%2Fpaperless-ngx.git

Don't do decoding work if not needed
---

diff --git a/src/documents/consumer.py b/src/documents/consumer.py
index 45722d01a4..75181cabb0 100644
--- a/src/documents/consumer.py
+++ b/src/documents/consumer.py
@@ -537,27 +537,27 @@ class Consumer(LoggingMixin):
         )
 
         # Decode the output (if any)
-        stdout_str = (
-            completed_process.stdout.decode("utf8", errors="ignore")
-            .strip()
-            .split(
-                "\n",
-            )
-        )
-        stderr_str = (
-            completed_process.stderr.decode("utf8", errors="ignore")
-            .strip()
-            .split(
-                "\n",
+        if len(completed_process.stdout):
+            stdout_str = (
+                completed_process.stdout.decode("utf8", errors="ignore")
+                .strip()
+                .split(
+                    "\n",
+                )
             )
-        )
-
-        if len(stdout_str):
             self.log("info", "Script stdout:")
             for line in stdout_str:
                 self.log("info", line)
 
-        if len(stderr_str):
+        if len(completed_process.stderr):
+            stderr_str = (
+                completed_process.stderr.decode("utf8", errors="ignore")
+                .strip()
+                .split(
+                    "\n",
+                )
+            )
+
             self.log("warning", "Script stderr:")
             for line in stderr_str:
                 self.log("warning", line)