From: Daan De Meyer <daan.j.demeyer@gmail.com>
Date: Mon, 25 Mar 2024 10:30:48 +0000 (+0100)
Subject: Prefer virtiofsd file handles when running as root instead of making them mandatory
X-Git-Tag: v23~65^2
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F2549%2Fhead;p=thirdparty%2Fmkosi.git

Prefer virtiofsd file handles when running as root instead of making them mandatory

We might be invoked as root from a user namespace which won't have
access to file handles.
---

diff --git a/mkosi/qemu.py b/mkosi/qemu.py
index 16d62f36d..cac410ce6 100644
--- a/mkosi/qemu.py
+++ b/mkosi/qemu.py
@@ -308,7 +308,7 @@ def start_virtiofsd(config: Config, directory: Path, *, uidmap: bool) -> Iterato
         "--no-announce-submounts",
         "--sandbox=chroot",
         "--cache=always",
-        f"--inode-file-handles={'mandatory' if os.getuid() == 0 and not uidmap else 'never'}",
+        f"--inode-file-handles={'prefer' if os.getuid() == 0 and not uidmap else 'never'}",
     ]
 
     if not uidmap and want_selinux_relabel(config, directory, fatal=False):