From: Patrick H. Lauke Date: Thu, 15 Apr 2021 03:35:54 +0000 (+0100) Subject: Remove aria-haspopup from dropdowns (#33624) X-Git-Tag: v4.6.1~56 X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F33729%2Fhead;p=thirdparty%2Fbootstrap.git Remove aria-haspopup from dropdowns (#33624) `aria-haspopup="true"` is really intended to signal that an ARIA `menu` will be opened on activation. as a result, some assistive technologies will announce controls with `aria-haspopup="true"` as a menu or menu item (e.g. JAWS and NVDA). In addition, `aria-haspopup` seems to trigger a bug in Edge/Narrator where the `aria-expanded` state is not correctly announced at the moment when `aria-haspopup` is present. This now makes the dropdown button more like a generic disclosure widget control - see also https://www.w3.org/TR/wai-aria-practices-1.2/examples/disclosure/disclosure-navigation.html01 --- diff --git a/js/tests/unit/dropdown.js b/js/tests/unit/dropdown.js index e4b959ea18..b71a125dfc 100644 --- a/js/tests/unit/dropdown.js +++ b/js/tests/unit/dropdown.js @@ -752,7 +752,7 @@ $(function () { var done = assert.async() var html = '