From: Jørgen Borgesen Date: Sun, 20 May 2012 17:59:53 +0000 (+0200) Subject: Added unit test to check that tooltips is not showed when leave event is triggered... X-Git-Tag: v2.0.4~1^2~1^2~1 X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F3550%2Fhead;p=thirdparty%2Fbootstrap.git Added unit test to check that tooltips is not showed when leave event is triggered before show delay has expired AND the hide delay is set to 0 --- diff --git a/js/bootstrap-tooltip.js b/js/bootstrap-tooltip.js index 4c2a2a328d..6ff2b47086 100644 --- a/js/bootstrap-tooltip.js +++ b/js/bootstrap-tooltip.js @@ -87,7 +87,6 @@ if (this.timeout) clearTimeout(this.timeout) if (!self.options.delay || !self.options.delay.hide) return self.hide() - clearTimeout(this.timeout) self.hoverState = 'out' this.timeout = setTimeout(function() { if (self.hoverState == 'out') self.hide() diff --git a/js/tests/unit/bootstrap-tooltip.js b/js/tests/unit/bootstrap-tooltip.js index 63f4f0b07c..c25093420d 100644 --- a/js/tests/unit/bootstrap-tooltip.js +++ b/js/tests/unit/bootstrap-tooltip.js @@ -78,6 +78,25 @@ $(function () { }, 100) }) + test("should not show tooltip if leave event occurs before delay expires, even if hide delay is 0", function () { + var tooltip = $('') + .appendTo('#qunit-fixture') + .tooltip({ delay: { show: 200, hide: 0} }) + + stop() + + tooltip.trigger('mouseenter') + + setTimeout(function () { + ok(!$(".tooltip").is('.fade.in'), 'tooltip is not faded in') + tooltip.trigger('mouseout') + setTimeout(function () { + ok(!$(".tooltip").is('.fade.in'), 'tooltip is not faded in') + start() + }, 200) + }, 100) + }) + test("should not show tooltip if leave event occurs before delay expires", function () { var tooltip = $('') .appendTo('#qunit-fixture') @@ -133,4 +152,4 @@ $(function () { ok($.fn.tooltip.Constructor.prototype.isHTML($('
')), 'correctly detected html') }) -}) \ No newline at end of file +})