]>
git.ipfire.org Git - thirdparty/rrdtool-1.x.git/log
Marek Schimara [Thu, 16 Jun 2016 07:06:45 +0000 (09:06 +0200)]
src/rrd_cgi.c: fix Coverity CID#13656 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 14:40:05 +0000 (16:40 +0200)]
src/rrd_daemon.c: fix Coverity CID#32399 Buffer not null terminated
CWE-170 / https://cwe.mitre.org/data/definitions/170.html
Marek Schimara [Wed, 15 Jun 2016 14:30:32 +0000 (16:30 +0200)]
src/rrd_create.c: fix Coverity CID#32400 Buffer not null terminated
CWE-170 / https://cwe.mitre.org/data/definitions/170.html
Marek Schimara [Wed, 15 Jun 2016 14:19:16 +0000 (16:19 +0200)]
src/rrd_graph_helper.c: fix Coverity CID#32401 Buffer not null terminated
CWE-170 / https://cwe.mitre.org/data/definitions/170.html
Marek Schimara [Wed, 15 Jun 2016 14:12:47 +0000 (16:12 +0200)]
src/rrd_open.c: fix Coverity CID#32402 Unchecked return value from library
CWE-252 / https://cwe.mitre.org/data/definitions/252.html
Marek Schimara [Wed, 15 Jun 2016 13:53:52 +0000 (15:53 +0200)]
src/rrd_modify.c: fix Coverity CID#32405 Logically dead code
CWE-561 / https://cwe.mitre.org/data/definitions/561.html
Marek Schimara [Wed, 15 Jun 2016 13:48:34 +0000 (15:48 +0200)]
src/rrd_modify.c: fix Coverity CID#32406 Logically dead code
CWE-561 / https://cwe.mitre.org/data/definitions/561.html
Either
finalout = rrd_modify_structure == NULL => goto done;
or
finalout = rrd_modify_structure != NULL => rc = 0;
Marek Schimara [Wed, 15 Jun 2016 13:36:28 +0000 (15:36 +0200)]
src/rrd_daemon.c: fix Coverity CID#32408 Missing unlock
CWE-667 / https://cwe.mitre.org/data/definitions/667.html
Marek Schimara [Wed, 15 Jun 2016 13:31:27 +0000 (15:31 +0200)]
src/rrd_client.c: fix Coverity CID#32409 Missing unlock
CWE-667 / https://cwe.mitre.org/data/definitions/667.html
Marek Schimara [Wed, 15 Jun 2016 13:03:35 +0000 (15:03 +0200)]
src/rrd_daemon.c: fix Coverity CID#32412 Nesting level does not match indentation
CWE-483 / https://cwe.mitre.org/data/definitions/483.html
Marek Schimara [Wed, 15 Jun 2016 12:52:33 +0000 (14:52 +0200)]
src/rrd_graph.c: fix Coverity CID#32414 Array compared against 0
CWE-398 / https://cwe.mitre.org/data/definitions/398.html
'im' declared as: image_desc_t *im
im->gdes[i] is: graph_desc_t *gdes; /* points to an array of graph elements */
im->gdes[i].format is: char format[FMT_LEG_LEN + 5]; /* format for PRINT AND GPRINT */
Comparing a stack variable to NULL doesn't make sense.
Marek Schimara [Wed, 15 Jun 2016 11:26:55 +0000 (13:26 +0200)]
src/rrd_daemon.c: fix Coverity CIDs#32415,#26519 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 11:23:51 +0000 (13:23 +0200)]
src/rrd_daemon.c: fix Coverity CID#32416 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 11:17:45 +0000 (13:17 +0200)]
src/rrd_daemon.c: fix Coverity CID#32417 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 09:34:49 +0000 (11:34 +0200)]
src/rrd_daemon.c: fix Coverity CIDs#32418,#32419 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 09:09:34 +0000 (11:09 +0200)]
src/rrd_daemon.c: fix Coverity CIDs#32420,#26530 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 08:56:37 +0000 (10:56 +0200)]
src/rrd_daemon.c: fix Coverity CID#32421 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 08:39:44 +0000 (10:39 +0200)]
src/rrd_create.c: fix Coverity CID#32422 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 07:59:25 +0000 (09:59 +0200)]
src/rrd_tune.c: fix Coverity CID#32424 Improper use of negative value
CWE-394 / https://cwe.mitre.org/data/definitions/394.html
Note: optparse_init() and optparse_long() which can modify the
'options' variable in rrd_tune() can never set options.optind
to a negative value.
Marek Schimara [Wed, 15 Jun 2016 07:25:45 +0000 (09:25 +0200)]
src/rrd_create.c: fix Coverity CID#32425 Insecure temporary file
CWE-377 / https://cwe.mitre.org/data/definitions/377.html
Marek Schimara [Tue, 14 Jun 2016 15:02:11 +0000 (17:02 +0200)]
src/rrd_modify.c: fix Coverity CID#32426 Copy into fixed size buffer
CWE-120 / https://cwe.mitre.org/data/definitions/120.html
Marek Schimara [Tue, 14 Jun 2016 14:55:25 +0000 (16:55 +0200)]
src/rrd_create.c: fix Coverity CID#32427 Copy into fixed size buffer (buffer overflow)
CWE-120 / https://cwe.mitre.org/data/definitions/120.html
Marek Schimara [Tue, 14 Jun 2016 14:46:46 +0000 (16:46 +0200)]
bindings/perl-shared/RRDs.xs: fix Coverity CID#32428 Uninitialized pointer read
CWE-457 / https://cwe.mitre.org/data/definitions/457.html
Marek Schimara [Tue, 14 Jun 2016 14:05:29 +0000 (16:05 +0200)]
src/rrd_create.c: fix Coverity CID#32429 Uninitialized pointer read
CWE-457 / https://cwe.mitre.org/data/definitions/457.html
Marek Schimara [Tue, 14 Jun 2016 14:04:09 +0000 (16:04 +0200)]
src/rrd_tune.c: fix Coverity CID#32430 Uninitialized pointer read
CWE-457 / https://cwe.mitre.org/data/definitions/457.html
Tobias Oetiker [Tue, 21 Jun 2016 12:18:23 +0000 (14:18 +0200)]
Merge pull request #710 from nirgal/patch-4
CHANGES about supported lua versions
Tobias Oetiker [Mon, 23 May 2016 15:59:43 +0000 (17:59 +0200)]
nagle not nagel
Tobias Oetiker [Mon, 9 May 2016 06:39:15 +0000 (08:39 +0200)]
Merge branch 'master' of github.com:oetiker/rrdtool-1.x
Tobias Oetiker [Mon, 9 May 2016 06:38:57 +0000 (08:38 +0200)]
fix release number
Tobias Oetiker [Fri, 22 Apr 2016 15:19:14 +0000 (17:19 +0200)]
Merge pull request #712 from gitter-badger/gitter-badge-1
Add a Gitter chat badge to README.md
The Gitter Badger [Fri, 22 Apr 2016 15:18:29 +0000 (15:18 +0000)]
Add Gitter badge
nirgal [Fri, 22 Apr 2016 15:14:41 +0000 (17:14 +0200)]
CHANGES about supported lua versions
lua 5.1 already was supported.
What version 1.6.0 brings is lua 5.2 and lua 5.3 support.
Tobias Oetiker [Tue, 19 Apr 2016 16:05:16 +0000 (18:05 +0200)]
travis-link
Tobias Oetiker [Tue, 19 Apr 2016 15:50:15 +0000 (17:50 +0200)]
prep master for new checkins
Tobias Oetiker [Tue, 19 Apr 2016 09:17:55 +0000 (11:17 +0200)]
remove extra spaces
Tobias Oetiker [Tue, 19 Apr 2016 08:01:07 +0000 (10:01 +0200)]
fix for #707
Tobias Oetiker [Tue, 19 Apr 2016 07:08:18 +0000 (09:08 +0200)]
ignore all so files in tcl
Tobias Oetiker [Mon, 18 Apr 2016 16:21:06 +0000 (18:21 +0200)]
Merge pull request #708 from oetiker/new-calc
a bunch of new RPN functions coming up for 1.6
Tobias Oetiker [Mon, 18 Apr 2016 15:30:32 +0000 (17:30 +0200)]
fix expected results
Tobias Oetiker [Mon, 18 Apr 2016 15:13:15 +0000 (17:13 +0200)]
add new RPN functions: AVG, SMIN, SMAX, STDEV, POW, MEDIAN
Tobias Oetiker [Sun, 10 Apr 2016 08:33:58 +0000 (10:33 +0200)]
Merge pull request #706 from stevenh/disable-nagle
Disable nagel algorithm
Steven Hartland [Sun, 10 Apr 2016 01:30:51 +0000 (01:30 +0000)]
Disable nagel algorithm
Disable TCP's nagal algorithm which was causing massive slowdown
in processing rrdcached requests.
Also check for other setsockopt call errors.
Tobias Oetiker [Thu, 24 Mar 2016 07:07:55 +0000 (08:07 +0100)]
Merge pull request #703 from nirgal/verbose_tests
Fixed tests when VERBOSE is on
Jean-Michel Vourgère [Thu, 24 Mar 2016 05:18:01 +0000 (06:18 +0100)]
Fixed tests when VERBOSE is on
Define RRDTOOL_V from RRDTOOL, but only after RRDTOOL is defined.
Output the header showing witch command is run on stderr, not stdout.
Tobias Oetiker [Thu, 18 Feb 2016 12:58:02 +0000 (13:58 +0100)]
make the vnames in the test a bit more interesting ... especially verify that having a - and numbers in the vname is fine
Tobias Oetiker [Thu, 18 Feb 2016 08:14:25 +0000 (09:14 +0100)]
re allow - in vnames since it seems to have worked for some in 1.4
Tobias Oetiker [Tue, 16 Feb 2016 07:14:39 +0000 (08:14 +0100)]
added rpn1.output
Tobias Oetiker [Mon, 8 Feb 2016 12:52:24 +0000 (13:52 +0100)]
Merge branch 'master' of github.com:oetiker/rrdtool-1.x
Tobias Oetiker [Mon, 8 Feb 2016 12:51:40 +0000 (13:51 +0100)]
- is not allowed in vnames!
Tobias Oetiker [Mon, 8 Feb 2016 09:55:03 +0000 (10:55 +0100)]
Merge pull request #694 from nirgal/patch-1
Minor spelling in documetation
Tobias Oetiker [Thu, 28 Jan 2016 21:16:28 +0000 (22:16 +0100)]
make sure people don't confuse the MASTER branche with the 1.5 branche ...
Tobias Oetiker [Tue, 5 Jan 2016 10:14:54 +0000 (11:14 +0100)]
Merge pull request #696 from jskiba99/fix-typo
Fix spelling typos
Jacob [Fri, 1 Jan 2016 00:52:07 +0000 (19:52 -0500)]
Fix spelling typos
nirgal [Sat, 26 Dec 2015 22:25:59 +0000 (23:25 +0100)]
Minor spelling in documetation
Tobias Oetiker [Sun, 20 Dec 2015 10:05:43 +0000 (11:05 +0100)]
Merge pull request #693 from ntyni/master
Use memmove instead of memcpy in rrd_write() to fix undefined behaviour
Niko Tyni [Sun, 20 Dec 2015 07:49:14 +0000 (09:49 +0200)]
Use memmove instead of memcpy in rrd_write() to fix undefined behaviour
At least rrdtune ends up calling rrd_write() with the same memory
area for the source and the destination, causing undefined behaviour
that has been observed to actually break on the mips architecture.
Bug-Debian: https://bugs.debian.org/805391
Bug: https://github.com/oetiker/rrdtool-1.x/issues/688
Tobias Oetiker [Wed, 9 Dec 2015 08:56:29 +0000 (09:56 +0100)]
Merge pull request #692 from RomeroMalaquias/master
Avoiding conditional directives that split up parts of statements.
Romero Malaquias [Wed, 9 Dec 2015 03:42:12 +0000 (00:42 -0300)]
Avoiding conditional directives that split up parts of statements.
Tobias Oetiker [Mon, 7 Dec 2015 07:57:49 +0000 (08:57 +0100)]
--use-mirrors is not supported anymore
Tobias Oetiker [Mon, 7 Dec 2015 07:50:51 +0000 (08:50 +0100)]
Merge pull request #691 from pocek/typo
doc: Fix a typo in an example
Krzysztof Kotlenga [Fri, 4 Dec 2015 16:59:35 +0000 (17:59 +0100)]
doc: Fix a typo in an example
Tobias Oetiker [Thu, 3 Dec 2015 05:13:13 +0000 (06:13 +0100)]
Merge pull request #690 from gustavoz/master
Add configure option to disable documentation
Gustavo Zacarias [Wed, 2 Dec 2015 17:31:52 +0000 (14:31 -0300)]
Add configure option to disable documentation
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Tobias Oetiker [Sun, 22 Nov 2015 15:08:02 +0000 (10:08 -0500)]
Merge pull request #689 from pocek/mtotal
doc: Fix NEWMONTH example
Krzysztof Kotlenga [Sun, 22 Nov 2015 14:23:18 +0000 (15:23 +0100)]
doc: Fix NEWMONTH example
Make it actually accumulate values over a period.
Tobias Oetiker [Thu, 12 Nov 2015 03:14:41 +0000 (22:14 -0500)]
Merge pull request #687 from GrayTShirt/#686
Export rrdc_create and rrdc_create_r2 - Dan Molik <dan@d3fy.net>
Dan Molik [Tue, 10 Nov 2015 19:38:48 +0000 (14:38 -0500)]
Export rrdc_create and rrdc_create_r2 - Dan Molik <dan@d3fy.net>
Export the client functions that create rrds
Tobias Oetiker [Tue, 10 Nov 2015 19:02:32 +0000 (20:02 +0100)]
remove rrd_th since we are now thread safe by default
Tobias Oetiker [Tue, 10 Nov 2015 19:02:28 +0000 (20:02 +0100)]
remove rrd_th since we are now thread safe by default
Tobias Oetiker [Tue, 10 Nov 2015 16:05:01 +0000 (11:05 -0500)]
Merge pull request #685 from odoucet/master
Fix JSON and JSONTIME export with gprints or rules
Tobias Oetiker [Tue, 10 Nov 2015 15:08:24 +0000 (16:08 +0100)]
Merge branch '1.5' of github.com:oetiker/rrdtool-1.x
Conflicts:
README.md
Tobias Oetiker [Tue, 10 Nov 2015 15:02:10 +0000 (10:02 -0500)]
Merge pull request #667 from nirgal/python_paralellism
Unlock the global thread lock while processing rrd
Tobias Oetiker [Tue, 10 Nov 2015 15:01:54 +0000 (10:01 -0500)]
Merge pull request #683 from nirgal/updatev_skippastupdates
Fix --skip-past-updates support in updatev
Tobias Oetiker [Tue, 10 Nov 2015 15:01:40 +0000 (10:01 -0500)]
Merge pull request #682 from nirgal/rrdcached_longopt
Switch rrdcached to use long options
Tobias Oetiker [Tue, 10 Nov 2015 15:01:12 +0000 (10:01 -0500)]
Merge pull request #681 from nirgal/nogetopt
removing all getopt traces
Tobias Oetiker [Tue, 10 Nov 2015 14:52:37 +0000 (09:52 -0500)]
Merge pull request #679 from nirgal/optparse
Switch all getops to optparse
Olivier Doucet [Fri, 6 Nov 2015 18:50:07 +0000 (19:50 +0100)]
Fix JSON and JSONTIME export with gprints or rules
When you have gprints or rules, json is not formated correctly : a comma is inserted after each block, making two mistakes :
- there is no comma between "legend" and "gprints" block
- there is a trailing comma in "meta" block
I decided to rewrite this part and add the comma before each block, so this works in all cases : when you don't have any block, only one of them or both.
Olivier Doucet [Fri, 6 Nov 2015 18:12:08 +0000 (19:12 +0100)]
Typo fix
Jean-Michel Vourgère [Mon, 2 Nov 2015 10:35:14 +0000 (11:35 +0100)]
Removed getopt now unused
Removed getopt sources, adjusted configure, POTFILES, src/Makefile.am.
rrdtool.sym no longer is generated.
Tobias Oetiker [Mon, 2 Nov 2015 22:30:46 +0000 (23:30 +0100)]
Merge pull request #684 from nirgal/doc_xport_showtime
Documentation: Show -t option to rrd xport
Jean-Michel Vourgère [Mon, 2 Nov 2015 15:47:33 +0000 (16:47 +0100)]
Documentation: Show -t option to rrd xport
Jean-Michel Vourgère [Mon, 2 Nov 2015 15:26:58 +0000 (16:26 +0100)]
Fix --skip-past-updates support in updatev
Jean-Michel Vourgère [Mon, 2 Nov 2015 14:32:26 +0000 (15:32 +0100)]
Switch rrd_daemon to use long options
This includes --help option (Fixes https://github.com/oetiker/rrdtool-1.x/issues/495)
Jean-Michel Vourgère [Sun, 1 Nov 2015 15:40:45 +0000 (16:40 +0100)]
Thread safety: Replace getopt by optparse
* Added optparse.h to src/rrd_tool.h.
* rrd_graph.[ch]: The 3rd char* parameter of the "*_conv" functions was added a const modifier.
* rrd_tune.c: The 3rd char* parameter of the "set_*" functions was added a const modifier.
* rrd_graph_options now takes an extra "options*" parameter, so that caller can use options.argc and options.argv
* Refresh WIN32 build tips
Jean-Michel Vourgère [Sat, 31 Oct 2015 18:37:41 +0000 (19:37 +0100)]
Fix typo in --interlaced option in examples
Jean-Michel Vourgère [Sat, 31 Oct 2015 09:52:43 +0000 (10:52 +0100)]
Add/fix dashdash support in optparse_long
This changes the behaviour of optparse_long so that a '--' tags the end of
options, just like optparse and getopt_long.
Tobias Oetiker [Tue, 27 Oct 2015 13:20:11 +0000 (14:20 +0100)]
Merge pull request #665 from nirgal/no_sigwaitinfo
Fixed compilation when there's no sigwaitinfo
Tobias Oetiker [Tue, 27 Oct 2015 13:14:19 +0000 (14:14 +0100)]
Merge pull request #678 from ufo-dd/1.5
rrd_parsetime now unlocks its mutex also after parsing errors.
Uwe Höhna [Sun, 25 Oct 2015 18:34:33 +0000 (19:34 +0100)]
Fix the double mutex_unlock call
Uwe Höhna [Fri, 23 Oct 2015 07:35:24 +0000 (09:35 +0200)]
rrd_parsetime now unlocks its mutex also after parsing errors.
Tobias Oetiker [Tue, 20 Oct 2015 08:43:29 +0000 (10:43 +0200)]
Merge pull request #677 from yath/1.5-rpnparse-null
Don't crash on invalid variable names in RPN
Sebastian Schmidt [Sun, 18 Oct 2015 17:15:37 +0000 (19:15 +0200)]
Don't crash on invalid variable names in RPN
When rpn_parse() finds [^\0,] after parsing a token, it returns NULL
without setting an error. This causes rrd_test_error() to return false
and subsequent code will dereference NULL (cf. rrdtool xport
CDEF:foo=foo-bar).
This commit changes the OP_VARIABLE branch in rpn_parse so that in order
to be a variable name, sscanf needs to match the full name, causing a
more meaningful "ERROR: don't understand 'illegal-variable-name'" error
message in that case. Also, I made the return NULL branch set an error
message so rrd_test_error() will succeed.
Tobias Oetiker [Tue, 22 Sep 2015 14:15:58 +0000 (16:15 +0200)]
Merge pull request #673 from oetiker/xport-time
fix xport incompatibility ... make it possible to re-include the time…
Tobias Oetiker [Tue, 22 Sep 2015 11:38:46 +0000 (13:38 +0200)]
fix xport incompatibility ... make it possible to re-include the time into the xml output
Tobias Oetiker [Mon, 21 Sep 2015 12:20:38 +0000 (14:20 +0200)]
Merge pull request #671 from z-jun/1.5
Fix recursive directory creation in rrdcached on FREEBSD
Zbynek Jun [Mon, 21 Sep 2015 11:27:39 +0000 (13:27 +0200)]
Fix recursive directory creation in rrdcached on FREEBSD
Tobias Oetiker [Fri, 11 Sep 2015 11:23:56 +0000 (13:23 +0200)]
rrdc_fetch needs locking too
Tobias Oetiker [Tue, 8 Sep 2015 20:58:21 +0000 (22:58 +0200)]
fix for buffer overflow in rrd_restore.c #669
Tobias Oetiker [Sat, 29 Aug 2015 22:50:21 +0000 (00:50 +0200)]
Merge pull request #668 from nirgal/lua_tests
Make tests work on lua 5.1 to 5.3
Jean-Michel Vourgère [Fri, 28 Aug 2015 12:12:27 +0000 (14:12 +0200)]
Make tests work on lua 5.1 to 5.3
Lua 5.0 test is kept for now in a separate file