]> git.ipfire.org Git - thirdparty/util-linux.git/log
thirdparty/util-linux.git
8 years agodocs: taskset(1): Wording fix
Michael Kerrisk [Mon, 5 Dec 2016 11:39:22 +0000 (12:39 +0100)] 
docs: taskset(1): Wording fix

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agodocs: namei(1): SEE ALSO: add symlink(7)
Michael Kerrisk [Mon, 5 Dec 2016 11:36:50 +0000 (12:36 +0100)] 
docs: namei(1): SEE ALSO: add symlink(7)

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agodocs: kill(1): Wording fix
Michael Kerrisk [Wed, 7 Dec 2016 13:04:17 +0000 (14:04 +0100)] 
docs: kill(1): Wording fix

Fix a wording error introduced in one of my recent commits.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agodocs: various pages: Use 'UID" and "GID", not "uid" and "gid" in man pages
Michael Kerrisk [Sun, 4 Dec 2016 19:51:32 +0000 (20:51 +0100)] 
docs: various pages: Use 'UID" and "GID", not "uid" and "gid" in man pages

Signed-off-by: Michael Kerrisk <mtk.man-pages@gmail.com>
8 years agodocs: various pages: Use "PID" not "pid" in man-pages
Michael Kerrisk [Sun, 4 Dec 2016 19:44:04 +0000 (20:44 +0100)] 
docs: various pages: Use "PID" not "pid" in man-pages

Signed-off-by: Michael Kerrisk <mtk.man-pages@gmail.com>
8 years agodocs: various pages: Use "ID" not "id" in man pages
Michael Kerrisk [Sun, 4 Dec 2016 19:40:01 +0000 (20:40 +0100)] 
docs: various pages: Use "ID" not "id" in man pages

The correct abbreviation of identifier is is "ID" (as used in
many pages), not "id" (as used in a few pages).

Signed-off-by: Michael Kerrisk <mtk.man-pages@gmail.com>
8 years agodocs: various pages: Use consistent terminology (set-user-ID and set-group-ID)
Michael Kerrisk [Sun, 4 Dec 2016 19:34:54 +0000 (20:34 +0100)] 
docs: various pages: Use consistent terminology (set-user-ID and set-group-ID)

Use consistent terminology for set-user-ID and set-group-ID bits.

There's much inconsistency in the pages. "suid",
"set-user-identifier", "setuid". Stick with one terminology,
"set-user-ID" and set-grout-ID, as suggested in man-pages(7).

Signed-off-by: <mtk.man-pages@gmail.com>
8 years agodocs: various pages: Format pathnames as italic (.I)
Michael Kerrisk [Sat, 3 Dec 2016 20:13:59 +0000 (21:13 +0100)] 
docs: various pages: Format pathnames as italic (.I)

In the majority of pages, pathnames are formatted as Italic,
which is the norm. However, there are several cases where they
are formatted as bold. This patch fixes a number of those
exceptions.

Signed-off-by: Michael Kerrisk <mtk.man-pages@gmail.com>
8 years agodocs: renice(1): Remove obsolete BUGS text
Michael Kerrisk [Fri, 9 Dec 2016 12:32:34 +0000 (13:32 +0100)] 
docs: renice(1): Remove obsolete BUGS text

Already at least as far back as util-linux 2.2, renice uses
getpriority(2) to fetch the process's old nice value. Thus,
the "problem" discussed in this BUGS note disappeared long ago.
This is trivially demonstrable:

    $ sleep 100 &
    [1] 24322
    $ renice -n 5 24322
    24322 (process ID) old priority 0, new priority 5
    $ renice -n 10 24322
    24322 (process ID) old priority 5, new priority 10

Rather than trying to explain the ancient problem (20 years old?),
just kill this text.

Signed-off-by: Michael Kerrisk <mtk.man-pages@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agodocs: renice(1): Rework discussion of unprivileged users,
Michael Kerrisk [Fri, 9 Dec 2016 12:25:20 +0000 (13:25 +0100)] 
docs: renice(1): Rework discussion of unprivileged users,

The BUGS section describing the limitations on what an unprivileged
user may do to the nice value is outdated, given the kernel changes
that added RLIMIT_NICE in Linux 2.6.12. So, remove that text.

The revised details for modern Linux were partially covered in NOTES,
but there were also inaccuracies there (and the use of the word
"monotonically" was unneeded). In particular, the point is that
unprivileged users can only increase the nice value. There is no
restriction particular to the range 0..+19. So, for example, the
following scenario is possible:

1. Superuser sets the nice value of an unprivileged user's
   process to -20.
2. The unprivileged user can now renice that process to (say) -10.

Signed-off-by: Michael Kerrisk <mtk.man-pages@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agohwclock: don't check for permissions
Karel Zak [Fri, 9 Dec 2016 08:47:33 +0000 (09:47 +0100)] 
hwclock: don't check for permissions

The right place to verify user permissions is kernel. The current
situation is too strict (due to previous attempts to use hwclock as
suid that has never been supported).

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agosulogin: bail out from getpasswd(...) on timeout
Andreas Henriksson [Mon, 28 Nov 2016 16:24:50 +0000 (17:24 +0100)] 
sulogin: bail out from getpasswd(...) on timeout

If timeout happens while waiting in prompt, bail out instead
of retrying.

Reported-by: Bjørn Mork <bjorn@mork.no>
Addresses: http://bugs.debian.org/846107
Signed-off-by: Andreas Henriksson <andreas@fatal.se>
8 years agosulogin: make getpasswd(...) return NULL on ^D
Andreas Henriksson [Mon, 28 Nov 2016 16:24:49 +0000 (17:24 +0100)] 
sulogin: make getpasswd(...) return NULL on ^D

This makes the caller bail out early instead of evaluating the
input as a password.

Reported-by: Bjørn Mork <bjorn@mork.no>
Addresses: http://bugs.debian.org/846112
Signed-off-by: Andreas Henriksson <andreas@fatal.se>
8 years agodocs: kill(1): Wording fix
Michael Kerrisk [Mon, 5 Dec 2016 09:46:48 +0000 (10:46 +0100)] 
docs: kill(1): Wording fix

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agodocs: kill(1): Formatting fixes
Michael Kerrisk [Mon, 5 Dec 2016 09:43:53 +0000 (10:43 +0100)] 
docs: kill(1): Formatting fixes

Formatting fixes for constants and structure/field names, as
per man-pages(7).

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agodocs: kill(1): Rework notes on thread groups
Michael Kerrisk [Mon, 5 Dec 2016 09:38:53 +0000 (10:38 +0100)] 
docs: kill(1): Rework notes on thread groups

The points in the NOTES can be expressed more compactly
(there is some redundancy in the two existing paragraphs).

Also, add a reference to signal(7), since this provides
much more detail on the topic.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agodocs: kill(1): Add more detail on use of SIGTERM vs SIGKILL
Michael Kerrisk [Mon, 5 Dec 2016 09:24:54 +0000 (10:24 +0100)] 
docs: kill(1): Add more detail on use of SIGTERM vs SIGKILL

It's worth adding a recommendation here to use SIGTERM
rather than SIGKILL, and explain why.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agodocs: kill(1): Fix section reference for sigqueue(3) and add to SEE ALSO
Michael Kerrisk [Sat, 3 Dec 2016 19:37:51 +0000 (20:37 +0100)] 
docs: kill(1): Fix section reference for sigqueue(3) and add to SEE ALSO

Signed-off-by: Michael Kerrisk <mtk.man-pages@gmail.com>
8 years agodocs: various pages: Use "system call" not "syscall"
Michael Kerrisk [Sun, 4 Dec 2016 16:44:55 +0000 (17:44 +0100)] 
docs: various pages: Use "system call" not "syscall"

A minor wording fix...

Signed-off-by: Michael Kerrisk <mtk.man-pages@gmail.com>
8 years agochrt: default to SCHED_RR policy
Andreas Henriksson [Fri, 2 Dec 2016 14:10:18 +0000 (15:10 +0100)] 
chrt: default to SCHED_RR policy

This fixes a regression introduced in:

commit 7a4ea5664edba98bff28adec3a9c3cfb5763a495
"chrt: add control struct"

Previously (and as documented in the manpage) the default policy
was SCHED_RR. Now it's implicitly SCHED_OTHER (0) as the value
is not initialized explicitly anymore.

Test-command: chrt 90 echo hello

Reported-by: Patrick Pelissier <patrick.pelissier@gmail.com>
Addresses: http://bugs.debian.org/846572
Signed-off-by: Andreas Henriksson <andreas@fatal.se>
8 years agodocs: nsenter(1): add missing 'see also' for --user
Karel Zak [Mon, 5 Dec 2016 12:05:34 +0000 (13:05 +0100)] 
docs: nsenter(1): add missing 'see also' for --user

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agodocs: nsenter(1): Formatting fix
Michael Kerrisk [Mon, 5 Dec 2016 09:55:41 +0000 (10:55 +0100)] 
docs: nsenter(1): Formatting fix

Add formatting for 'file' argument used by various options.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agodocs: nsenter(1): Describe the 'file' argument used by namespace options
Michael Kerrisk [Mon, 5 Dec 2016 09:52:09 +0000 (10:52 +0100)] 
docs: nsenter(1): Describe the 'file' argument used by namespace options

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agolsns: Fix parser for /proc/<pid>/stat which is including space in comm
OGAWA Hirofumi [Wed, 23 Nov 2016 05:13:34 +0000 (14:13 +0900)] 
lsns: Fix parser for /proc/<pid>/stat which is including space in comm

For example, child process of spamd has

    32031 (spamd child) S 32026 32026 32026 0 -1 4210752 338 0 0 0 ...

fscanf("%d %*s %c %d*[^\n]") in read_process() can't parse above as we
expected, because %s only skips non-whitespace. I.e. it parses like
following,

    32031 (spamd child) S 32026 32026 32026 0 -1 4210752 338 0 0 0 ...
    +---+ +----+ +
      %d    %*s  %c

and returns 2 (pid=32031, state=c).

This fixes it by skipping task->comm part manually.

Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
8 years agosfdisk: cleanup --dump error messages
Karel Zak [Wed, 30 Nov 2016 09:53:56 +0000 (10:53 +0100)] 
sfdisk: cleanup --dump error messages

old:
  # truncate -s 1G empty && ./sfdisk --dump empty
  sfdisk: failed to dump partition table: Success

new:
  # truncate -s 1G empty && ./sfdisk --dump empty
  sfdisk: empty: does not contain a recognized partition table.

Addresses: https://github.com/karelzak/util-linux/issues/375
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agosfdisk: don't be silent when list non-existing device
Karel Zak [Tue, 29 Nov 2016 14:58:18 +0000 (15:58 +0100)] 
sfdisk: don't be silent when list non-existing device

Addresses: https://github.com/karelzak/util-linux/issues/376
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agobuild-sys: update package release number during development
Ruediger Meier [Thu, 17 Nov 2016 02:09:59 +0000 (03:09 +0100)] 
build-sys: update package release number during development

Now we use
   v2.29-5-g8ffab30  -> 2.29.5-8ffa   (libblkid 2.29.5)
instead of
   v2.29-5-g8ffab30  -> 2.29.5-8ffa   (libblkid 2.29.0)

otherwise the bugfix releases (2.29.1) would look newer that latest HEAD.

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
8 years agobuild-sys: fix empty package release number
Ruediger Meier [Thu, 17 Nov 2016 02:09:58 +0000 (03:09 +0100)] 
build-sys: fix empty package release number

Was broken for major releases since b0e6b25e:
  $ blkid -V
  blkid from util-linux 2.28  (libblkid 2.28., 12-Apr-2016)

Now we also set 0 in this case, like:
  $ blkid -V
  blkid from util-linux 2.30  (libblkid 2.30.0, 12-Apr-2016)

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
8 years agoIPC namespaces also isolate POSIX message queues
Michael Kerrisk (man-pages) [Thu, 10 Nov 2016 11:00:09 +0000 (12:00 +0100)] 
IPC namespaces also isolate POSIX message queues

As described in pid_namespaces(7), IPC namespaces also
isolate POSIX message queues. Update the unshare(1)
and nsenter(1) pages to clarify that.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agoProvide better cross references for namespace concepts
Michael Kerrisk (man-pages) [Thu, 10 Nov 2016 11:00:05 +0000 (12:00 +0100)] 
Provide better cross references for namespace concepts

For each namespace that is discussed, add more explicit
references to the corresponding clone(2) flags and
add references to relevant section 7 namespace pages.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agoProvide better cross references for namespace concepts
Michael Kerrisk (man-pages) [Thu, 10 Nov 2016 11:00:00 +0000 (12:00 +0100)] 
Provide better cross references for namespace concepts

For each namespace that is discussed, add more explicit
references to the corresponding clone(2) flags and
add references to relevant section 7 namespace pages.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agoSEE ALSO: add cross reference to namespaces(7)
Michael Kerrisk (man-pages) [Thu, 10 Nov 2016 10:59:57 +0000 (11:59 +0100)] 
SEE ALSO: add cross reference to namespaces(7)

Rationale: both of these pages are about namespaces.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agoReplace reference to sigvec(2) with sigaction(2)
Michael Kerrisk (man-pages) [Thu, 10 Nov 2016 10:59:53 +0000 (11:59 +0100)] 
Replace reference to sigvec(2) with sigaction(2)

The sigvec(3) (not sigvec(2)) page documents ancient BSD APIs.
The right page to cross reference here is sigaction(2),
which documents the modern POSIX APIs.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agoFix formatting errors in page cross references
Michael Kerrisk (man-pages) [Thu, 10 Nov 2016 10:59:49 +0000 (11:59 +0100)] 
Fix formatting errors in page cross references

These pages had errors such as

    .BR page (x) .

which should be

    .BR page (x).

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agoFix reference for scheduling discussion
Michael Kerrisk (man-pages) [Thu, 10 Nov 2016 10:59:45 +0000 (11:59 +0100)] 
Fix reference for scheduling discussion

Some time back, I moved the discussion of scheduling from
sched_setscheduler(2) to a new sched(7) page. Adjust the cross
reference in the taskset(1) page accordingly.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agoFix section number in lockf() page xref
Michael Kerrisk (man-pages) [Thu, 10 Nov 2016 10:59:40 +0000 (11:59 +0100)] 
Fix section number in lockf() page xref

lockf() is in section 3, not 2.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agoFix page cross references
Michael Kerrisk (man-pages) [Thu, 10 Nov 2016 10:59:37 +0000 (11:59 +0100)] 
Fix page cross references

* Add a section number to page cross reference
* Format cross references in bold

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agoCorrectly format page cross references
Michael Kerrisk (man-pages) [Thu, 10 Nov 2016 10:59:30 +0000 (11:59 +0100)] 
Correctly format page cross references

Most pages in util-linux follow the standard convention
of formatting page cross references in bold. Fix the
few exceptions that use italic.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agoPlace SEE ALSO entries in order
Michael Kerrisk (man-pages) [Thu, 10 Nov 2016 10:59:27 +0000 (11:59 +0100)] 
Place SEE ALSO entries in order

This patch does only the following:

* Order SEE ALSO entries first by section name, then alphabetically
  within section
* Adds one or two missing commas in SEE ALSO lists
* Removes one or two periods that were (inconsistently) used
  at the end of SEE ALSO lists.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agoFix typo in page cross reference (capabilities(7), not, capability(7))
Michael Kerrisk (man-pages) [Thu, 10 Nov 2016 10:59:14 +0000 (11:59 +0100)] 
Fix typo in page cross reference (capabilities(7), not, capability(7))

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
8 years agobuild-sys: release++ (v2.29) v2.29
Karel Zak [Tue, 8 Nov 2016 10:35:40 +0000 (11:35 +0100)] 
build-sys: release++ (v2.29)

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agodocs: update v2.29-ReleaseNotes
Karel Zak [Tue, 8 Nov 2016 10:34:10 +0000 (11:34 +0100)] 
docs: update v2.29-ReleaseNotes

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agopo: merge changes
Karel Zak [Tue, 8 Nov 2016 10:16:52 +0000 (11:16 +0100)] 
po: merge changes

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agopo: update zh_CN.po (from translationproject.org)
Wylmer Wang [Tue, 8 Nov 2016 10:07:39 +0000 (11:07 +0100)] 
po: update zh_CN.po (from translationproject.org)

8 years agopo: update uk.po (from translationproject.org)
Yuri Chornoivan [Tue, 8 Nov 2016 10:07:39 +0000 (11:07 +0100)] 
po: update uk.po (from translationproject.org)

8 years agopo: update sv.po (from translationproject.org)
Sebastian Rasmussen [Tue, 8 Nov 2016 10:07:39 +0000 (11:07 +0100)] 
po: update sv.po (from translationproject.org)

8 years agopo: update pl.po (from translationproject.org)
Jakub Bogusz [Tue, 8 Nov 2016 10:07:39 +0000 (11:07 +0100)] 
po: update pl.po (from translationproject.org)

8 years agopo: update nl.po (from translationproject.org)
Benno Schulenberg [Tue, 8 Nov 2016 10:07:39 +0000 (11:07 +0100)] 
po: update nl.po (from translationproject.org)

8 years agopo: update es.po (from translationproject.org)
Antonio Ceballos Roa [Tue, 8 Nov 2016 10:07:39 +0000 (11:07 +0100)] 
po: update es.po (from translationproject.org)

8 years agopo: update de.po (from translationproject.org)
Philipp Thomas [Tue, 8 Nov 2016 10:07:39 +0000 (11:07 +0100)] 
po: update de.po (from translationproject.org)

8 years agotests: let lsmod fail silently
Ruediger Meier [Mon, 7 Nov 2016 08:35:17 +0000 (09:35 +0100)] 
tests: let lsmod fail silently

This is mostly for non-Linux systems where lsmod is not
even available.

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
8 years agotests: always quote $LODEV
Ruediger Meier [Sat, 5 Nov 2016 15:08:09 +0000 (16:08 +0100)] 
tests: always quote $LODEV

Since there is no error handling in this test $LODEV
may be empty.

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
8 years agotests: replace sleep by udevadm
Ruediger Meier [Sat, 5 Nov 2016 15:08:08 +0000 (16:08 +0100)] 
tests: replace sleep by udevadm

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
CC: Stanislav Brabec <sbrabec@suse.cz>
8 years agotests: udevadm settle before losetup -d
Ruediger Meier [Sat, 5 Nov 2016 15:08:07 +0000 (16:08 +0100)] 
tests: udevadm settle before losetup -d

Fails on Debian 7 (wheezy), Kernel 3.2.

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
CC: Stanislav Brabec <sbrabec@suse.cz>
8 years agodocs: update TODO file
Karel Zak [Mon, 7 Nov 2016 09:19:16 +0000 (10:19 +0100)] 
docs: update TODO file

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agolscpu: disable is_vmware_platform() for non-root users
Karel Zak [Thu, 3 Nov 2016 09:53:09 +0000 (10:53 +0100)] 
lscpu: disable is_vmware_platform() for non-root users

References: http://www.spinics.net/lists/util-linux-ng/msg13302.html
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agotests: check for timeout prog
Karel Zak [Wed, 2 Nov 2016 23:01:23 +0000 (00:01 +0100)] 
tests: check for timeout prog

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agotests: wait for flock background process
Ruediger Meier [Wed, 2 Nov 2016 14:31:55 +0000 (15:31 +0100)] 
tests: wait for flock background process

Maybe we should add a --daemonize option to flock to cover
this use case.

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
8 years agolsblk: add note about --sort and --list relation
Karel Zak [Wed, 2 Nov 2016 13:47:37 +0000 (14:47 +0100)] 
lsblk: add note about --sort and --list relation

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agolsblk: sort by MAJ:MIN by default
Karel Zak [Wed, 2 Nov 2016 13:40:31 +0000 (14:40 +0100)] 
lsblk: sort by MAJ:MIN by default

Since Linux kernel 4.8 /sys entries are no more sorted and all is
in the native order. It makes lsblk output messy.

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agolibsmartcols: make scols_sort_table() usable for trees
Karel Zak [Wed, 2 Nov 2016 13:39:08 +0000 (14:39 +0100)] 
libsmartcols: make scols_sort_table() usable for trees

We also need to sort children when tree is enabled.

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agolibfdisk: fix typo
Karel Zak [Wed, 2 Nov 2016 11:56:06 +0000 (12:56 +0100)] 
libfdisk: fix typo

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agotests: add flock tests
Karel Zak [Mon, 31 Oct 2016 13:30:02 +0000 (14:30 +0100)] 
tests: add flock tests

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agoflocks: keep run_program() simple
Karel Zak [Mon, 31 Oct 2016 12:15:35 +0000 (13:15 +0100)] 
flocks: keep run_program() simple

8 years agoMerge branch 'fixes-for-v2.29' of https://github.com/rudimeier/util-linux
Karel Zak [Mon, 31 Oct 2016 12:03:47 +0000 (13:03 +0100)] 
Merge branch 'fixes-for-v2.29' of https://github.com/rudimeier/util-linux

* 'fixes-for-v2.29' of https://github.com/rudimeier/util-linux:
  misc: once again some printf format strings
  misc: fix some compiler warnings
  chrt: fix HAVE_SCHED_SETATTR fallback case
  fdisk: fix memleak in list_disk_geometry()

8 years agoflock: fix no-flock patch
Karel Zak [Mon, 31 Oct 2016 11:50:31 +0000 (12:50 +0100)] 
flock: fix no-flock patch

Addresses: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=842598
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agomount: append inverting options for mount.<type> on "users"
Karel Zak [Thu, 27 Oct 2016 13:30:20 +0000 (15:30 +0200)] 
mount: append inverting options for mount.<type> on "users"

If you call mount(8) as root, then we need to append inverting options
(if specified by fstab) for "user" and "users" to /sbin/mount.<type>
command line, because for UID=0 mount.nfs follows command line rather
than the fstab setting.

This has been originally implemented by commit
a4c0cc75ff9744299f108c259efab1bd30c8007a for the old mount(8). The
same feature is supported by libmount, unfortunately for "user" only.
We need the same also for "users" to be backwardly compatible.

Addresses: https://github.com/karelzak/util-linux/issues/368
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agomisc: once again some printf format strings
Ruediger Meier [Wed, 26 Oct 2016 21:04:44 +0000 (23:04 +0200)] 
misc: once again some printf format strings

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
8 years agomisc: fix some compiler warnings
Ruediger Meier [Wed, 26 Oct 2016 18:44:15 +0000 (20:44 +0200)] 
misc: fix some compiler warnings

  libsmartcols/samples/fromfile.c:59:2: warning: passing argument 3 of 'string_to_bitmask' from incompatible pointer type
  text-utils/pg.c:79:0: warning: "TABSIZE" redefined
  libblkid/src/read.c:455:13: warning: 'debug_dump_dev' defined but not used [-Wunused-function]
  libblkid/src/probe.c:769:13: warning: unused function 'cdrom_size_correction' [-Wunused-function]
  /usr/include/sys/termios.h:3:2: warning: "this file includes <sys/termios.h> which is deprecated, use <termios.h> instead" [-W#warnings]

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
8 years agochrt: fix HAVE_SCHED_SETATTR fallback case
Ruediger Meier [Wed, 26 Oct 2016 17:46:22 +0000 (19:46 +0200)] 
chrt: fix HAVE_SCHED_SETATTR fallback case

Broken since 6f27e449. We could not enter the fallback
if HAVE_SCHED_SETATTR is not defined.

Two gcc warnings made this issue visible:
  schedutils/chrt.c:247:1: warning: label 'fallback' defined but not used [-Wunused-label]
  schedutils/chrt.c:266:9: warning: 'policy' may be used uninitialized in this function [-Wuninitialized]

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
8 years agofdisk: fix memleak in list_disk_geometry()
Ruediger Meier [Wed, 26 Oct 2016 16:13:59 +0000 (18:13 +0200)] 
fdisk: fix memleak in list_disk_geometry()

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
8 years agolibfdisk: cleanup labelitem initialization
Karel Zak [Thu, 27 Oct 2016 08:51:59 +0000 (10:51 +0200)] 
libfdisk: cleanup labelitem initialization

* use macro for label initialization
* make sure we do not call fdisk_ref_labelitem() and
  fdisk_unref_labelitem() for non-allocated items

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agolibfdisk: fix uninitialized fdisk_labelitem
Ruediger Meier [Wed, 26 Oct 2016 15:04:30 +0000 (17:04 +0200)] 
libfdisk: fix uninitialized fdisk_labelitem

fdisk -l could crash randomly. Only seen on some i586 systems with
certain exotic compiler options.

The problem was that this item is later used in
function fdisk_reset_labelitem() like this:

    if (li->type == 's')
        free(li->data.str);

This may crash if item is randomly initialized.

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
8 years agotests: add sfdisk script case-insensitive test
Karel Zak [Wed, 26 Oct 2016 12:08:29 +0000 (14:08 +0200)] 
tests: add sfdisk script case-insensitive test

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agolibfdisk: (script) make bootable flag parsing more robust
Karel Zak [Wed, 26 Oct 2016 12:01:29 +0000 (14:01 +0200)] 
libfdisk: (script) make bootable flag parsing more robust

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agolibfdisk: add trivial script test
Karel Zak [Wed, 26 Oct 2016 11:50:10 +0000 (13:50 +0200)] 
libfdisk: add trivial script test

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agofdisk: fix compiler warning
Karel Zak [Wed, 26 Oct 2016 08:28:41 +0000 (10:28 +0200)] 
fdisk: fix compiler warning

disk-utils/fdisk-menu.c: In function ‘gpt_menu_cb’:
disk-utils/fdisk-menu.c:709: warning: passing argument 6 of ‘fdisk_ask_number’ from incompatible pointer type
./libfdisk/src/libfdisk.h:688: note: expected ‘uintmax_t *’ but argument is of type ‘long unsigned int *’

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agoMerge branch 'tests-raid1' of https://github.com/rudimeier/util-linux
Karel Zak [Wed, 26 Oct 2016 08:22:40 +0000 (10:22 +0200)] 
Merge branch 'tests-raid1' of https://github.com/rudimeier/util-linux

8 years agomisc: fix unsigned int usage for ctype.h functions
Karel Zak [Wed, 26 Oct 2016 08:13:03 +0000 (10:13 +0200)] 
misc: fix unsigned int usage for ctype.h functions

Reported-by: "Yuriy M. Kaminskiy" <yumkam@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agortcwake: add note about RTC limits
Karel Zak [Tue, 25 Oct 2016 14:52:43 +0000 (16:52 +0200)] 
rtcwake: add note about RTC limits

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agotests: let's follow ts_scsi_debug_rmmod
Karel Zak [Tue, 25 Oct 2016 12:33:08 +0000 (14:33 +0200)] 
tests: let's follow ts_scsi_debug_rmmod

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agoMerge branch 'test-rmmod-scsi_debug' of https://github.com/rudimeier/util-linux
Karel Zak [Tue, 25 Oct 2016 12:31:23 +0000 (14:31 +0200)] 
Merge branch 'test-rmmod-scsi_debug' of https://github.com/rudimeier/util-linux

* 'test-rmmod-scsi_debug' of https://github.com/rudimeier/util-linux:
  tests: consolidate rmmod scsi_debug

8 years agodocs: add sfdisk scripts quotes issue to TODO file
Karel Zak [Tue, 25 Oct 2016 12:26:42 +0000 (14:26 +0200)] 
docs: add sfdisk scripts quotes issue to TODO file

Addresses: https://github.com/karelzak/util-linux/issues/367
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agotests: add another sfdisk script tests
Karel Zak [Tue, 25 Oct 2016 11:43:48 +0000 (13:43 +0200)] 
tests: add another sfdisk script tests

Addresses: https://github.com/karelzak/util-linux/issues/367
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agolibfdisk: make script token parser more robust
Karel Zak [Tue, 25 Oct 2016 11:41:10 +0000 (13:41 +0200)] 
libfdisk: make script token parser more robust

* make sure token is terminated
* skip closing quotes
* allow extra space after quotes and before terminater
* skip extra space after terminater

Addresses: https://github.com/karelzak/util-linux/issues/367
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agotests: add sfdisk Type= and Id= test
Karel Zak [Tue, 25 Oct 2016 10:34:49 +0000 (12:34 +0200)] 
tests: add sfdisk Type= and Id= test

Addresses: https://github.com/karelzak/util-linux/issues/367
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agolibfdisk: fix script Type= and Id= parsing
Karel Zak [Tue, 25 Oct 2016 10:32:23 +0000 (12:32 +0200)] 
libfdisk: fix script Type= and Id= parsing

The parser is not consistent and *case insensitive* Type= and Id= tokens
are not expected on all places.

Addresses: https://github.com/karelzak/util-linux/issues/367
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agotests: add GPT attributes parser tests
Karel Zak [Tue, 25 Oct 2016 10:12:49 +0000 (12:12 +0200)] 
tests: add GPT attributes parser tests

Addresses: https://github.com/karelzak/util-linux/issues/367
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agolibfdisk: (gpt) make attributes parser more robust
Karel Zak [Tue, 25 Oct 2016 10:08:58 +0000 (12:08 +0200)] 
libfdisk: (gpt) make attributes parser more robust

* allow GUID: prefix only for numbers
* require space or comma separator

Addresses: https://github.com/karelzak/util-linux/issues/367
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agoMerge branch 'master' of https://github.com/yurchor/util-linux
Karel Zak [Mon, 24 Oct 2016 13:05:56 +0000 (15:05 +0200)] 
Merge branch 'master' of https://github.com/yurchor/util-linux

* 'master' of https://github.com/yurchor/util-linux:
  Fix minor typos

8 years agobuild-sys: improve libncursesw5 install for travis
Karel Zak [Fri, 21 Oct 2016 16:48:10 +0000 (18:48 +0200)] 
build-sys: improve libncursesw5 install for travis

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agotest: fix raid1 minimum I/O size
Ruediger Meier [Fri, 21 Oct 2016 14:19:29 +0000 (16:19 +0200)] 
test: fix raid1 minimum I/O size

Seems this has been changed in kernels >4.4.x or >4.8
from 512 bytes to 64K.

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
8 years agotests: consolidate rmmod scsi_debug
Ruediger Meier [Fri, 21 Oct 2016 11:01:55 +0000 (13:01 +0200)] 
tests: consolidate rmmod scsi_debug

 - auto cleanup on test exit
 - Add smart timeout: Newer openSUSE systems on OBS failed to rmmod
   almost always. udevadm settle does not seem to have any affect.
 - now tests will fail if rmmod fails

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
8 years agogetopt: be sure that options array is terminated
Karel Zak [Fri, 21 Oct 2016 11:51:48 +0000 (13:51 +0200)] 
getopt: be sure that options array is terminated

Reported-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agoMerge branch 'test-fixes' of https://github.com/rudimeier/util-linux
Karel Zak [Fri, 21 Oct 2016 11:34:28 +0000 (13:34 +0200)] 
Merge branch 'test-fixes' of https://github.com/rudimeier/util-linux

* 'test-fixes' of https://github.com/rudimeier/util-linux:
  build-sys: fix missing ncursesw message
  tests: avoid &>> for bash compatibility

8 years agobuild-sys: fix drone.io builds
Karel Zak [Fri, 21 Oct 2016 11:33:32 +0000 (13:33 +0200)] 
build-sys: fix drone.io builds

Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agobuild-sys: fix missing ncursesw message
Ruediger Meier [Thu, 20 Oct 2016 08:50:04 +0000 (10:50 +0200)] 
build-sys: fix missing ncursesw message

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
8 years agotests: avoid &>> for bash compatibility
Ruediger Meier [Wed, 19 Oct 2016 18:45:19 +0000 (20:45 +0200)] 
tests: avoid &>> for bash compatibility

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
8 years agotests: call umount --fake for tmpfs tests
Karel Zak [Thu, 20 Oct 2016 16:24:24 +0000 (18:24 +0200)] 
tests: call umount --fake for tmpfs tests

On old systems (e.g. RHEL6) with /sbin/mount.tmpfs the mtab file is
modified although our in-tree mount does not support mtab file. We
need to call umount --fake to be sure that we remove unwanted lines
from the test.

Reported-by: Ruediger Meier <sweet_f_a@gmx.de>
Signed-off-by: Karel Zak <kzak@redhat.com>
8 years agoFix minor typos
Yuri Chornoivan [Thu, 20 Oct 2016 16:08:57 +0000 (19:08 +0300)] 
Fix minor typos