[#3770] Addressed review comments

modified:   src/hooks/dhcp/mysql/mysql_host_data_source.cc
modified:   src/lib/dhcpsrv/cfg_option.cc
modified:   src/lib/dhcpsrv/tests/cfg_option_unittest.cc

[#3770] addressed review comments

[#3770] Fix dhcp6_options.modfication_ts

Fix dhcp6_options modification_ts column omitted in
original upgrade script and add checks of dhcp6_options changes

/src/bin/admin/tests/mysql_tests.sh.in
    mysql_upgrade_30_to_31_test()
    mysql_migrate_dhcpX_options_client_classes()
    - add dhcp6_options check

/src/bin/admin/tests/pgsql_tests.sh.in
    pgsql_upgrade_29_to_30_test()
    pgsql_migrate_dhcpX_options_client_classes()
    - add dhcp6_options check

/src/share/database/scripts/pgsql/dhcpdb_create.pgsql
    Include conditional add of dhcp6_columns.modification_ts

src/share/database/scripts/pgsql/upgrade_006.2_to_007.0.sh.in
    Add dhcp6_columns.modification_ts

/src/share/database/scripts/pgsql/upgrade_029_to_030.sh.in
    Include conditional add of dhcp6_columns.modification_ts

[#3770] Add client-classes to host back end

/src/hooks/dhcp/mysql/mysql_host_data_source.cc
/src/hooks/dhcp/pgsql/pgsql_host_data_source.cc
    Set and fetch host options' client-classes

/src/lib/dhcpsrv/testutils/generic_host_data_source_unittest.cc
    Update tests

/src/share/database/scripts/mysql/upgrade_030_to_031.sh.in
/src/share/database/scripts/mysql/dhcpdb_create.mysql
/src/share/database/scripts/pgsql/dhcpdb_create.pgsql
/src/share/database/scripts/pgsql/upgrade_029_to_030.sh.in
    update dhcp6_options table

[#3770] Update dhcp4_options in schema

Change dhcp4_options.client_classes NULL values with '[  ]'
Change dhcp4_options.client_classes column to NOT NULL

modified:   src/bin/admin/tests/mysql_tests.sh.in
modified:   src/bin/admin/tests/pgsql_tests.sh.in
modified:   src/lib/mysql/mysql_constants.h
modified:   src/lib/pgsql/pgsql_connection.h
modified:   src/share/database/scripts/mysql/dhcpdb_create.mysql
modified:   src/share/database/scripts/mysql/meson.build
new file:   src/share/database/scripts/mysql/upgrade_030_to_031.sh.in
modified:   src/share/database/scripts/pgsql/dhcpdb_create.pgsql
modified:   src/share/database/scripts/pgsql/meson.build
new file:   src/share/database/scripts/pgsql/upgrade_029_to_030.sh.in

[#3770] Minor clean up

modified:   src/lib/dhcpsrv/testutils/test_config_backend_dhcp4.cc

[#3770] V4 option cmds parse and use client-classes

/src/hooks/dhcp/cb_cmds/cb_cmds_dhcp4.cc
    ConfigCmdsDhcp4Impl::delSharedNetworkOption4()
    ConfigCmdsDhcp4Impl::delSubnetOption4()
    ConfigCmdsDhcp4Impl::delPoolOption4()
     - added client-classes parameter

/src/hooks/dhcp/cb_cmds/cb_cmds_dhcp6.cc
    ConfigCmdsDhcp6Impl::delGlobalOption6()
    ConfigCmdsDhcp6Impl::getGlobalOption6()
    ConfigCmdsDhcp4Impl::delSharedNetworkOption6()
    ConfigCmdsDhcp4Impl::delSubnetOption6()
    ConfigCmdsDhcp4Impl::delPoolOption6()
     - added client-classes parameter

/src/hooks/dhcp/cb_cmds/cb_cmds_impl.h
    makeOptionInfoElement(const OptionDefinition& def)
    makeOptionInfoElement(const OptionDescriptor& desc) - new convenience functions
    Use makeOptionInfoElement() for set() respsonses
    Update parseInputListElement() for shared-networks, subnets, pools

/src/hooks/dhcp/cb_cmds/tests/cb_cmds_test.h
    void checkOptionInfo() - new test func

/src/hooks/dhcp/cb_cmds/tests/option4_cmds_unittest.cc
    udpated test

/src/hooks/dhcp/cb_cmds/tests/option4_network_cmds_unittest.cc
    TEST_F(OptionNetwork4CmdsTest, networkOption4WithClientClasses)

/src/hooks/dhcp/cb_cmds/tests/option4_pool_cmds_unittest.cc
    TEST_F(OptionPool4CmdsTest, poolOption4WithClientClasses)

/src/hooks/dhcp/cb_cmds/tests/option4_subnet_cmds_unittest.cc
    TEST_F(OptionSubnet4CmdsTest, subnetOption4WithClientClasses)

/src/hooks/dhcp/cb_cmds/tests/option6_cmds_unittest.cc
    Use makeOptionInfoElement() for set() respsonses

[#3770] Clean up

/src/hooks/dhcp/pgsql/pgsql_cb_impl.cc
    PgSqlConfigBackendImpl::addClientClassesBinding()
    - use ClientClasses::toElement()

/src/lib/dhcpsrv/cfg_option.*
    ClientClassesPtr OptionDescriptor::copyClientClasses()
    - new convenience function

/src/lib/dhcpsrv/testutils/generic_cb_dhcp4_unittest.cc
    Use new convenience function

[#3770] Fix v6 UTs

src/lib/dhcpsrv/testutils/generic_cb_dhcp6_unittest.cc
 Fix globalOptions6WithServerTagsTest

[#3770] v4 global options work

Fixed fetch of global options added UT tests

/src/hooks/dhcp/mysql/mysql_cb_impl.cc
    MySqlConfigBackendImpl::getOptions() - take client-classes into account
    MySqlConfigBackendImpl::createInputClientClassesBinding() - use ClientClasses::toElement()

/src/hooks/dhcp/mysql/tests/mysql_cb_dhcp4_unittest.cc
    TEST_F(MySqlConfigBackendDHCPv4Test, globalOption4WithClientClassesTest)
    TEST_F(MySqlConfigBackendDHCPv4Test, getAllOptions4WithClientClassesTest)
    - new tests

/src/hooks/dhcp/pgsql/pgsql_cb_impl.cc
    PgSqlConfigBackendImpl::getOptions() - take client-classes into account

/src/hooks/dhcp/pgsql/tests/pgsql_cb_dhcp4_unittest.cc
    TEST_F(PgSqlConfigBackendDHCPv4Test, globalOption4WithClientClassesTest)
    TEST_F(PgSqlConfigBackendDHCPv4Test, getAllOptions4WithClientClassesTest)
    - new tests

/src/lib/dhcpsrv/parsers/option_data_parser.cc
    OptionDataParser::createOption() - use ClientClasses::fromElement()

/src/lib/dhcpsrv/testutils/generic_cb_dhcp4_unittest.*
    GenericConfigBackendDHCPv4Test::TearDown() - skip schema destroy
    if env variable KEA_UNIT_TEST_KEEP_SCHEMA is defined

    GenericConfigBackendDHCPv4Test::makeClassTaggedOptions()
    GenericConfigBackendDHCPv4Test::updateClassTaggedOptions()
    GenericConfigBackendDHCPv4Test::globalOption4WithClientClassesTest()
    GenericConfigBackendDHCPv4Test::getAllOptions4WithClientClassesTest()
    - new tests

[#3770] Finished MySql v4, Expanded v4 UTs

/src/hooks/dhcp/mysql/mysql_cb_dhcp4.*
/src/hooks/dhcp/mysql/mysql_cb_impl.cc
    Added client classes to where clauses as needed

/src/hooks/dhcp/mysql/tests/mysql_cb_dhcp4_unittest.cc
    TEST_F(MySqlConfigBackendDHCPv4Test, globalOption4WithClientClassesTest)
    TEST_F(MySqlConfigBackendDHCPv4Test, sharedNetworkOption4WithClientClassesTest)
    TEST_F(MySqlConfigBackendDHCPv4Test, subnetOption4WithClientClassesTest)
    TEST_F(MySqlConfigBackendDHCPv4Test, poolOption4WithClientClassesTest) - new tests

/src/hooks/dhcp/pgsql/tests/pgsql_cb_dhcp4_unittest.cc
    TEST_F(PgSqlConfigBackendDHCPv4Test, globalOption4WithClientClassesTest)
    TEST_F(PgSqlConfigBackendDHCPv4Test, sharedNetworkOption4WithClientClassesTest)
    TEST_F(PgSqlConfigBackendDHCPv4Test, subnetOption4WithClientClassesTest)
    TEST_F(PgSqlConfigBackendDHCPv4Test, poolOption4WithClientClassesTest) - new tests

/src/lib/dhcpsrv/testutils/generic_cb_dhcp4_unittest.cc
    New tests and functions

[#3770] CfgOption and CB v4 use client-classes

v4 CfgOption and CB internals support client-classes
as part of key for updating and delete options.

CB parsing does NOT yet support it as argument.

/src/lib/dhcpsrv/cfg_option.*
    Added composite key index type + client_classes to OptionContainer
    OptionDescriptor::equals() - add comparision of client_classes_
    CfgOption::replace() - Use new type + client_classes index

    CfgOption::del(const std::string& option_space, const uint16_t option_code,
                  const ClientClasses& client_classes) - new function

    CfgOption::get(const Selector& key, const uint16_t option_code,
                   ClientClasses& client_classes) - new function

    CfgOption::del(const std::string& option_space, const uint16_t option_code,
                  const ClientClasses& client_classes);

/src/hooks/dhcp/mysql/mysql_cb_dhcp4.*
    Added client-classes to createUpdate and delete option SQL statements and functions

/src/hooks/dhcp/mysql/mysql_cb_impl.*
    MySqlConfigBackendImpl::createClientClassesForWhereClause()  - new function

/src/hooks/dhcp/pgsql/pgsql_cb_dhcp4.*
    Added client-classes to createUpdate and delete option SQL statements and functions

/src/hooks/dhcp/pgsql/pgsql_cb_impl.cc
    PgSqlConfigBackendImpl::addClientClassesForWhereClause() - new function

/src/hooks/dhcp/pgsql/tests/pgsql_cb_dhcp4_unittest.cc

/src/hooks/dhcp/pgsql/tests/pgsql_cb_dhcp4_unittest.cc
    TEST_F(PgSqlConfigBackendDHCPv4Test, subnetOption4WithClienClassesTest) - new test

/src/lib/dhcp/classify.h b/src/lib/dhcp/classify.h
    Added typedef boost::shared_ptr<ClientClasses> ClientClassesPtr;

/src/lib/dhcpsrv/config_backend_dhcp4.h
/src/lib/dhcpsrv/config_backend_pool_dhcp4.*
    Udpated with client_classes parameter where needed

/src/lib/dhcpsrv/tests/cfg_option_unittest.cc
    TEST_F(CfgOptionTest, optionsWithClientClasses)
    TEST_F(CfgOptionTest, replaceWithClientClasses)
    TEST_F(CfgOptionTest, deleteWithClientClasses) - new tests

/src/lib/dhcpsrv/testutils/generic_cb_dhcp4_unittest.*
    GenericConfigBackendDHCPv4Test::subnetOption4WithClienClassesTest() - new test

/src/lib/dhcpsrv/testutils/test_config_backend_dhcp4.cc
    Update functions as needed

[kea-packaging#48] Hammer: Do not reset-failed kea-ctrl-agent because it no longer starts after installation so it no longer fails either

[#4005] Added doc and ChangeLog entry

[#3927] fixed TLS unit tests

[#3927] Doc and chmod fixes

[#3927] updated documentation

[#3927] remove ssl-mode for mysql

[#3927] Updated pgsql ssslmode code

[#3927] Updated the default to library one 2

[#3927] Updated the default to library one

[#3927] Indented SSL_MODE

[#3927] remove key-password

[#3927] add ssl-mode parameter

[#3927] fixed unit tests

[#3927] add TLS parameters to pgsql connection

[#3978] Correct reference to kea-lfc in 5.3.1

[#3848] Adapt packaging in Hammer to the -X changes

[#3848] Fix fuzzers after security enforcement

[#3848] Addressed review comments

modified:   src/bin/keactrl/kea-ctrl-agent.conf.pre

[#3848] Remove user from  default agent file

modified:   src/bin/keactrl/kea-ctrl-agent.conf.pre

[#3980] Removed outdated reference to SF portal

[#3848] Fix duplicated log ids

modified:   src/bin/dhcp4/dhcp4_messages.mes
modified:   src/bin/dhcp6/dhcp6_messages.mes
modified:   src/lib/d2srv/d2_messages.mes

[#3848] Fix element position reporting

modified:   src/lib/cc/data.cc
    altered data::copy() to also copy the source element's position

modified:   src/bin/dhcp4/json_config_parser.cc
modified:   src/hooks/dhcp/lease_query/tests/lease_query_impl4_unittest.cc
modified:   src/lib/http/tests/basic_auth_config_unittests.cc

[#3848] Change risk to policy

modified:   doc/sphinx/arm/agent.rst
modified:   doc/sphinx/arm/ddns.rst
modified:   doc/sphinx/arm/dhcp4-srv.rst
modified:   doc/sphinx/arm/dhcp6-srv.rst
modified:   doc/sphinx/arm/security.rst

[#3848] Replace WARN with WARNING some more

[#3848] Make message IDs consistent

[#3848] Fixed whitespace

[#3848] Addressed review comments

 Fixed minor nits

modified:   doc/sphinx/arm/agent.rst
modified:   doc/sphinx/arm/ddns.rst
modified:   doc/sphinx/arm/dhcp4-srv.rst
modified:   doc/sphinx/arm/dhcp6-srv.rst
modified:   doc/sphinx/arm/security.rst
modified:   src/bin/dhcp4/main.cc
modified:   src/bin/dhcp6/main.cc
modified:   src/hooks/dhcp/host_cache/tests/command_unittests.cc
modified:   src/hooks/dhcp/lease_cmds/lease_cmds.cc
modified:   src/hooks/dhcp/lease_cmds/lease_cmds_messages.cc
modified:   src/hooks/dhcp/lease_cmds/lease_cmds_messages.h
modified:   src/hooks/dhcp/lease_cmds/lease_cmds_messages.mes
modified:   src/hooks/dhcp/lease_cmds/libloadtests/lease_cmds4_unittest.cc
modified:   src/lib/d2srv/d2_config.cc
modified:   src/lib/hooks/tests/hooks_manager_unittest.cc
modified:   src/lib/http/tests/basic_auth_config_unittests.cc
modified:   src/lib/process/d_controller.cc
modified:   src/lib/util/filesystem.cc
modified:   src/lib/util/filesystem.h

[#3848] Updated the ARM

new file:   changelog_unreleased/3848-security-policy-security-strict-relaxed
modified:   doc/sphinx/arm/agent.rst
modified:   doc/sphinx/arm/ddns.rst
modified:   doc/sphinx/arm/dhcp4-srv.rst
modified:   doc/sphinx/arm/dhcp6-srv.rst
modified:   doc/sphinx/arm/security.rst

[#3848] Warn if running as root

Servers now all warn if they are running
as root.

[#3848] Detect authentication risks

Throw or Warn if API end points do not use some form
of authentication

Throw or Warn if 'user', 'password' - API end points
Throw or Warn if 'secret' is used  - TSIG

Disable/enable security for UTs as needed

modified:   src/bin/agent/tests/ca_cfg_mgr_unittests.cc
modified:   src/bin/agent/tests/ca_response_creator_unittests.cc
modified:   src/bin/agent/tests/get_config_unittest.cc
modified:   src/bin/d2/tests/d2_cfg_mgr_unittests.cc
modified:   src/bin/d2/tests/d2_command_unittest.cc
modified:   src/bin/d2/tests/d2_controller_unittests.cc
modified:   src/bin/d2/tests/d2_http_command_unittest.cc
modified:   src/bin/d2/tests/d2_process_unittests.cc
modified:   src/bin/d2/tests/d2_simple_parser_unittest.cc
modified:   src/bin/d2/tests/get_config_unittest.cc
modified:   src/bin/dhcp4/tests/config_parser_unittest.cc
modified:   src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
modified:   src/bin/dhcp4/tests/dhcp4_test_utils.cc
modified:   src/bin/dhcp4/tests/get_config_unittest.cc
modified:   src/bin/dhcp4/tests/get_config_unittest.cc.skel
modified:   src/bin/dhcp4/tests/http_control_socket_unittest.cc
modified:   src/bin/dhcp6/tests/config_parser_unittest.cc
modified:   src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
modified:   src/bin/dhcp6/tests/dhcp6_test_utils.cc
modified:   src/bin/dhcp6/tests/get_config_unittest.cc
modified:   src/bin/dhcp6/tests/get_config_unittest.cc.skel
modified:   src/bin/dhcp6/tests/http_control_socket_unittest.cc
modified:   src/lib/config/tests/http_command_config_unittests.cc
modified:   src/lib/d2srv/d2_config.cc
modified:   src/lib/d2srv/d2_messages.cc
modified:   src/lib/d2srv/d2_messages.h
modified:   src/lib/d2srv/d2_messages.mes
modified:   src/lib/http/auth_messages.cc
modified:   src/lib/http/auth_messages.h
modified:   src/lib/http/auth_messages.mes
modified:   src/lib/http/basic_auth_config.cc
modified:   src/lib/http/tests/basic_auth_config_unittests.cc
modified:   src/lib/testutils/dhcp_test_lib.sh.in

[#3848] Throw or Warn if API sockets are unsecured

/src/lib/config/config_messages.*
    COMMAND_HTTP_SOCKET_SECURITY_WARN - new message

/src/lib/config/http_command_config.*
    HttpCommandConfig::HttpCommandConfig() - throw or warn when
    socket is unsecured
    HttpCommandConfig::checkTlsSetup() - return true if valid TLS
    is configured

/src/lib/config/tests/http_command_config_unittests.cc
/src/lib/config/tests/http_command_mgr_unittests.cc
/src/lib/config/tests/http_command_response_creator_factory_unittests.cc
/src/lib/config/tests/http_command_response_creator_unittests.cc
    Udpated tests

[#3848] Warn on socket permissions

Warn if control socket path is valid but
socket permissions are wrong and security is
disabled.

modified:   src/lib/config/config_messages.cc
modified:   src/lib/config/config_messages.h
modified:   src/lib/config/config_messages.mes
modified:   src/lib/config/tests/unix_command_config_unittests.cc
modified:   src/lib/config/unix_command_config.cc

[#3848] Warn on invalid paths when security disabled

Warn but still use invalid paths when security is
disabled.

[#3967] release checklist update

[#3979] bump up kea version in meson.build

[#3973] release changes

[#3907] added ChangeLog entry

[#3907] use strict format for clients in yang

[#3907] NETCONF: Turn authentication.clients into a string just like hooks-libraries.parameters

[#3907] Progressed some more with YANG modules

[#3907] Progressed some more with YANG modules

[#3907] fixed some UTs

[#3907] clean up modules

[#3907] updated yang modules

[#3907] use tls for control-socket

[#3907] Get rid of skips in yang. Skip was always true

[#3907] fixed http-header yang parsing

[#3907] Add TranslatorControlSocket::getControlSocketHttpHeaders

[#3907] Update control sockets in YANG modules

[#3907] Update copyright dates

[#3907] Fix some paths about reinstall.sh

[#3907] Fix check-hashes.sh

[#3907] updated control-socket in yang modules

[#3907] updated yang modules

[#3968] lib version bump up for 3.0.0

[#3966] Added note about LTS

[#3966] security.md update

[#3919] Remove leftover incomplete sentence in bison.dox

[#3919] Spelling

[#3919] Get rid of most .gitignore files. No longer needed after switch to Meson

[#3919] Meson: Fix uml target

[#3919] Update meson docs

[#3919] Update Python dependencies

[#3919] Fix update-python-dependencies not writing to file

[#3919] Fix some TODOs related to autotools removal

[#3962] Meson: Fix "-D netconf=auto"

[#3881] Fixed config flag in the ARM

[#3881] Added ChangeLog for #3881

[#3881] Changes after review

[#3881] Right ref name this time maybe?

[#3881] Fix RST syntax snafus

[#3881] Typo fixes (hopefully final)

[#3881] Adapt d85666cf to this rewrite

[#3881] Overhaul my overhaul

[#3881] Future "planned" vs "will"

[#3881] Note Stork+Kea+CB issues

[#3881] Fix a few loose ends

[#3881] More comments regards sections

[#3881] Non-CB DB can conflict like JSON

[#3881] Add example scenario

[#3881] Move "Incompatibilities" further up

[#3881] "Incompatible": Revise, expand, wrap

[#3881] Major edit of "Duplicate Definitions"

[#3881] Copy edit "Incompatible Software"

Intensify avoidance of subnet_cmds hook.
Add: Stork is not currently compatible.

[#3881] copy edit sects: Install, Components

[#3881] Move "Configuration Files Inclusion"

The RST section on the JSON <?include> feature was put after the
RST include directive for the config-backend.rst file, resulting
in the "Configuration Files Inclusion" content accientally
appearing within the CB section.  Move it to fix and add an RST
comment to make the structure more obvious.

[#3881] Add subsect "Preparation is Required"

[#3881] Add/rename sections, move content within

New section "Installation"
Rename section "Capabilities and Limitations"
  to "Limitations and Warnings".
  It has little content about capabilities currently, except in the negative.
Add subsection headings within "Limitations".
Remove redundent leading "CB" from section names.
Move content around to better fit the section titles.
Demote some notes as they now have their own sections.
Minimal changes to content itself in this commit.