]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
5 months agoset secret flag based on source data
Alan T. DeKok [Thu, 6 Mar 2025 19:14:01 +0000 (14:14 -0500)] 
set secret flag based on source data

5 months agoMS-CHAP is plain-text equivalent.
Alan T. DeKok [Thu, 6 Mar 2025 19:02:50 +0000 (14:02 -0500)] 
MS-CHAP is plain-text equivalent.

Mark the Challenge field as secret, so that it doesn't get
exposed when people run the server in debug mode.

5 months agoremove '&'
Alan T. DeKok [Thu, 6 Mar 2025 17:25:14 +0000 (12:25 -0500)] 
remove '&'

5 months agoremove '&'
Alan T. DeKok [Thu, 6 Mar 2025 17:24:41 +0000 (12:24 -0500)] 
remove '&'

5 months agoremove '&' from delay
Alan T. DeKok [Thu, 6 Mar 2025 17:24:09 +0000 (12:24 -0500)] 
remove '&' from delay

5 months agoModule docs say this can be up to 5
Nick Porter [Thu, 6 Mar 2025 17:50:53 +0000 (17:50 +0000)] 
Module docs say this can be up to 5

5 months agoadd more and do tweaks
Alan T. DeKok [Thu, 6 Mar 2025 17:15:42 +0000 (12:15 -0500)] 
add more and do tweaks

5 months agodocs: Virtual Server section nav bar update. Landing pages for dhcp/dns/ldap added.
nolade [Thu, 6 Mar 2025 16:42:44 +0000 (11:42 -0500)] 
docs: Virtual Server section nav bar update. Landing pages for dhcp/dns/ldap added.

5 months agoremove '&' from krb5
Alan T. DeKok [Thu, 6 Mar 2025 16:24:01 +0000 (11:24 -0500)] 
remove '&' from krb5

5 months agoremove '&' from ldap
Alan T. DeKok [Thu, 6 Mar 2025 16:21:32 +0000 (11:21 -0500)] 
remove '&' from ldap

5 months agoremove '&' from linelog
Alan T. DeKok [Thu, 6 Mar 2025 16:19:25 +0000 (11:19 -0500)] 
remove '&' from linelog

5 months agoremove '&' from sql
Alan T. DeKok [Thu, 6 Mar 2025 16:16:39 +0000 (11:16 -0500)] 
remove '&' from sql

5 months agoremove '&' from cache
Alan T. DeKok [Thu, 6 Mar 2025 16:16:01 +0000 (11:16 -0500)] 
remove '&' from cache

5 months agoremove '&' from client module
Alan T. DeKok [Thu, 6 Mar 2025 16:10:42 +0000 (11:10 -0500)] 
remove '&' from client module

5 months agoremove '&' from exec
Alan T. DeKok [Thu, 6 Mar 2025 16:08:16 +0000 (11:08 -0500)] 
remove '&' from exec

and update the documentation

5 months agoremove more '&'
Alan T. DeKok [Thu, 6 Mar 2025 15:24:23 +0000 (10:24 -0500)] 
remove more '&'

5 months agoremove '&' from csv
Alan T. DeKok [Thu, 6 Mar 2025 15:19:38 +0000 (10:19 -0500)] 
remove '&' from csv

5 months agoremove '&' from rediswho
Alan T. DeKok [Thu, 6 Mar 2025 15:11:53 +0000 (10:11 -0500)] 
remove '&' from rediswho

and complain if the queries are missing

5 months agoremove '&' from mschap
Alan T. DeKok [Thu, 6 Mar 2025 15:04:14 +0000 (10:04 -0500)] 
remove '&' from mschap

5 months agoremove '&' from pap module
Alan T. DeKok [Thu, 6 Mar 2025 14:40:42 +0000 (09:40 -0500)] 
remove '&' from pap module

5 months agoremove '&' from sometimes module configuration
Alan T. DeKok [Thu, 6 Mar 2025 14:39:40 +0000 (09:39 -0500)] 
remove '&' from sometimes module configuration

5 months agoremove '&' from files module configuration
Alan T. DeKok [Thu, 6 Mar 2025 14:38:06 +0000 (09:38 -0500)] 
remove '&' from files module configuration

5 months agoremove '&' from passwd module configuration
Alan T. DeKok [Thu, 6 Mar 2025 14:31:34 +0000 (09:31 -0500)] 
remove '&' from passwd module configuration

5 months agoremove '&' from sqlippool configuration and source
Alan T. DeKok [Thu, 6 Mar 2025 14:30:40 +0000 (09:30 -0500)] 
remove '&' from sqlippool configuration and source

5 months agoproduce warnings and errors for attributes which have leading '&'
Alan T. DeKok [Thu, 6 Mar 2025 14:25:19 +0000 (09:25 -0500)] 
produce warnings and errors for attributes which have leading '&'

If we're in the new config and -C, produce a warning.

If the migration flag says to forbid '&', then we produce an
error.

5 months agoremove '&' from sqlcounter configuration and source
Alan T. DeKok [Thu, 6 Mar 2025 14:18:31 +0000 (09:18 -0500)] 
remove '&' from sqlcounter configuration and source

5 months agoAlways reset bio request
Nick Porter [Thu, 6 Mar 2025 16:16:34 +0000 (16:16 +0000)] 
Always reset bio request

5 months agoParent u->extra pairs from u
Nick Porter [Thu, 6 Mar 2025 16:15:24 +0000 (16:15 +0000)] 
Parent u->extra pairs from u

Makes freeing more consistent with all the different freeing paths.

5 months agoIf we're not saving the packet, clear u->packet
Nick Porter [Thu, 6 Mar 2025 16:14:04 +0000 (16:14 +0000)] 
If we're not saving the packet, clear u->packet

So bio_request_reset doesn't attempt to free it.

5 months agoHoist Module-Failue-Message from eap subrequest
Nick Porter [Wed, 5 Mar 2025 19:10:27 +0000 (19:10 +0000)] 
Hoist Module-Failue-Message from eap subrequest

So the parent request can log failure reasons

5 months agorearrange mods-available nav
Alan T. DeKok [Wed, 5 Mar 2025 11:49:34 +0000 (06:49 -0500)] 
rearrange mods-available nav

and add short summaries of the various modules

5 months agothis is no longer needed, we removed couchbase
Alan T. DeKok [Wed, 5 Mar 2025 11:48:43 +0000 (06:48 -0500)] 
this is no longer needed, we removed couchbase

5 months agoremove pre/post-proxy example
Alan T. DeKok [Wed, 5 Mar 2025 11:33:18 +0000 (06:33 -0500)] 
remove pre/post-proxy example

5 months agorlm_perl does support nested attributes now
Nick Porter [Wed, 5 Mar 2025 11:32:09 +0000 (11:32 +0000)] 
rlm_perl does support nested attributes now

5 months agoStart organizing the module navbar
nolade [Wed, 5 Mar 2025 00:49:07 +0000 (19:49 -0500)] 
Start organizing the module navbar

5 months agoFix capitalization of main nav items
nolade [Wed, 5 Mar 2025 00:26:21 +0000 (19:26 -0500)] 
Fix capitalization of main nav items

5 months agomove utility file to the proto_ldap_sync directory
Alan T. DeKok [Tue, 4 Mar 2025 15:18:41 +0000 (10:18 -0500)] 
move utility file to the proto_ldap_sync directory

5 months agotypo && rename
Alan T. DeKok [Tue, 4 Mar 2025 10:47:47 +0000 (05:47 -0500)] 
typo && rename

5 months agoadd more OIDs used in RADIUS
Alan T. DeKok [Mon, 3 Mar 2025 21:08:14 +0000 (16:08 -0500)] 
add more OIDs used in RADIUS

5 months agowe don't need marker_release
Alan T. DeKok [Mon, 3 Mar 2025 19:31:10 +0000 (14:31 -0500)] 
we don't need marker_release

as we're not putting markers into the parent dbuff, only into
our local one.

5 months agoAdd Calix attribute 50
Nick Porter [Tue, 4 Mar 2025 13:30:53 +0000 (13:30 +0000)] 
Add Calix attribute 50

5 months agohoist oid_from_str() to encode_oid()
Alan T. DeKok [Mon, 3 Mar 2025 14:27:03 +0000 (09:27 -0500)] 
hoist oid_from_str() to encode_oid()

5 months agomove encode extensions for fr_der_encode_oid_from_value()
Alan T. DeKok [Mon, 3 Mar 2025 14:18:52 +0000 (09:18 -0500)] 
move encode extensions for fr_der_encode_oid_from_value()

5 months agoclean up encode_oid_and_value
Alan T. DeKok [Mon, 3 Mar 2025 12:49:52 +0000 (07:49 -0500)] 
clean up encode_oid_and_value

5 months agodon't do encode(parser(print(da))).
Alan T. DeKok [Mon, 3 Mar 2025 12:30:15 +0000 (07:30 -0500)] 
don't do encode(parser(print(da))).

it's more code, and is much less efficient.

5 months agothe boolean "true" encoding is fixed, and can be hard-coded
Alan T. DeKok [Mon, 3 Mar 2025 12:12:04 +0000 (07:12 -0500)] 
the boolean "true" encoding is fixed, and can be hard-coded

5 months agoparsing OID from string
Alan T. DeKok [Mon, 3 Mar 2025 12:11:53 +0000 (07:11 -0500)] 
parsing OID from string

5 months agoclean up handling of raw attributes
Alan T. DeKok [Sun, 2 Mar 2025 20:52:45 +0000 (15:52 -0500)] 
clean up handling of raw attributes

we are able to decode mand encode raw options, while keeping the
class and option number.

Pretty much everything else is a gamble. :(

foo

5 months agoover-ride "raw.Foo = { ... }"
Alan T. DeKok [Mon, 3 Mar 2025 01:23:49 +0000 (20:23 -0500)] 
over-ride "raw.Foo = { ... }"

use the original data type, and not a hard-coded TLV

the parser can't tell the difference between "raw.1 = {...}"
and "raw.Foo = {...}", so we just fix the data type after the
fact.

5 months agomake diff output easier to read
Alan T. DeKok [Mon, 3 Mar 2025 00:10:11 +0000 (19:10 -0500)] 
make diff output easier to read

5 months agoremove wrapper wrapper functions
Alan T. DeKok [Sun, 2 Mar 2025 17:32:16 +0000 (12:32 -0500)] 
remove wrapper wrapper functions

5 months agosimplify sorting of sets
Alan T. DeKok [Sun, 2 Mar 2025 16:05:51 +0000 (11:05 -0500)] 
simplify sorting of sets

so that there's less "back and forth"

Also the number of children might not be the same as the
number of _encodeable_ children, especially if the set is a group,
and there are internal attributes in the group

As a result, we set the max to the number of possible children,
and then loop until we've encoded all of the children

5 months agosimplify sorting of sets
Alan T. DeKok [Sun, 2 Mar 2025 15:49:38 +0000 (10:49 -0500)] 
simplify sorting of sets

there's no need to use markers, pointers will do.

there's no need to track marker in encode_value(), as the set
code can do that

5 months agoencode_choice() is really encode all children
Alan T. DeKok [Sun, 2 Mar 2025 14:11:14 +0000 (09:11 -0500)] 
encode_choice() is really encode all children

so we call it from multiple places to reduce code duplication

5 months agono need to loop over the children
Alan T. DeKok [Sun, 2 Mar 2025 14:05:26 +0000 (09:05 -0500)] 
no need to loop over the children

now that we've fixed fr_pair_cursor_to_network()

5 months agojust encode everything which matches the cursor
Alan T. DeKok [Sun, 2 Mar 2025 14:02:44 +0000 (09:02 -0500)] 
just encode everything which matches the cursor

the iterator is responsible for doing the right thing.

The depth checks don't work with groups which have refs

5 months agomove default to der_attr_flags_t
Alan T. DeKok [Sat, 1 Mar 2025 17:48:43 +0000 (12:48 -0500)] 
move default to der_attr_flags_t

which means that the default value is in attr_flags

5 months agoallow 'class=private' and 'class=enterprise'
Alan T. DeKok [Sat, 1 Mar 2025 12:40:09 +0000 (07:40 -0500)] 
allow 'class=private' and 'class=enterprise'

5 months agoremove duplicate
Alan T. DeKok [Sat, 1 Mar 2025 13:12:10 +0000 (08:12 -0500)] 
remove duplicate

5 months agodon't hard-code CONTEXT class.
Alan T. DeKok [Sat, 1 Mar 2025 12:27:55 +0000 (07:27 -0500)] 
don't hard-code CONTEXT class.

which allows for PRIVATE and ENTERPRISE

5 months agoenforce locations where 'option' and 'optional' are used
Alan T. DeKok [Sat, 1 Mar 2025 12:15:17 +0000 (07:15 -0500)] 
enforce locations where 'option' and 'optional' are used

They can only be used in SEQUENCE and SET, and not in any other
type of DER or FreeRADIUS data type

5 months agonote that not all docs are up to date for v4
Alan T. DeKok [Sat, 1 Mar 2025 00:47:19 +0000 (19:47 -0500)] 
note that not all docs are up to date for v4

5 months agoRearrange debugging documentation
nolade [Fri, 28 Feb 2025 22:24:20 +0000 (17:24 -0500)] 
Rearrange debugging documentation

5 months agoclean up documentation.
nolade [Fri, 28 Feb 2025 21:42:13 +0000 (16:42 -0500)] 
clean up documentation.

Add new howto pages.

5 months agoAdd best practices document
nolade [Fri, 28 Feb 2025 21:39:36 +0000 (16:39 -0500)] 
Add best practices document

5 months agoOrganize virtual servers by protocol
Alan T. DeKok [Fri, 28 Feb 2025 17:59:53 +0000 (12:59 -0500)] 
Organize virtual servers by protocol

remove many virtual servers which were old, unused, and wrong

5 months agorearrange fr_der_decode_pair_dbuff
Alan T. DeKok [Fri, 28 Feb 2025 16:14:22 +0000 (11:14 -0500)] 
rearrange fr_der_decode_pair_dbuff

to do sanity checks before doing anything else, and to remove
duplicate code around creating default values.

5 months agoadd more options
Alan T. DeKok [Fri, 28 Feb 2025 17:31:04 +0000 (12:31 -0500)] 
add more options

5 months agoStrategy only applies if there is a build matrix
Nick Porter [Fri, 28 Feb 2025 16:15:29 +0000 (16:15 +0000)] 
Strategy only applies if there is a build matrix

5 months agoAdd scheduled call to Documenation CI action
Nick Porter [Fri, 28 Feb 2025 16:08:50 +0000 (16:08 +0000)] 
Add scheduled call to Documenation CI action

Since most commits to `master` are merges from developer's branches, the
job was never running in `master` and so docs were not getting
published.

5 months agoFully update parent client when connected dynamic clients are approved
Nick Porter [Fri, 28 Feb 2025 15:50:27 +0000 (15:50 +0000)] 
Fully update parent client when connected dynamic clients are approved

Without this, subsequent clones of the parent will be missing data.

5 months agohoist checks out of the hot path
Alan T. DeKok [Fri, 28 Feb 2025 12:25:49 +0000 (07:25 -0500)] 
hoist checks out of the hot path

and use consistent names

5 months agoTerminology updates and consistency
nolade [Fri, 28 Feb 2025 12:22:45 +0000 (07:22 -0500)] 
Terminology updates and consistency

5 months agoremove accidentally committed file
Alan T. DeKok [Fri, 28 Feb 2025 12:19:25 +0000 (07:19 -0500)] 
remove accidentally committed file

5 months agothere's no need to check the restriction types at run time
Alan T. DeKok [Fri, 28 Feb 2025 01:16:33 +0000 (20:16 -0500)] 
there's no need to check the restriction types at run time

either there's one value (is_sequence_of=foo).

or it's a CHOICE, and all of the children are numbered options.
In which case we don't care what the values are.  If they exist,
we will find them, or they won't exist, and we will decode them
as raw octets

5 months agomove DEFINE ...option=N to ATTRIBUTE ... N ...option
Alan T. DeKok [Fri, 28 Feb 2025 01:15:51 +0000 (20:15 -0500)] 
move DEFINE ...option=N to ATTRIBUTE ... N ...option

which is a little more consistent

5 months agoupdate the restriction flags in more cases
Alan T. DeKok [Fri, 28 Feb 2025 01:15:18 +0000 (20:15 -0500)] 
update the restriction flags in more cases

and correct how we set them.

5 months agohoist decode_oid_and_value() to its own function
Alan T. DeKok [Fri, 28 Feb 2025 00:47:26 +0000 (19:47 -0500)] 
hoist decode_oid_and_value() to its own function

which avoids the sequence / set decoder checking for the flag.

rename the is_pair flag to is_oid_and_value, which is clearer.
rename other functions to match

5 months agotypos
Alan T. DeKok [Thu, 27 Feb 2025 23:02:40 +0000 (18:02 -0500)] 
typos

5 months agouse fr_strerror_*_push() more consistently
Alan T. DeKok [Thu, 27 Feb 2025 22:21:03 +0000 (17:21 -0500)] 
use fr_strerror_*_push() more consistently

which helps to figure out just where the error is.

The DER data is _deeply_ nested.  If we just say

failed decoding boolean

then the poor user has no idea which boolean it is.  Giving a
little bit of extra context goes a long way to having someone
figure out where the error is.

5 months agohoist expected tag into the decode_hdr() function
Alan T. DeKok [Thu, 27 Feb 2025 22:04:50 +0000 (17:04 -0500)] 
hoist expected tag into the decode_hdr() function

5 months agorearrange / redo decode x509extensions functiono
Alan T. DeKok [Thu, 27 Feb 2025 21:45:18 +0000 (16:45 -0500)] 
rearrange / redo decode x509extensions functiono

more sanity checks, and less "back and forth" decoding with
markers

5 months agoclean up extension decoding
Alan T. DeKok [Thu, 27 Feb 2025 14:58:45 +0000 (09:58 -0500)] 
clean up extension decoding

5 months agohoist "set length" to before calling any decode function
Alan T. DeKok [Thu, 27 Feb 2025 16:10:19 +0000 (11:10 -0500)] 
hoist "set length" to before calling any decode function

5 months agoclean up OID decoding
Alan T. DeKok [Thu, 27 Feb 2025 14:52:50 +0000 (09:52 -0500)] 
clean up OID decoding

5 months agomove OID decoding to wrapper function
Alan T. DeKok [Thu, 27 Feb 2025 14:42:44 +0000 (09:42 -0500)] 
move OID decoding to wrapper function

to avoid conditions in the hot path

5 months agoadd flags->is_option
Alan T. DeKok [Thu, 27 Feb 2025 13:15:48 +0000 (08:15 -0500)] 
add flags->is_option

and clean up decoding of option vs tag.  Sometimes it might not
have done the right thing

5 months agoAdd fallthrough to LDAP tests
Nick Porter [Thu, 27 Feb 2025 13:51:04 +0000 (13:51 +0000)] 
Add fallthrough to LDAP tests

5 months agoAdd fallthrough options to sample LDAP module config
Nick Porter [Thu, 27 Feb 2025 13:49:46 +0000 (13:49 +0000)] 
Add fallthrough options to sample LDAP module config

5 months agoAdd fallthrough attributes to RADIUS and TACACS profile schemas
Nick Porter [Thu, 27 Feb 2025 12:20:07 +0000 (12:20 +0000)] 
Add fallthrough attributes to RADIUS and TACACS profile schemas

5 months agoCheck and fallthrough attributes are needed for autz profile processing
Nick Porter [Thu, 27 Feb 2025 12:18:38 +0000 (12:18 +0000)] 
Check and fallthrough attributes are needed for autz profile processing

5 months agoAdd fallthrough handling to LDAP profiles
Nick Porter [Thu, 27 Feb 2025 12:17:38 +0000 (12:17 +0000)] 
Add fallthrough handling to LDAP profiles

5 months agoFree condition results early
Nick Porter [Thu, 27 Feb 2025 12:14:52 +0000 (12:14 +0000)] 
Free condition results early

5 months agoAdd fallthrough_attr to LDAP query
Nick Porter [Wed, 26 Feb 2025 20:17:43 +0000 (20:17 +0000)] 
Add fallthrough_attr to LDAP query

5 months agoAdd profile fallthrough options to rlm_ldap
Nick Porter [Wed, 26 Feb 2025 20:14:10 +0000 (20:14 +0000)] 
Add profile fallthrough options to rlm_ldap

5 months agoadd encoder, decoder, and tests for combo-ip
Alan T. DeKok [Wed, 26 Feb 2025 19:33:43 +0000 (14:33 -0500)] 
add encoder, decoder, and tests for combo-ip

5 months agooptions have to have class Context
Alan T. DeKok [Wed, 26 Feb 2025 19:33:30 +0000 (14:33 -0500)] 
options have to have class Context

5 months agodon't print timeout
Alan T. DeKok [Wed, 26 Feb 2025 19:17:36 +0000 (14:17 -0500)] 
don't print timeout

5 months agoensure that sets are only TLVs
Alan T. DeKok [Wed, 26 Feb 2025 18:46:30 +0000 (13:46 -0500)] 
ensure that sets are only TLVs

nothing in the standard dictionaries uses SETs as groups.
They're groups only in the test dictionaries.  And there is no
encoding difference between SET of tlv and SET of group.

5 months agomore checks on attributes
Alan T. DeKok [Wed, 26 Feb 2025 16:18:22 +0000 (11:18 -0500)] 
more checks on attributes

disallow duplicates for choices and sequences of choices

enforce parent set of / sequence of

set restrictions in preparation for doing less of this at run-time