]> git.ipfire.org Git - thirdparty/kea.git/log
thirdparty/kea.git
8 years ago[4483] Parser files regenerated.
Tomek Mrugalski [Tue, 23 Aug 2016 11:18:07 +0000 (13:18 +0200)] 
[4483] Parser files regenerated.

8 years ago[4483] Review comments addressed
Tomek Mrugalski [Tue, 23 Aug 2016 11:17:38 +0000 (13:17 +0200)] 
[4483] Review comments addressed
 - Implemented new test for checking integer boundaries
 - checkTokenInteger documented
 - indentation fixed in parser.yy
 - integer check in lexer.ll extended from int to int64_t
 - a bug fixed in EvalContext::convertUint32
 - User's Guide now explicitly mentions network order

8 years ago[trac4483] Fix a couple more typos
Shawn Routhier [Mon, 22 Aug 2016 22:27:36 +0000 (15:27 -0700)] 
[trac4483] Fix a couple more typos

8 years ago[trac4483] Tidy up some typos and spacing
Shawn Routhier [Mon, 22 Aug 2016 04:45:21 +0000 (21:45 -0700)] 
[trac4483] Tidy up some typos and spacing

8 years ago[4483] Several examples corrected in the User's Guide.
Tomek Mrugalski [Fri, 19 Aug 2016 17:57:35 +0000 (19:57 +0200)] 
[4483] Several examples corrected in the User's Guide.

8 years ago[4483] Parser regenerated.
Tomek Mrugalski [Fri, 19 Aug 2016 17:49:37 +0000 (19:49 +0200)] 
[4483] Parser regenerated.

8 years ago[4483] Extra unit-tests added.
Tomek Mrugalski [Fri, 19 Aug 2016 17:49:20 +0000 (19:49 +0200)] 
[4483] Extra unit-tests added.

8 years ago[4483] User's Guide updated.
Tomek Mrugalski [Fri, 19 Aug 2016 17:48:51 +0000 (19:48 +0200)] 
[4483] User's Guide updated.

8 years ago[4483] Example configs added.
Tomek Mrugalski [Fri, 19 Aug 2016 17:38:18 +0000 (19:38 +0200)] 
[4483] Example configs added.

8 years ago[4483] Added pkt4.msgtype and pkt4.transid
Tomek Mrugalski [Fri, 19 Aug 2016 17:06:00 +0000 (19:06 +0200)] 
[4483] Added pkt4.msgtype and pkt4.transid

8 years ago[4483] Parser regenerated.
Tomek Mrugalski [Fri, 19 Aug 2016 16:37:27 +0000 (18:37 +0200)] 
[4483] Parser regenerated.

8 years ago[4483] Generic unit-tests for evaluating expressions written
Tomek Mrugalski [Fri, 19 Aug 2016 16:37:13 +0000 (18:37 +0200)] 
[4483] Generic unit-tests for evaluating expressions written

8 years ago[4483] Several existing instances converted to fromUint32
Tomek Mrugalski [Fri, 19 Aug 2016 15:21:52 +0000 (17:21 +0200)] 
[4483] Several existing instances converted to fromUint32

8 years ago[4483] Integers in expressions implemented.
Tomek Mrugalski [Fri, 19 Aug 2016 15:08:55 +0000 (17:08 +0200)] 
[4483] Integers in expressions implemented.

8 years ago[master] ChangeLog updated.
Tomek Mrugalski [Thu, 18 Aug 2016 21:41:52 +0000 (23:41 +0200)] 
[master] ChangeLog updated.

8 years ago[master] Merge branch 'trac4271' (vendor options support in classification)
Tomek Mrugalski [Thu, 18 Aug 2016 21:40:27 +0000 (23:40 +0200)] 
[master] Merge branch 'trac4271' (vendor options support in classification)

# Conflicts:
# src/lib/eval/lexer.cc
# src/lib/eval/lexer.ll
# src/lib/eval/location.hh
# src/lib/eval/parser.cc
# src/lib/eval/parser.h
# src/lib/eval/parser.yy
# src/lib/eval/position.hh
# src/lib/eval/stack.hh
# src/lib/eval/tests/context_unittest.cc
# src/lib/eval/tests/token_unittest.cc
# src/lib/eval/token.cc
# src/lib/eval/token.h

8 years ago[4271] spelling
Francis Dupont [Thu, 18 Aug 2016 17:41:08 +0000 (19:41 +0200)] 
[4271] spelling

8 years ago[4271] Fixed parser
Francis Dupont [Thu, 18 Aug 2016 17:33:29 +0000 (19:33 +0200)] 
[4271] Fixed parser

8 years ago[4271] Reindent (align actions)
Francis Dupont [Thu, 18 Aug 2016 17:10:39 +0000 (19:10 +0200)] 
[4271] Reindent (align actions)

8 years ago[4271] parser regenerated
Tomek Mrugalski [Thu, 18 Aug 2016 14:06:01 +0000 (16:06 +0200)] 
[4271] parser regenerated

8 years ago[4271] Changes after review
Tomek Mrugalski [Thu, 18 Aug 2016 14:05:43 +0000 (16:05 +0200)] 
[4271] Changes after review

 - User's Guide clearified couple things.
 - messages orded alphabetically
 - indentation increased in parser.yy
 - debugging message formats updated slightly ('1234' => 0x1234)
 - one new case in vendorClass4SpecificVendorData added
 - verbose_ flag in log_utils.h commented

8 years ago[4271] Mostly typo level clean up
Shawn Routhier [Wed, 17 Aug 2016 07:24:30 +0000 (00:24 -0700)] 
[4271] Mostly typo level clean up

8 years ago[master] Fixed merge error trac4551_base
Francis Dupont [Tue, 16 Aug 2016 15:29:47 +0000 (17:29 +0200)] 
[master] Fixed merge error

8 years ago[master] Updated git hash
Francis Dupont [Tue, 16 Aug 2016 15:10:08 +0000 (17:10 +0200)] 
[master] Updated git hash

8 years agomaster: regen eval/*.hh
Francis Dupont [Tue, 16 Aug 2016 15:08:59 +0000 (15:08 +0000)] 
master: regen eval/*.hh

8 years ago[master] Finished merge of trac4272a (meta-info in classification)
Francis Dupont [Tue, 16 Aug 2016 15:04:34 +0000 (17:04 +0200)] 
[master] Finished merge of trac4272a (meta-info in classification)

9 years ago[master] Added ChangeLog entry 1147 for #4533.
Stephen Morris [Thu, 11 Aug 2016 09:52:31 +0000 (10:52 +0100)] 
[master] Added ChangeLog entry 1147 for #4533.

9 years ago[4533] Fix up some typos in the comments
Shawn Routhier [Thu, 11 Aug 2016 05:58:33 +0000 (22:58 -0700)] 
[4533] Fix up some typos in the comments

9 years ago[4271] Minor doc update.
Tomek Mrugalski [Wed, 10 Aug 2016 17:06:56 +0000 (19:06 +0200)] 
[4271] Minor doc update.

9 years ago[4271] Limitations sections trimmed down
Tomek Mrugalski [Wed, 10 Aug 2016 17:01:41 +0000 (19:01 +0200)] 
[4271] Limitations sections trimmed down

9 years ago[4271] User's Guide updated.
Tomek Mrugalski [Wed, 10 Aug 2016 16:58:51 +0000 (18:58 +0200)] 
[4271] User's Guide updated.

9 years ago[4271] Logging checks added for TokenVendor and TokenVendorClass
Tomek Mrugalski [Wed, 10 Aug 2016 14:38:03 +0000 (16:38 +0200)] 
[4271] Logging checks added for TokenVendor and TokenVendorClass

9 years ago[4271] Messages are now more terse.
Tomek Mrugalski [Tue, 9 Aug 2016 14:36:48 +0000 (16:36 +0200)] 
[4271] Messages are now more terse.

9 years ago[4271] Debug in LogContnetTest class implemented.
Tomek Mrugalski [Tue, 9 Aug 2016 14:36:04 +0000 (16:36 +0200)] 
[4271] Debug in LogContnetTest class implemented.

9 years ago[4271] Debug logging added.
Tomek Mrugalski [Tue, 9 Aug 2016 14:08:11 +0000 (16:08 +0200)] 
[4271] Debug logging added.

9 years ago[4271] Lexer files regenerated.
Tomek Mrugalski [Tue, 9 Aug 2016 13:37:42 +0000 (15:37 +0200)] 
[4271] Lexer files regenerated.

9 years ago[4271] Vendor and Vendor-class tokens implemented.
Tomek Mrugalski [Tue, 9 Aug 2016 13:36:46 +0000 (15:36 +0200)] 
[4271] Vendor and Vendor-class tokens implemented.

9 years agotrac4272a: regen lexer/parser
Francis Dupont [Mon, 8 Aug 2016 14:51:49 +0000 (14:51 +0000)] 
trac4272a: regen lexer/parser

9 years ago[4272a] Addressed comments
Francis Dupont [Mon, 8 Aug 2016 14:46:31 +0000 (16:46 +0200)] 
[4272a] Addressed comments

9 years ago[4533] -Werror must now be specifically enabled at configuration time
Stephen Morris [Mon, 8 Aug 2016 13:52:08 +0000 (14:52 +0100)] 
[4533] -Werror must now be specifically enabled at configuration time

Change the default so that the -Werror compiler flag is only enabled
if specifically requested at configure time.

9 years ago[4511] add commit number to change log
Shawn Routhier [Wed, 3 Aug 2016 20:04:05 +0000 (13:04 -0700)] 
[4511] add commit number to change log

9 years ago[trac4511] Add description of the forensic log hooks configuration to admin guide
Shawn Routhier [Wed, 3 Aug 2016 19:58:27 +0000 (12:58 -0700)] 
[trac4511] Add description of the forensic log hooks configuration to admin guide

9 years ago[trac4511] Update per review comments
Shawn Routhier [Wed, 3 Aug 2016 19:32:14 +0000 (12:32 -0700)] 
[trac4511] Update per review comments

9 years ago[trac4511] Add description of the legal log hooks configuration and use
Shawn Routhier [Mon, 1 Aug 2016 05:21:56 +0000 (22:21 -0700)] 
[trac4511] Add description of the legal log hooks configuration and use

9 years ago[master] Added ChangeLog entry 1145 for #4277.
Thomas Markwalder [Tue, 26 Jul 2016 13:07:57 +0000 (09:07 -0400)] 
[master] Added ChangeLog entry 1145 for #4277.

9 years ago[master] Addes support for Host Reservations to PostgreSQL backend
Thomas Markwalder [Tue, 26 Jul 2016 12:03:11 +0000 (08:03 -0400)] 
[master] Addes support for Host Reservations to PostgreSQL backend

    Merge branch 'trac4277'

9 years ago[4277] Addressed review comments
Thomas Markwalder [Tue, 26 Jul 2016 12:01:09 +0000 (08:01 -0400)] 
[4277] Addressed review comments

src/lib/dhcpsrv/pgsql_host_data_source.h
    - added comment about v6 Duplicate constraint when added host reservations

9 years ago[master] Added ChangeLog entry for pull request #23.
Marcin Siodelski [Tue, 26 Jul 2016 04:24:38 +0000 (06:24 +0200)] 
[master] Added ChangeLog entry for pull request #23.

9 years ago[master] Updated AUTHORS file with author of pull request #23.
Marcin Siodelski [Tue, 26 Jul 2016 04:22:22 +0000 (06:22 +0200)] 
[master] Updated AUTHORS file with author of pull request #23.

9 years ago[github23] Corrected setting port number for DHCPv4 server.
Marcin Siodelski [Mon, 25 Jul 2016 17:35:12 +0000 (19:35 +0200)] 
[github23] Corrected setting port number for DHCPv4 server.

For the DHCPINFORM case set destination port 68 if:
- direct message sent without ciaddr,
- ciaddr present

Also updated unit test to verify port number for the directly
sent DHCPINFORM without ciaddr.

9 years ago[github23] Select client port for DHCPINFORM message.
Michal Humpula [Mon, 13 Jun 2016 15:50:04 +0000 (17:50 +0200)] 
[github23] Select client port for DHCPINFORM message.

9 years ago[4277] Added several @todos and fixed formatting.
Tomek Mrugalski [Mon, 25 Jul 2016 18:04:20 +0000 (20:04 +0200)] 
[4277] Added several @todos and fixed formatting.

9 years ago[master] Updated git tag
Francis Dupont [Fri, 15 Jul 2016 12:54:35 +0000 (14:54 +0200)] 
[master] Updated git tag

9 years ago[master] Finished merge of trac4273 (DHCP4o6 user doc)
Francis Dupont [Fri, 15 Jul 2016 12:53:38 +0000 (14:53 +0200)] 
[master] Finished merge of trac4273 (DHCP4o6 user doc)

9 years ago[4273] Italic and indent
Francis Dupont [Fri, 15 Jul 2016 12:48:33 +0000 (14:48 +0200)] 
[4273] Italic and indent

9 years ago[4277] Fixed tagged_statements name collision
Thomas Markwalder [Thu, 14 Jul 2016 20:35:12 +0000 (16:35 -0400)] 
[4277] Fixed tagged_statements name collision

Wrapped declaration of tagged_statements[] in pgsql_host_data_source.cc
and mysql_host_data_source.cc in anonymous namespace.  They collide
otherwise.

9 years ago[4277] Added PostgreSQL HR Managment section to developer's guide
Thomas Markwalder [Thu, 14 Jul 2016 13:09:03 +0000 (09:09 -0400)] 
[4277] Added PostgreSQL HR Managment section to developer's guide

src/lib/dhcprsrv/images/pgsql_host_data_source.svg
    - New class diagram for PgSqlHostDataSource

doc/Doxyfile
    - Added src/lib/dhcprsrv/images to IMAGE_PATH

src/lib/dhcpsrv/Makefile.am
    - Added images/pgsql_host_data_source.svg to EXTRA_DIST

src/lib/dhcpsrv/libdhcpsrv.dox
    - Added subsection postgreSQLHostMgr

src/lib/dhcpsrv/pgsql_connection.h
src/lib/dhcpsrv/pgsql_exchange.h
    - Minor cleanup

9 years ago[4277] Addressed bulk of review comments
Thomas Markwalder [Thu, 14 Jul 2016 11:34:06 +0000 (07:34 -0400)] 
[4277] Addressed bulk of review comments

src/lib/dhcpsrv/tests/pgsql_exchange_unittest.cc
    - Added PgSqlBasicsTest test fixture class and tests which exercise all of
    the PostgreSQL data types we currently use with round-trip database writes
    and reads

src/lib/dhcpsrv/pgsql_connection.cc
src/lib/dhcpsrv/pgsql_connection.h
    - Moved PgSqlResult function impls from .h
    - Added exception safe implementation of getColumnLabel() to PgSqlResult

src/lib/dhcpsrv/pgsql_exchange.cc
src/lib/dhcpsrv/pgsql_exchange.h
    - PsqlBindArray::add() variants which accept raw pointers now throw
    if the pointer is NULL
    - PgSqlExchange::getColumnLabel() is now a wrapper around PgSqlResult method

src/lib/dhcpsrv/pgsql_host_data_source.h
src/lib/dhcpsrv/pgsql_host_data_source.cc
     - Commentary clean up

src/lib/dhcpsrv/pgsql_lease_mgr.cc
     - Commentary clean up

9 years ago[master] Add git tag for change log 1142
Shawn Routhier [Wed, 13 Jul 2016 19:22:17 +0000 (12:22 -0700)] 
[master] Add git tag for change log 1142

9 years ago[master] Uncomment the example column from some rows in the list of classifciation...
Shawn Routhier [Wed, 13 Jul 2016 19:20:50 +0000 (12:20 -0700)] 
[master] Uncomment the example column from some rows in the list of classifciation values

9 years ago[trac4273] Minor typos in port description
Shawn Routhier [Mon, 11 Jul 2016 19:59:19 +0000 (12:59 -0700)] 
[trac4273] Minor typos in port description

9 years ago[4273] Addressed comments
Francis Dupont [Sat, 9 Jul 2016 09:08:30 +0000 (11:08 +0200)] 
[4273] Addressed comments

9 years ago[master] Merged trac4531 (test -> expr for <)
Francis Dupont [Sat, 9 Jul 2016 07:51:33 +0000 (09:51 +0200)] 
[master] Merged trac4531 (test -> expr for <)

9 years ago[4531] Patrick -> Patrik
Francis Dupont [Sat, 9 Jul 2016 07:47:17 +0000 (09:47 +0200)] 
[4531] Patrick -> Patrik

9 years ago[4531] Updated AUTHORS
Francis Dupont [Sat, 9 Jul 2016 07:45:46 +0000 (09:45 +0200)] 
[4531] Updated AUTHORS

9 years ago[master] Added ChangeLog entry for #4497.
Marcin Siodelski [Fri, 8 Jul 2016 21:01:52 +0000 (23:01 +0200)] 
[master] Added ChangeLog entry for #4497.

9 years ago[master] Merge branch 'trac4497_rebase'
Marcin Siodelski [Fri, 8 Jul 2016 20:34:59 +0000 (22:34 +0200)] 
[master] Merge branch 'trac4497_rebase'

9 years ago[4497] Fixed inefficient setting of the Pkt4o6 flag.
Marcin Siodelski [Fri, 8 Jul 2016 20:16:22 +0000 (22:16 +0200)] 
[4497] Fixed inefficient setting of the Pkt4o6 flag.

9 years ago[master] Fixed rights of non-executable regular files
Francis Dupont [Fri, 8 Jul 2016 18:38:15 +0000 (20:38 +0200)] 
[master] Fixed rights of non-executable regular files

9 years ago[master] Merged trac4245 (server unicast option doc)
Francis Dupont [Fri, 8 Jul 2016 17:17:59 +0000 (19:17 +0200)] 
[master] Merged trac4245 (server unicast option doc)

9 years ago[4497] spelling
Francis Dupont [Fri, 8 Jul 2016 17:04:23 +0000 (19:04 +0200)] 
[4497] spelling

9 years ago[4497] Enable retrieved options copying for remaining DHCPv6 hooks.
Marcin Siodelski [Fri, 8 Jul 2016 08:51:53 +0000 (10:51 +0200)] 
[4497] Enable retrieved options copying for remaining DHCPv6 hooks.

buffer6_send and lease6_release (PD case) hook points didn't set
copying retrieved options flag for a packet passed to callouts.

9 years ago[4497] Enable retrieved options copying for DHCPv4o6 case.
Marcin Siodelski [Fri, 8 Jul 2016 08:51:21 +0000 (10:51 +0200)] 
[4497] Enable retrieved options copying for DHCPv4o6 case.

9 years ago[4497] Extended Pkt4o6 to support setCopyRetrievedOptions.
Marcin Siodelski [Fri, 8 Jul 2016 07:47:46 +0000 (09:47 +0200)] 
[4497] Extended Pkt4o6 to support setCopyRetrievedOptions.

9 years ago[4497] Spelling, no \n at end of .gitignore, etc
Francis Dupont [Thu, 7 Jul 2016 16:28:16 +0000 (18:28 +0200)] 
[4497] Spelling, no \n at end of .gitignore, etc

9 years ago[4497] Spelling
Francis Dupont [Thu, 7 Jul 2016 12:58:50 +0000 (14:58 +0200)] 
[4497] Spelling

9 years ago[4497] Fixed a couple doxygen issues.
Marcin Siodelski [Wed, 6 Jul 2016 14:12:28 +0000 (16:12 +0200)] 
[4497] Fixed a couple doxygen issues.

9 years ago[4497] Udated doxygen about copying retrieved options in hooks.
Marcin Siodelski [Wed, 6 Jul 2016 14:06:36 +0000 (16:06 +0200)] 
[4497] Udated doxygen about copying retrieved options in hooks.

9 years ago[4497] Updated comments in DHCPv6 hooks unit tests.
Marcin Siodelski [Wed, 6 Jul 2016 11:02:56 +0000 (13:02 +0200)] 
[4497] Updated comments in DHCPv6 hooks unit tests.

9 years ago[4497] Updated copyright dates.
Marcin Siodelski [Wed, 6 Jul 2016 10:58:23 +0000 (12:58 +0200)] 
[4497] Updated copyright dates.

9 years ago[4497] Enable copying retrieved options in callouts.
Marcin Siodelski [Wed, 6 Jul 2016 10:28:49 +0000 (12:28 +0200)] 
[4497] Enable copying retrieved options in callouts.

9 years ago[4497] Added Pkt method checking if retrieved options are copied.
Marcin Siodelski [Mon, 4 Jul 2016 14:24:24 +0000 (16:24 +0200)] 
[4497] Added Pkt method checking if retrieved options are copied.

9 years ago[4497] Implemented copying options on retrieval from packet.
Marcin Siodelski [Thu, 30 Jun 2016 15:25:53 +0000 (17:25 +0200)] 
[4497] Implemented copying options on retrieval from packet.

9 years ago[4497] Documented tests for options copying.
Marcin Siodelski [Thu, 30 Jun 2016 13:02:25 +0000 (15:02 +0200)] 
[4497] Documented tests for options copying.

Also, extended unit test for OptionCustom.

9 years ago[4497] Removed spurious headers from the option unit tests.
Marcin Siodelski [Thu, 30 Jun 2016 11:34:21 +0000 (13:34 +0200)] 
[4497] Removed spurious headers from the option unit tests.

9 years ago[4497] Documented Option::clone() in all option classes.
Marcin Siodelski [Thu, 30 Jun 2016 11:32:32 +0000 (13:32 +0200)] 
[4497] Documented Option::clone() in all option classes.

Also udated copyright dates where applicable.

9 years ago[4497] Added .gitignores to non-recursively built directories.
Marcin Siodelski [Thu, 30 Jun 2016 10:31:22 +0000 (12:31 +0200)] 
[4497] Added .gitignores to non-recursively built directories.

9 years ago[4497] Implemented deep copy of DHCP options.
Marcin Siodelski [Fri, 24 Jun 2016 11:32:39 +0000 (13:32 +0200)] 
[4497] Implemented deep copy of DHCP options.

9 years ago[4497] Fix constness of methods in Option classes.
Marcin Siodelski [Fri, 24 Jun 2016 08:31:55 +0000 (10:31 +0200)] 
[4497] Fix constness of methods in Option classes.

9 years ago[4245] Addressed comments
Francis Dupont [Thu, 7 Jul 2016 11:18:57 +0000 (13:18 +0200)] 
[4245] Addressed comments

9 years ago[master] Finished merge of trac4523 (vendor options in Renew and Rebind)
Francis Dupont [Thu, 7 Jul 2016 10:59:26 +0000 (12:59 +0200)] 
[master] Finished merge of trac4523 (vendor options in Renew and Rebind)

9 years ago[4523] Fixed multiple nits for DOCSIS ORO tests.
Marcin Siodelski [Thu, 7 Jul 2016 09:53:37 +0000 (11:53 +0200)] 
[4523] Fixed multiple nits for DOCSIS ORO tests.

- Configuration 0 -> Configuration 7 (copy-paste error)
- Invalid indentation of the vendor sub options data config
- Remove redundant config-file option definition
- OptionVentor -> OptionVendor
- Rename requestDocsisORORenew test to docsisORO
- Copyright date updated in rebind test

9 years ago[master] Added template param in invocation of SpecializedTypeWrapper.
Marcin Siodelski [Thu, 7 Jul 2016 07:57:18 +0000 (09:57 +0200)] 
[master] Added template param in invocation of SpecializedTypeWrapper.

This was an obvious error and a trivial fix. Therefore it is being
committed on my discretion. It corrects build failures on some OSes
after merge of #4321.

9 years ago[master] Added ChangeLog entry for #4321.
Marcin Siodelski [Wed, 6 Jul 2016 18:38:18 +0000 (20:38 +0200)] 
[master] Added ChangeLog entry for #4321.

9 years ago[master] Merge branch 'trac4321'
Marcin Siodelski [Wed, 6 Jul 2016 18:19:02 +0000 (20:19 +0200)] 
[master] Merge branch 'trac4321'

9 years ago[4321] Corrected indentation and added description for a function.
Marcin Siodelski [Wed, 6 Jul 2016 15:48:13 +0000 (17:48 +0200)] 
[4321] Corrected indentation and added description for a function.

9 years ago[master] ChangeLog updated
Tomek Mrugalski [Wed, 6 Jul 2016 10:07:34 +0000 (12:07 +0200)] 
[master] ChangeLog updated

9 years ago[master]Merge branch 'trac4518' (host reservations doc update)
Tomek Mrugalski [Wed, 6 Jul 2016 10:03:55 +0000 (12:03 +0200)] 
[master]Merge branch 'trac4518' (host reservations doc update)

9 years ago[4518] One reservation example updated.
Tomek Mrugalski [Wed, 6 Jul 2016 10:03:00 +0000 (12:03 +0200)] 
[4518] One reservation example updated.

9 years ago[4518] Fix typo in custom options example
Shawn Routhier [Tue, 5 Jul 2016 21:04:42 +0000 (14:04 -0700)] 
[4518] Fix typo in custom options example