src/lib/dhcpsrv/client_class_def.cc
- updated comment on empty expressions in ctor,
- cleaned up whitespace
src/lib/dhcpsrv/parsers/client_class_def_parser.cc
- ExpressionParser::build() - integrated use of Eval
parsing in ExpressionParser
- cleaned up whitespace
src/lib/dhcpsrv/tests/client_class_def_parser_unittest.cc
Updated tests to verify that expressions are actually
parsed and function.
[4096] kea-dhcp6 now parses client class definitions list
src/bin/dhcp6/json_config_parser.cc
- createGlobalDhcp6ConfigParser() - creates ClientClassDefListParser
for "client-classes" element
- configureDhcp6Server() - runs the ClientClassDefListParser against
the "client-classes" element
src/bin/dhcp6/tests/config_parser_unittest.cc
Added new tests for parsing client class definitions:
TEST_F(Dhcp6ParserTest, clientClassDictionary)
TEST_F(Dhcp6ParserTest, invalidClientClassDictionary)
src/bin/dhcp6/dhcp6.spec
Added global "client-classes" element
[4096] kea-dhcp4 now parses client class definitions list
src/bin/dhcp4/json_config_parser.cc
- createGlobalDhcp4ConfigParser() - creates ClientClassDefListParser
for "client-classes" element
- configureDhcp4Server() - runs the ClientClassDefListParser against
the "client-classes" element
src/bin/dhcp4/tests/config_parser_unittest.cc
Added new tests for parsing client class definitions:
TEST_F(Dhcp4ParserTest, clientClassDictionary)
TEST_F(Dhcp4ParserTest, invalidClientClassDictionary)
src/bin/dhcp4/dhcp4.spec
Added global "client-classes" element
src/lib/dhcpsrv/parsers/client_class_def_parser.cc
ClientClassDefListParser::commit() - pushes the newly built local
dictionary to CfgMgr staging
src/lib/dhcpsrv/srv_config.h
src/lib/dhcpsrv/srv_config.cc
Added client class dictionary member to SrvConfig
src/lib/dhcpsrv/tests/client_class_def_parser_unittest.cc
TEST_F(ClientClassDefListParserTest, simpleValidList) - now
verifies that ClientClassDefListParser::commit() pushes its
local dictionary to CfgMgr staging.
src/lib/dhcpsrv/tests/srv_config_unittest.cc
Added support to test new client class dictionary member
[4096] ClientClassDef now stores CfgOption not OptionCollection
The initial choice for storing options as an OptionCollection
in the ClientClassDef was incorrect. They are now stored within
a CfgOption which is symmetrical with how they are stored globally
and in subnets.
doc/guide/admin.xml
src/lib/dhcpsrv/dhcpsrv_messages.mes
src/lib/dhcpsrv/lease_file_loader.h
minor clean up, typos
src/lib/dhcpsrv/tests/csv_lease_file4_unittest.cc
src/lib/dhcpsrv/tests/csv_lease_file6_unittest.cc
removed unnecessary use of scoped_ptr
src/lib/util/csv_file.cc
CSVRow::trim() - replaced use of std::vector<>::erase with resise
src/lib/util/versioned_csv_file.h
src/lib/util/versioned_csv_file.cc
VersionedCSVFile::next() - reorganized to use input_schema_state_
VersionedCSVFile::columnCountError() - new convenience method
minor cleanups
[4095] Implemented new classes for storing client class definitions
src/lib/dhcpsrv/client_class_def.cc
src/lib/dhcpsrv/client_class_def.h
src/lib/dhcpsrv/tests/client_class_def_unittest.cc
New files that define client class storage classes and tests
src/lib/dhcp/classify.h
Amended commentary to reflect how these classes are now being used.
[3601] Addressed review comments, added ability to downgrade
Several minor cleanup items based on review comments. Implemented
support for downgrading files from newer schema versions:
doc/guide/admin.xml
amended text on upgrading memfile to discuss downgrading
src/lib/dhcpsrv/dhcpsrv_messages.mes
src/lib/dhcpsrv/lease_file_loader.h
revamped log messages to accomodate downgrading
src/lib/dhcpsrv/memfile_lease_mgr.cc
src/lib/dhcpsrv/memfile_lease_mgr.h
added commentary to MemfileLeaseMgr ctor
automatic conversion logic accomdates both upgrading and downgrading
src/lib/dhcpsrv/tests/csv_lease_file4_unittest.cc
src/lib/dhcpsrv/tests/csv_lease_file6_unittest.cc
replaced tooManyHeaderColumns test with downGrade test
src/lib/util/tests/csv_file_unittest.cc
added CSVRow.trim test
src/lib/util/tests/versioned_csv_file_unittest.cc
added VersionedCSVFileTest.currentSchemaTest test
replaced tooManyHeaderColumns test with downGrading test
revamped tests to check getInputSchemaState() and needsConversion()
src/lib/util/versioned_csv_file.h
Updated commentary to describe downgrade support
next(CSVRow& row) - now supports downgrading rows
validateHeder() - now throws if called when no schema has been defined,
and supports downgrading rows
Stephen Morris [Mon, 9 Nov 2015 12:41:52 +0000 (12:41 +0000)]
[3259] Changes after review
1. Updated Kea guide to note that removing the hooks-libraries
configuration element does not always have the expected effect.
2. Moved some documentation from the dhcp_parsers.cc file to the .h file.
3. Expanded checking of the contents of the hooks-libraries configuration
element.