]> git.ipfire.org Git - thirdparty/pdns.git/log
thirdparty/pdns.git
4 years agodnsdist: Prevent a crash with DynBPF objects in client mode 10162/head
Remi Gacogne [Wed, 17 Feb 2021 09:38:58 +0000 (10:38 +0100)] 
dnsdist: Prevent a crash with DynBPF objects in client mode

(cherry picked from commit 22189743415af130b0e32a5a13aca1a26f800ead)

4 years agodnsdist: Fix EDNS in ServFail generated when no server is available
Remi Gacogne [Tue, 26 Jan 2021 11:53:59 +0000 (12:53 +0100)] 
dnsdist: Fix EDNS in ServFail generated when no server is available

(cherry picked from commit c8a94fb04d65cea7927b96a579c5c947f967a4ff)

4 years agodnsdist: Fix a hang when removing a server with more than one socket
Remi Gacogne [Thu, 24 Dec 2020 10:38:26 +0000 (11:38 +0100)] 
dnsdist: Fix a hang when removing a server with more than one socket

There was a lock starvation issue when removing a server with more
than one socket in use (`sockets` greater than 1 on the corresponding
`newServer` directive), because the mutex protecting the sockets array
would never be released long enough by the responder thread to allow
the thread stopping the server to acquire it.
This commit fixes that by marking the server as stopped right away,
before acquiring the lock, and also making sure that the responder
thread is woken up regularly (every second, even without any query
to process) and that it checks whether the server has been stopped
just after that.

The issue was introduced in be55a20ce9bb7140071279d70bcb460f1f2b7b7d,
and backported to 1.5.1 in f0d48318cce0dd80ae73c529362bdb2921d8c5c9.

(cherry picked from commit 0ac246e2e848bf244506b7d6a7031fb7d0de335b)

4 years agoFix the DNSName move assignement operator
Remi Gacogne [Thu, 19 Nov 2020 09:53:06 +0000 (10:53 +0100)] 
Fix the DNSName move assignement operator

A misplaced 'const' prevented it from being called, making every
move of a DNSName into a full copy.
Introduced in d720eb8add5ebda11867e8b404125e0b68ed2911.

(cherry picked from commit 8d1bb300460d5cc97b4599ea8eddeb7b6d35decf)

4 years agofix typo #9728
appliedprivacy [Sat, 14 Nov 2020 17:28:44 +0000 (17:28 +0000)] 
fix typo #9728

(cherry picked from commit 515b8bb7fb1c8ca8b4c47a35d70d63e2febf8a91)

4 years agodnsdist make: two fixes
Peter van Dijk [Fri, 2 Oct 2020 19:26:50 +0000 (21:26 +0200)] 
dnsdist make: two fixes

* make sure dnsdist-lua-ffi-interface.inc is built before dnsdist-lua-ffi.o
* cleaner output while building that .inc

by Pieter Lexis

(cherry picked from commit 71411593536c64f4bbfc5e1e3982232f80af830a)

4 years agoMerge pull request #9922 from rgacogne/ddist15-sni-resumption
Remi Gacogne [Mon, 11 Jan 2021 13:57:45 +0000 (14:57 +0100)] 
Merge pull request #9922 from rgacogne/ddist15-sni-resumption

dnsdist-1.5.x: Fix SNI on resumed sessions by acknowledging the name sent by the client

4 years agodnsdist: Travis' Python 2 does not handle TLS sessions at all 9922/head
Remi Gacogne [Mon, 11 Jan 2021 12:59:03 +0000 (13:59 +0100)] 
dnsdist: Travis' Python 2 does not handle TLS sessions at all

4 years agodnsdist: Travis' Python 2 does not have ssl.session_resumed
Remi Gacogne [Mon, 11 Jan 2021 09:08:49 +0000 (10:08 +0100)] 
dnsdist: Travis' Python 2 does not have ssl.session_resumed

4 years agodnsdist: Re-order hostname check directives, Python 2's ssl cares
Remi Gacogne [Fri, 8 Jan 2021 09:49:06 +0000 (10:49 +0100)] 
dnsdist: Re-order hostname check directives, Python 2's ssl cares

4 years agodnsdist: Add a unit test for SNI routing after session resumption
Remi Gacogne [Thu, 7 Jan 2021 16:41:00 +0000 (17:41 +0100)] 
dnsdist: Add a unit test for SNI routing after session resumption

(cherry picked from commit 5f4156bec07615ab15994bc44c30a1df39d4f1f6)

4 years agodnsdist: Fix SNI on resumed sessions by acknowledging the name sent by the client
Remi Gacogne [Thu, 7 Jan 2021 15:41:32 +0000 (16:41 +0100)] 
dnsdist: Fix SNI on resumed sessions by acknowledging the name sent by the client

Otherwise `SSL_get_servername()` only returns true when the session
has been freshly established, and will return `nullptr` when it is
resumed.

(cherry picked from commit 767a9d3a727a4a3b4073f01fab4b2c1d7c55d73e)

4 years agoMerge pull request #9717 from rgacogne/ddist15-fix-ebpf-long-names
Remi Gacogne [Fri, 13 Nov 2020 11:23:50 +0000 (12:23 +0100)] 
Merge pull request #9717 from rgacogne/ddist15-fix-ebpf-long-names

dnsdist-1.5.x: Fix eBPF filtering of long qnames

4 years agodnsdist: Fix eBPF filtering of long qnames 9717/head
Remi Gacogne [Mon, 9 Nov 2020 13:46:08 +0000 (14:46 +0100)] 
dnsdist: Fix eBPF filtering of long qnames

This commit switches to the use of eBPF positive offsets to access
the content of the transport and application layers, since using
negative offsets (needed to access the other layers) led to issues
with long qnames.
This is cleaner anyway :-)

(cherry picked from commit abbc72876eabc7a1745f50e7a9ff4c41b4bbef62)

4 years agoMerge pull request #9555 from rgacogne/ddist15-edns-negative-additional-soa dnsdist-1.5.1
Remi Gacogne [Wed, 30 Sep 2020 07:17:32 +0000 (09:17 +0200)] 
Merge pull request #9555 from rgacogne/ddist15-edns-negative-additional-soa

dnsdist-1.5.x: Only add EDNS on negative answers if the query had EDNS

4 years agodnsdist: Update regression tests for dnspython 2.0.0 9555/head
Remi Gacogne [Tue, 29 Sep 2020 10:43:43 +0000 (12:43 +0200)] 
dnsdist: Update regression tests for dnspython 2.0.0

(cherry picked from commit 6e1f856ff8e7f2018ef53cdc1bb5364854128d58)

4 years agodnsdist: Fix Cookie and ECS implementations for dnspython 2.0.0
Remi Gacogne [Tue, 29 Sep 2020 10:41:58 +0000 (12:41 +0200)] 
dnsdist: Fix Cookie and ECS implementations for dnspython 2.0.0

(cherry picked from commit a41603bfb402211c7ae131419d13f5dadbd13df9)

4 years agodnsdist: Only add EDNS on negative answers if the query had EDNS
Remi Gacogne [Tue, 29 Sep 2020 10:40:31 +0000 (12:40 +0200)] 
dnsdist: Only add EDNS on negative answers if the query had EDNS

(cherry picked from commit 2f67e0d445a55e675278f02a68e5f453f9a1f015)

4 years agoMerge pull request #9542 from rgacogne/ddist15-fix-parse-edns-options
Remi Gacogne [Mon, 28 Sep 2020 13:08:17 +0000 (15:08 +0200)] 
Merge pull request #9542 from rgacogne/ddist15-fix-parse-edns-options

dnsdist-1.5.x: Fix getEDNSOptions() for {AN,NS}COUNT != 0 and ARCOUNT = 0

4 years agoMerge pull request #9540 from rgacogne/ddist15-clear-console-history
Remi Gacogne [Mon, 28 Sep 2020 13:08:08 +0000 (15:08 +0200)] 
Merge pull request #9540 from rgacogne/ddist15-clear-console-history

dnsdist-1.5.x: Add the 'clearConsoleHistory' command

4 years agoMerge pull request #9541 from rgacogne/ddist15-stop-backend-thread-on-removal
Remi Gacogne [Mon, 28 Sep 2020 12:32:15 +0000 (14:32 +0200)] 
Merge pull request #9541 from rgacogne/ddist15-stop-backend-thread-on-removal

dnsdist-1.5.x: Stop the related responder thread when a backend is removed

4 years agoMerge pull request #9543 from rgacogne/ddist15-fix-building-llvm-11
Remi Gacogne [Mon, 28 Sep 2020 12:31:48 +0000 (14:31 +0200)] 
Merge pull request #9543 from rgacogne/ddist15-fix-building-llvm-11

dnsdist-1.5.x: Fix building with LLVM11

4 years agodnsdist: Dcocument the new 'clearConsoleHistory()' command 9540/head
Remi Gacogne [Tue, 25 Aug 2020 08:47:25 +0000 (10:47 +0200)] 
dnsdist: Dcocument the new 'clearConsoleHistory()' command

(cherry picked from commit 7e9f283759afc3afaa0a3945001fdff379e6efee)

4 years agodnsdist: Add the 'clearConsoleHistory' command
Remi Gacogne [Mon, 10 Aug 2020 16:16:17 +0000 (18:16 +0200)] 
dnsdist: Add the 'clearConsoleHistory' command

It removes the history items and delta() data from memory.

(cherry picked from commit 87e6359691e1bca47123510eb1da7755178096bc)

4 years agodnsdist: Stop the related responder thread when a backend is removed 9541/head
Remi Gacogne [Mon, 10 Aug 2020 13:51:18 +0000 (15:51 +0200)] 
dnsdist: Stop the related responder thread when a backend is removed

(cherry picked from commit be55a20ce9bb7140071279d70bcb460f1f2b7b7d)

4 years agodnsdist: Fix getEDNSOptions() for {AN,NS}COUNT != 0 and ARCOUNT = 0 9542/head
Remi Gacogne [Wed, 23 Sep 2020 08:02:15 +0000 (10:02 +0200)] 
dnsdist: Fix getEDNSOptions() for {AN,NS}COUNT != 0 and ARCOUNT = 0

Since 1.5.0, calling getEDNSOptions() from Lua would result in a
ServFail for queries that had no records in additional but at least
one record in either the answer or authority section, such as a
NOTIFY, because of a bug in parseEDNSOptions(). That last function
incorrectly called slowParseEDNSOptions() in that case, triggering
an exception to be raised because slowParseEDNSOptions() does not
expect to be called for a packet with no record in the additional
section.
parseEDNSOptions() now returns `false` for packets that have no
record in the additional section.

(cherry picked from commit 38af359d79bccc500deaa598957a1b0d1ce11fd4)

4 years agoFix building with LLVM11 9543/head
RvdE [Sun, 23 Aug 2020 22:26:21 +0000 (00:26 +0200)] 
Fix building with LLVM11

There's a typo on line 529, where it says "true", but the double quotes cause a type cast error on LLVM11.

dnsdist-console.cc:529:32: error: type 'const char [5]' cannot be narrowed to 'bool' in initializer list [-Wc++11-narrowing]
  { "SetNegativeAndSOAAction", "true", "nxd, zone, ttl, mname, rname, serial, refresh, retry, expire, minimum [, options]", "Turn a query into a NXDomain or NoData answer and sets a SOA record in the additional section" },
                               ^~~~~~
dnsdist-console.cc:529:32: note: insert an explicit cast to silence this issue
  { "SetNegativeAndSOAAction", "true", "nxd, zone, ttl, mname, rname, serial, refresh, retry, expire, minimum [, options]", "Turn a query into a NXDomain or NoData answer and sets a SOA record in the additional section" },
                               ^~~~~~
                               static_cast<bool>( )
1 error generated.

(cherry picked from commit e7c6996eb650d17372548899408160bb2d712511)

4 years agoMerge pull request #9539 from rgacogne/ddist15-disable-tests
Remi Gacogne [Mon, 28 Sep 2020 09:24:50 +0000 (11:24 +0200)] 
Merge pull request #9539 from rgacogne/ddist15-disable-tests

dnsdist-1.5.x: Disable non-dnsdist tests

4 years agoMerge pull request #9546 from rgacogne/ddist15-install-patch
Remi Gacogne [Mon, 28 Sep 2020 09:24:07 +0000 (11:24 +0200)] 
Merge pull request #9546 from rgacogne/ddist15-install-patch

dnsdist-1.5.x: Install 'patch', required to install py-lmdb

4 years agodnsdist: Install 'patch', required to install py-lmdb 9546/head
Remi Gacogne [Mon, 31 Aug 2020 10:04:42 +0000 (12:04 +0200)] 
dnsdist: Install 'patch', required to install py-lmdb

(cherry picked from commit c17a2921a6096535bbaac837ed2d2db369091e58)

4 years agodnsdist-1.5.x: Disable non-dnsdist tests 9539/head
Remi Gacogne [Mon, 28 Sep 2020 07:20:55 +0000 (09:20 +0200)] 
dnsdist-1.5.x: Disable non-dnsdist tests

5 years agoMerge pull request #9360 from rgacogne/ddist-prevent-backends-copy dnsdist-1.5.0
Remi Gacogne [Wed, 29 Jul 2020 12:16:39 +0000 (14:16 +0200)] 
Merge pull request #9360 from rgacogne/ddist-prevent-backends-copy

dnsdist: Prevent a copy of a pool's backends when selecting a server

5 years agodnsdist: Prevent a copy of a pool's backends when selecting a server 9360/head
Remi Gacogne [Wed, 29 Jul 2020 07:38:38 +0000 (09:38 +0200)] 
dnsdist: Prevent a copy of a pool's backends when selecting a server

5 years agoMerge pull request #9356 from rgacogne/ddist-check-cache-ptr
Remi Gacogne [Wed, 29 Jul 2020 06:58:36 +0000 (08:58 +0200)] 
Merge pull request #9356 from rgacogne/ddist-check-cache-ptr

dnsdist: Handle calling PacketCache methods on a nil object

5 years agoMerge pull request #9359 from Habbie/mysql-both-typo
Remi Gacogne [Wed, 29 Jul 2020 06:57:20 +0000 (08:57 +0200)] 
Merge pull request #9359 from Habbie/mysql-both-typo

auth tests gmysql2: fix env var name typo

5 years agoauth tests gmysql2: fix env var name typo 9359/head
Peter van Dijk [Tue, 28 Jul 2020 21:37:11 +0000 (23:37 +0200)] 
auth tests gmysql2: fix env var name typo

5 years agoMerge pull request #9355 from rgacogne/ddist-proxy-protocol-large
Remi Gacogne [Tue, 28 Jul 2020 12:45:11 +0000 (14:45 +0200)] 
Merge pull request #9355 from rgacogne/ddist-proxy-protocol-large

dnsdist: Improve reporting of possible overflow via large Proxy Protocol values

5 years agodnsdist: Handle calling PacketCache methods on a nil object 9356/head
Remi Gacogne [Tue, 28 Jul 2020 12:41:38 +0000 (14:41 +0200)] 
dnsdist: Handle calling PacketCache methods on a nil object

5 years agodnsdist: Improve reporting of possible overflow via large Proxy Protocol values 9355/head
Remi Gacogne [Tue, 28 Jul 2020 09:12:27 +0000 (11:12 +0200)] 
dnsdist: Improve reporting of possible overflow via large Proxy Protocol values

5 years agoMerge pull request #9354 from PowerDNS/dependabot/bundler/modules/remotebackend/json...
Remi Gacogne [Tue, 28 Jul 2020 09:05:27 +0000 (11:05 +0200)] 
Merge pull request #9354 from PowerDNS/dependabot/bundler/modules/remotebackend/json-2.3.0

build(deps): bump json from 1.8.5 to 2.3.0 in /modules/remotebackend

5 years agoMerge pull request #9353 from PowerDNS/dependabot/bundler/modules/remotebackend/regre...
Remi Gacogne [Tue, 28 Jul 2020 09:05:06 +0000 (11:05 +0200)] 
Merge pull request #9353 from PowerDNS/dependabot/bundler/modules/remotebackend/regression-tests/json-2.3.0

build(deps): bump json from 1.8.2 to 2.3.0 in /modules/remotebackend/regression-tests

5 years agoMerge pull request #9343 from cmouse/hostname-fix
Remi Gacogne [Tue, 28 Jul 2020 07:40:24 +0000 (09:40 +0200)] 
Merge pull request #9343 from cmouse/hostname-fix

misc.cc: Resize hostname to final size in getCarbonHostname()

5 years agoMerge pull request #9344 from rgacogne/ddist-fix-doh-sni
Remi Gacogne [Tue, 28 Jul 2020 07:37:21 +0000 (09:37 +0200)] 
Merge pull request #9344 from rgacogne/ddist-fix-doh-sni

dnsdist: Fix compilation with h2o_socket_get_ssl_server_name

5 years agoMerge pull request #9346 from omoerbeek/dnsdist-openbsd-clang-std
Remi Gacogne [Tue, 28 Jul 2020 07:37:05 +0000 (09:37 +0200)] 
Merge pull request #9346 from omoerbeek/dnsdist-openbsd-clang-std

dnsdist: Fix compilation on OpenBSD/amd64

5 years agobuild(deps): bump json from 1.8.5 to 2.3.0 in /modules/remotebackend 9354/head
dependabot[bot] [Tue, 28 Jul 2020 04:11:38 +0000 (04:11 +0000)] 
build(deps): bump json from 1.8.5 to 2.3.0 in /modules/remotebackend

Bumps [json](https://github.com/flori/json) from 1.8.5 to 2.3.0.
- [Release notes](https://github.com/flori/json/releases)
- [Changelog](https://github.com/flori/json/blob/master/CHANGES.md)
- [Commits](https://github.com/flori/json/compare/v1.8.5...v2.3.0)

Signed-off-by: dependabot[bot] <support@github.com>
5 years agobuild(deps): bump json in /modules/remotebackend/regression-tests 9353/head
dependabot[bot] [Tue, 28 Jul 2020 04:02:10 +0000 (04:02 +0000)] 
build(deps): bump json in /modules/remotebackend/regression-tests

Bumps [json](https://github.com/flori/json) from 1.8.2 to 2.3.0.
- [Release notes](https://github.com/flori/json/releases)
- [Changelog](https://github.com/flori/json/blob/master/CHANGES.md)
- [Commits](https://github.com/flori/json/compare/v1.8.2...v2.3.0)

Signed-off-by: dependabot[bot] <support@github.com>
5 years agotest-misc_hh: Add test for getCarbonHostname 9343/head
Aki Tuomi [Tue, 21 Jul 2020 19:04:56 +0000 (22:04 +0300)] 
test-misc_hh: Add test for getCarbonHostname

5 years agomisc.cc: Resize hostname to final size in getCarbonHostname()
Aki Tuomi [Sun, 19 Jul 2020 15:06:14 +0000 (18:06 +0300)] 
misc.cc: Resize hostname to final size in getCarbonHostname()

In 5c21b47fbc35ddcb8d939eb8541c6c3bad1080a8 we change how
hostname is allocated. We allocate getMaxHostNameSize for string,
then give the raw buffer for gethostname function, but forget to
resize the string into actual result length, causing the carbon
output to include trailing NUL bytes after hostname.

5 years agoFix compilation on OpenBSD/amd64 9346/head
Otto Moerbeek [Mon, 20 Jul 2020 07:56:15 +0000 (09:56 +0200)] 
Fix compilation on OpenBSD/amd64

The readline lib on OpenBSD redefines __attribute__ to empty if __STRICT_ANSI__...

5 years agoMerge pull request #9348 from omoerbeek/solaris-name-clashes
Otto Moerbeek [Mon, 20 Jul 2020 18:08:02 +0000 (20:08 +0200)] 
Merge pull request #9348 from omoerbeek/solaris-name-clashes

Avoid name clashes on Solaris derived systems.

5 years agoAvoid name clashes on Solaris derived systems. 9348/head
Otto Moerbeek [Mon, 20 Jul 2020 14:13:29 +0000 (16:13 +0200)] 
Avoid name clashes on Solaris derived systems.

Fixes #9279

5 years agoMerge pull request #9342 from omoerbeek/rec-prep-4.4.0-alpha2
Otto Moerbeek [Mon, 20 Jul 2020 09:25:27 +0000 (11:25 +0200)] 
Merge pull request #9342 from omoerbeek/rec-prep-4.4.0-alpha2

rec: prep for rec-4.4.0-alpha2

5 years agoPrep for rec 4.4.0-alpha2 9342/head
Otto Moerbeek [Fri, 17 Jul 2020 10:34:30 +0000 (12:34 +0200)] 
Prep for rec 4.4.0-alpha2

5 years agodnsdist: Fix compilation with h2o_socket_get_ssl_server_name 9344/head
Remi Gacogne [Sun, 19 Jul 2020 21:28:02 +0000 (23:28 +0200)] 
dnsdist: Fix compilation with h2o_socket_get_ssl_server_name

5 years agoCreate Ubuntu Focal Dockerfile for rec-43+.
aerique [Fri, 17 Jul 2020 09:00:24 +0000 (11:00 +0200)] 
Create Ubuntu Focal Dockerfile for rec-43+.

5 years agoOnly add `--nobest` for CentOS 8.
aerique [Fri, 17 Jul 2020 09:00:03 +0000 (11:00 +0200)] 
Only add `--nobest` for CentOS 8.

5 years agoMerge pull request #9338 from omoerbeek/rec-prep-20200717
Otto Moerbeek [Fri, 17 Jul 2020 08:24:49 +0000 (10:24 +0200)] 
Merge pull request #9338 from omoerbeek/rec-prep-20200717

rec: Prep for upcoming July 17th 2020 release.

5 years agoMerge pull request #9320 from ihsinme/patch-2 rec-4.4.0-alpha2
Remi Gacogne [Thu, 16 Jul 2020 08:45:48 +0000 (10:45 +0200)] 
Merge pull request #9320 from ihsinme/patch-2

Update proxy-protocol.cc

5 years agoMerge pull request #9336 from Habbie/auth-metrics-new-in-4.4
Remi Gacogne [Wed, 15 Jul 2020 07:37:33 +0000 (09:37 +0200)] 
Merge pull request #9336 from Habbie/auth-metrics-new-in-4.4

auth docs: note that /metrics is new in 4.4; closes #9325

5 years agoAdd tags and tidy. 9338/head
Otto Moerbeek [Wed, 15 Jul 2020 07:27:07 +0000 (09:27 +0200)] 
Add tags and tidy.

5 years agoMerge pull request #9308 from rgacogne/rec-check-zone-key-flag
Remi Gacogne [Wed, 15 Jul 2020 07:23:28 +0000 (09:23 +0200)] 
Merge pull request #9308 from rgacogne/rec-check-zone-key-flag

rec: Check that DNSKEYs have the zone flag set

5 years agoMerge pull request #9314 from zeha/no-tologstring
Otto Moerbeek [Wed, 15 Jul 2020 07:19:46 +0000 (09:19 +0200)] 
Merge pull request #9314 from zeha/no-tologstring

Remove redundant toLogString() calls

5 years agoMerge pull request #9339 from phonedph1/patch-22
Peter van Dijk [Tue, 14 Jul 2020 17:34:16 +0000 (19:34 +0200)] 
Merge pull request #9339 from phonedph1/patch-22

dnsdist: Update config.rst

5 years agoUpdate config.rst 9339/head
phonedph1 [Tue, 14 Jul 2020 17:25:56 +0000 (11:25 -0600)] 
Update config.rst

5 years agoPrep for upcoming July 17th 2020 release.
Otto Moerbeek [Tue, 14 Jul 2020 11:45:50 +0000 (13:45 +0200)] 
Prep for upcoming July 17th 2020 release.

5 years agoauth docs: note that /metrics is new in 4.4; closes #9325 9336/head
Peter van Dijk [Tue, 14 Jul 2020 08:56:11 +0000 (10:56 +0200)] 
auth docs: note that /metrics is new in 4.4; closes #9325

5 years agoMerge pull request #9315 from zeha/bind-zoneid
Peter van Dijk [Mon, 13 Jul 2020 19:10:40 +0000 (21:10 +0200)] 
Merge pull request #9315 from zeha/bind-zoneid

bindbackend: fix zoneId in log statement

5 years agoMerge pull request #9280 from zeha/domain-create
Peter van Dijk [Mon, 13 Jul 2020 15:41:59 +0000 (17:41 +0200)] 
Merge pull request #9280 from zeha/domain-create

auth: immediately fill account, kind, masters on zone create

5 years agorec: Check that DNSKEYs have the 'zone' flag set, 'revoked' one cleared 9308/head
Remi Gacogne [Wed, 8 Jul 2020 10:24:43 +0000 (12:24 +0200)] 
rec: Check that DNSKEYs have the 'zone' flag set, 'revoked' one cleared

5 years agorec: Check that DNSKEYs have the zone flag set
Remi Gacogne [Wed, 8 Jul 2020 09:04:47 +0000 (11:04 +0200)] 
rec: Check that DNSKEYs have the zone flag set

As required by rfc4034 Section 5.2.

5 years agoMerge pull request #9312 from rgacogne/rec-class-enum-validation-states
Remi Gacogne [Mon, 13 Jul 2020 13:49:33 +0000 (15:49 +0200)] 
Merge pull request #9312 from rgacogne/rec-class-enum-validation-states

rec: Stop cluttering the global namespace with validation states

5 years agoMerge pull request #9231 from omoerbeek/explicit-cxx-version
Otto Moerbeek [Mon, 13 Jul 2020 09:48:36 +0000 (11:48 +0200)] 
Merge pull request #9231 from omoerbeek/explicit-cxx-version

Use explicit flag for the specific version of c++ wer'e targeting.

5 years agoUpdate proxy-protocol.cc 9320/head
ihsinme [Fri, 10 Jul 2020 13:12:14 +0000 (16:12 +0300)] 
Update proxy-protocol.cc

get rid of integer overflow

5 years agoMerge pull request #9316 from zeha/dbnullptr
Remi Gacogne [Fri, 10 Jul 2020 07:36:12 +0000 (09:36 +0200)] 
Merge pull request #9316 from zeha/dbnullptr

auth: 0 as nullptr cleanup

5 years agoauth: 0 as nullptr cleanup 9316/head
Chris Hofstaedtler [Thu, 9 Jul 2020 19:59:28 +0000 (21:59 +0200)] 
auth: 0 as nullptr cleanup

5 years agobindbackend: fix zoneId in log statement 9315/head
Chris Hofstaedtler [Thu, 9 Jul 2020 19:32:43 +0000 (21:32 +0200)] 
bindbackend: fix zoneId in log statement

The existing message was confusing me because it showed invalid/not
initialized data.

5 years agoRemove redundant toLogString() calls 9314/head
Chris Hofstaedtler [Thu, 9 Jul 2020 19:12:16 +0000 (21:12 +0200)] 
Remove redundant toLogString() calls

Already handled by Logger.

5 years agorec: Stop cluttering the global namespace with validation states 9312/head
Remi Gacogne [Thu, 9 Jul 2020 11:52:11 +0000 (13:52 +0200)] 
rec: Stop cluttering the global namespace with validation states

Also rename the NODATA state to NODENIAL, as the existing name could
easily be confused with NXQTYPE.

5 years agoMerge pull request #9188 from rgacogne/rec-refuse-ds-from-child-zone
Remi Gacogne [Wed, 8 Jul 2020 12:10:56 +0000 (14:10 +0200)] 
Merge pull request #9188 from rgacogne/rec-refuse-ds-from-child-zone

rec: Refuse DS records received from child zones

5 years agoMerge pull request #9309 from rgacogne/rec-validate-cached-dnskeys-against-ds
Remi Gacogne [Wed, 8 Jul 2020 12:09:43 +0000 (14:09 +0200)] 
Merge pull request #9309 from rgacogne/rec-validate-cached-dnskeys-against-ds

rec: Validate cached DNSKEYs against the DSs, not the RRSIGs only

5 years agoMerge pull request #9297 from rgacogne/rec-no-cache-only-getdnskeys
Remi Gacogne [Wed, 8 Jul 2020 08:49:51 +0000 (10:49 +0200)] 
Merge pull request #9297 from rgacogne/rec-no-cache-only-getdnskeys

rec: Ignore cache-only for DNSKEYs retrieval

5 years agoMerge pull request #9298 from rgacogne/ddist-changelog-150-rc4
Remi Gacogne [Tue, 7 Jul 2020 14:06:59 +0000 (16:06 +0200)] 
Merge pull request #9298 from rgacogne/ddist-changelog-150-rc4

dnsdist: Update the ChangeLog and secpoll zone for 1.5.0-rc4

5 years agorec: Add a 'skip DS from child zone' unit test 9188/head
Remi Gacogne [Tue, 7 Jul 2020 12:22:59 +0000 (14:22 +0200)] 
rec: Add a 'skip DS from child zone' unit test

5 years agorec: Refuse DS records received from child zones
Remi Gacogne [Tue, 2 Jun 2020 15:19:42 +0000 (17:19 +0200)] 
rec: Refuse DS records received from child zones

5 years agodnsdist: Update the release date for dnsdist 1.5.0-rc4 9298/head
Remi Gacogne [Tue, 7 Jul 2020 08:13:01 +0000 (10:13 +0200)] 
dnsdist: Update the release date for dnsdist 1.5.0-rc4

5 years agorec: Ignore cache-only for DSs retrieval 9297/head
Remi Gacogne [Tue, 7 Jul 2020 07:56:41 +0000 (09:56 +0200)] 
rec: Ignore cache-only for DSs retrieval

When the DSs are needed for validation, the initial RD flag should
not prevent us from going to the network.

5 years agoMerge pull request #9303 from omoerbeek/rec-security-state-logging
Otto Moerbeek [Mon, 6 Jul 2020 18:05:57 +0000 (20:05 +0200)] 
Merge pull request #9303 from omoerbeek/rec-security-state-logging

rec: use new operator to print states

5 years agoMerge pull request #9301 from omoerbeek/rec-for-new-rpz
Otto Moerbeek [Mon, 6 Jul 2020 16:19:41 +0000 (18:19 +0200)] 
Merge pull request #9301 from omoerbeek/rec-for-new-rpz

rec: take initial refresh time  from loaded zone

5 years agoMerge pull request #9302 from omoerbeek/rec-openbsd-unsigned-warning
Otto Moerbeek [Mon, 6 Jul 2020 16:19:24 +0000 (18:19 +0200)] 
Merge pull request #9302 from omoerbeek/rec-openbsd-unsigned-warning

rec: Kill an signed vs unsigned warning on OpenBSD

5 years agoWhen no rpz cache is used and no refresh time is specified, use 9301/head
Otto Moerbeek [Mon, 6 Jul 2020 13:55:53 +0000 (15:55 +0200)] 
When no rpz cache is used and no refresh time is specified, use
the refresh time read on the initial load of the zone.

Should fix #9299.

5 years agoUse new operator to print states 9303/head
Otto Moerbeek [Mon, 6 Jul 2020 13:04:32 +0000 (15:04 +0200)] 
Use new operator to print states

5 years agorec: Validate cached DNSKEYs against the DSs, not the RRSIGs only 9309/head
Remi Gacogne [Mon, 6 Jul 2020 13:00:44 +0000 (15:00 +0200)] 
rec: Validate cached DNSKEYs against the DSs, not the RRSIGs only

DNSKEYs might be cached in a non-validated state ("Indeterminate")
when the DNSSEC mode is set to "Process" and the initial query did
not ask for validation.
We would then validate the DNSKEY records against the RRSIGs, like
for regular records, but not against the DSs.

5 years agoKill an signed vs unsigned warning on OpenBSD 9302/head
Otto Moerbeek [Mon, 6 Jul 2020 13:00:25 +0000 (15:00 +0200)] 
Kill an signed vs unsigned warning on OpenBSD

5 years agoMerge pull request #9290 from rgacogne/rec-refuse-qtype-0
Remi Gacogne [Mon, 6 Jul 2020 12:15:42 +0000 (14:15 +0200)] 
Merge pull request #9290 from rgacogne/rec-refuse-qtype-0

rec: Refuse QType 0 right away, based on rfc6895 section 3.1

5 years agoMerge pull request #9292 from rgacogne/rec-servfail-not-bogus-ds-dnskey-failure
Remi Gacogne [Mon, 6 Jul 2020 12:02:08 +0000 (14:02 +0200)] 
Merge pull request #9292 from rgacogne/rec-servfail-not-bogus-ds-dnskey-failure

rec: A ServFail while retrieving DS/DNSKEY records is just that

5 years agoMerge pull request #9295 from rgacogne/rec-storage-validation-types
Remi Gacogne [Mon, 6 Jul 2020 12:01:55 +0000 (14:01 +0200)] 
Merge pull request #9295 from rgacogne/rec-storage-validation-types

rec: Specify a storage type for validation states

5 years agoMerge pull request #9296 from rgacogne/rec-test-invalid-ds-denial
Remi Gacogne [Mon, 6 Jul 2020 12:01:10 +0000 (14:01 +0200)] 
Merge pull request #9296 from rgacogne/rec-test-invalid-ds-denial

rec: Fix invalid signatures in a test (DS signed by the child zone)

5 years agodnsdist: Update the ChangeLog and secpoll zone for 1.5.0-rc4
Remi Gacogne [Mon, 6 Jul 2020 09:06:59 +0000 (11:06 +0200)] 
dnsdist: Update the ChangeLog and secpoll zone for 1.5.0-rc4

5 years agorec: Specify a storage type for validation states 9295/head
Remi Gacogne [Fri, 3 Jul 2020 14:29:11 +0000 (16:29 +0200)] 
rec: Specify a storage type for validation states

5 years agorec: Fix invalid signatures in a test (DS signed by the child zone) 9296/head
Remi Gacogne [Fri, 3 Jul 2020 14:31:01 +0000 (16:31 +0200)] 
rec: Fix invalid signatures in a test (DS signed by the child zone)