Better wording in comment

Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
(cherry picked from commit 240460d77be35a6a1c1e6fa22364efe19dc3ee84)

Timout handling for ixfrs as a client.

One complicating factor is that this is shared code, but auth and
rec do not agree on the definiton of the timeout value: auth states
it is a maximum idle time, while rec state it is the total xfr time.
While both apporaches make sense and in the end we would like to
enforce both, we now go for a more simple solution that respects
auth or rec behaviour based on a flag.

(cherry picked from commit fee334ae0f5083d47f9adc207d5a1a6d36ebc2ac)

Merge pull request #12676 from mind04/auth47-catalog-members

auth-4.7.x: pdnsutil, implement list-member-zones

Merge pull request #12675 from mind04/auth47-lmdb-delete

auth-4.7.x backport lmdb delete fixes and tests

auth, lmdb, backport delete fixes

auth: lmdb, fix TSIG key removal

update completions

auth: pdnsutil, implement list-member-zones

Merge pull request #12616 from romeroalx/update-gh-actions-auth-to-4.7

Backport GH Actions updates from master to auth-4.7.x

build(deps): bump actions/setup-python from 2 to 4

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 4.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v2...v4)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

codeql workflow: set ubuntu mirror

build-and-test-all: add functionality to quickly switch ubuntu mirrors

Switch from set-output tot GITHUB_OUTPUT

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

build(deps): bump actions/upload-artifact from 1 to 3

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 1 to 3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v1...v3)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build(deps): bump actions/download-artifact from 2 to 3

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 3.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build(deps): bump actions/checkout from 2.3.4 to 3.1.0

Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 3.1.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2.3.4...v3.1.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build(deps): bump actions/cache from 2 to 3.0.11

Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3.0.11.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v2...v3.0.11)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Avoid Microsoft repo for ODBC. Step 1: codeql allow apt downgrades

Avoid Microsoft repo for ODBC. Step 1: allow apt downgrades

removed ldap and geoip-mmdb tests from circleci

gh actions: simplified collector job in build-and-test-all.yml

gh actions: added ldap and geoip-mmdb tests

GH actions: added auth odbc{sqlitle3, mssql} tests. Removed from CircleCI

Restrict permissions for GITHUB_TOKEN in our workflows

Added using https://github.com/step-security/secure-workflows
For more information see:
- https://github.com/ossf/scorecard/blob/d8fefc9b246db3600c777e9d60d441d7c386ce1d/docs/checks.md#token-permissions
- https://github.blog/changelog/2021-04-20-github-actions-control-permissions-for-github_token/

Merge pull request #12429 from Habbie/auth47-no-leak-hostlist

auth 4.7 minicurl: stop leaking hostlist memory

Merge pull request #12521 from Habbie/auth-4.7-ixfrdist-backports

auth-4.7.x: ixfrdist fixes and improvements

ixfrdist: Make sure that our metrics are properly initialized

Before C++20 std::atomic variables are not guaranteed to be initialized,
even though it looks like compilers are actually doing the initialization
even in C++17.
Reported by Coverity as CID 1504405.

(cherry picked from commit de9fbd402dc05263e8ddb2e6ffc09b5cf01bef1e)

use counters for things that count up over time

(cherry picked from commit b0069a9b63157e05e36f3fbf788b22a1c43e65df)

ixfrdist /metrics: add CPU and memory stats, note unit for uptime

(cherry picked from commit 4be206f56769495b1090f7e39d111560b77494fc)

ixfrdist /metrics: add FD usage

(cherry picked from commit 7bba0dae6d97b248e206e7dbda3813432a77b06d)

ixfrdist: Remove unused counters, simplify prometheus types handling

(cherry picked from commit 54f93cb8542aa46a9a9669fa623f5a6d8a6a5857)

ixfrdist /metrics: add unknown domain in-query counter

(cherry picked from commit ca0831d9a14c409c631b0ee49d6fdba6b2239b6f)

ixfrdist /metrics: quote label values; suffix counters with _total; remove full totals; add promtool test

(cherry picked from commit 7c05901b1d22693a29cced84f9c3b24f5dc4a0ec)

Merge pull request #12458 from Habbie/backport-12453-to-auth-4.7.x

auth-4.7: lock.hh: include <stdexcept>

lock.hh: include <stdexcept>

(cherry picked from commit d8b4ea24dc5dbe7c53c24bfffba24bcae7f58e02)

minicurl: stop leaking hostlist memory

Merge pull request #12299 from Habbie/backport-12282-to-auth-4.7.x

auth-4.7 lmdb: make outgoing notifications work

lmdb tests: actually use lmdb config

(cherry picked from commit f7d7e059f69b1330248ecd904c215630a77f038b)

auth lmdb: make outgoing notifications work

(cherry picked from commit bbd6102241d18d8bce551b5e19d0c315368913b9)

Merge pull request #12291 from Habbie/backport-12285-to-auth-4.7.x

auth-4.7 api: do not create SOA and NS records for consumer zones

Merge pull request #12296 from Habbie/backport-12257-to-auth-4.7.x

auth 4.7 API: slightly clearer message when a backend cannot create domains

Merge pull request #12294 from Habbie/backport-12132-to-auth-4.7.x

auth-4.7: take into account default urlcheck timeout is 2 seconds for Lua records tests

auth API: slightly clearer message when a backend cannot create domains

(cherry picked from commit b53ab9d6ef126f3be04160e36cbc381e27d85e79)

This test assumes the health check timeout is 1 second, while it is 2 seconds by default.

Adapt tests to take that into account, which resolves the occasional failure as tested locally.

(cherry picked from commit 2abc153929e22c4abad73f1eba9395e00f18febd)

auth: api, add create/delete consumer zone test

(cherry picked from commit 2f27a15fb72cdbef5c4f5af8f0d089722ee2253a)

auth: api, do not create SOA and NS records for consumer zones

(cherry picked from commit 1f1674ed5ed14af10a6ce38b9956ffdbef6fcee8)

Merge pull request #12273 from Habbie/backport-12087-to-auth-4.7.x

auth-4.7 API: fix newly created zone not rectified

Merge pull request #12272 from Habbie/backport-12269-to-auth-4.7.x

auth 4.7: fix invalid catalog zone sql query for gpgsqlbackend

API: Auth: honor rectify settings on create zone

(cherry picked from commit 168a76b38bf99c7661e72914c1e634e7fa9d0d0f)

API: Auth: updateDomainSettingsFromDocument: remove always disabled argument

(cherry picked from commit 002de4d7711955188c68726cc9584988b0c89a31)

API: tests: have sdig helper return sdig output

(cherry picked from commit 68fe406a32ec14c8dfc197f3aa60681aa8d7905f)

auth: fix invalid catalog zone sql query for gpgsqlbackend

(cherry picked from commit 5982663f592ece56441ba135ef3003efb2e1ffbe)

Merge pull request #12266 from Habbie/backport-12264-to-auth-4.7.x

auth 4.7 lmdb: implement alsoNotifies

auth lmdb: implement alsoNotifies, fixes #12256

(cherry picked from commit b0e178a7fae71dca241f08b4faa861130a150a76)

Merge pull request #12181 from Habbie/backport-12157-to-auth-4.7.x

auth-4.7.x: fix pdns_control list-zones

auth: fix pdns_control list-zones

(cherry picked from commit 0928e129fbd21c17a2f2e6e6066a58dad8102943)

Merge pull request #12143 from Habbie/backport-12130-to-auth-4.7.x

auth-4.7.x: fix xfr refresh check

Use > for frehsness test, to be consistent with the lmdb backend

(cherry picked from commit 76b236133aa2f3cb7d3fe43d755e73927a45b61a)

Remove (now) unneeded debug prints

(cherry picked from commit 204e3669b25b57b251f06aa1da12691ecff81227)

Fix freshness check for finding unfresh clients

(cherry picked from commit 496d8ebe583acd33ea5acb9538a2e3cd15a0c6d3)

Merge pull request #12124 from mind04/bp-pdns-no-reset

auth-4.7.x: catalog zones, avoid bulk zone reset while migrating to a catalog and fix a bug

auth: catalog zone, stop wasting options update queries

auth: catalog zones, avoid bulk zone reset while migrating to a catalog

Merge pull request #12110 from Habbie/backport-12109-to-auth-4.7.x

auth-4.7: include auth 4.7 schema upgrade files in tarballs and packages

include auth 4.7 schema upgrade files in tarballs and packages

(cherry picked from commit 20ad642888a52d9b0633f0143cd00b7af688f5d1)

Merge pull request #12098 from mind04/auth-4.7.x-axfr

auth-4.7: fix axfr for tinydns and pipe backend

auth: fix axfr for tinydns and pipe backend

Merge pull request #12085 from mind04/auth-4.7.x-metadata

auth-4.7.x: pdnsutil check-zone, skip metadata check for backends without g…

auth: pdnsutil check-zone, skip metadata check for backends without getAllDomainMetadata()

Merge pull request #12069 from Habbie/backport-12046-to-auth-4.7.x

auth-4.7: Fix compilation of the event ports multiplexer

Fix compilation of the event ports multiplexer

Thanks to Jonathan Perkin for the patch!

(cherry picked from commit 7ea87a63ab48e938bdb8b73ebfde1ac6bc71704f)

Merge pull request #12043 from Habbie/backport-11954-to-auth-4.7.x

auth 4.7 AXFR server: abort on chunk with TC set

auth AXFR server: abort on chunk with TC set

(cherry picked from commit 1f07a63f72cd410250b1208c56bda1d33f7d636e)

Merge pull request #12042 from Habbie/backport-11983-to-auth-4.7.x

auth-4.7.x: add keyroller

Merge pull request #12040 from mind04/auth-4.7.x-edit-zone

auth-4.7.x: pdnsutil edit-zone, detect capitalization changes in LUA, TXT a…

Update pdns/keyroller/pdnsapi/api.py

Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
(cherry picked from commit b959c1638a30625ea85be859bb50381645cedc7d)

keyroller first import

(cherry picked from commit 30150eab3853a999d99f498129c86f23fd548045)

auth: pdnsutil edit-zone, detect capitalization changes in LUA, TXT and SPF records

Merge pull request #12030 from Habbie/backport-11953-to-auth-4.7.x

auth-4.7: axfr-retriever: abort on chunk with TC set

Merge pull request #12029 from Habbie/backport-11971-to-auth-4.7.x

auth-4.7: clang14 has reached MacOS

axfr-retriever: abort on chunk with TC set

(cherry picked from commit 0923e5df06e10e7afb19dc5ce534b07450792ab1)

clang14 has reached MacOS

Also upstreamed: https://github.com/tsuna/boost.m4/pull/129

(cherry picked from commit c46730d9de5cb409c260e4d94cb4be3c75a643e5)

Merge pull request #11972 from Habbie/backport-11961-to-auth-4.7.x

auth-4.7.x docker: upgrade to bullseye

docker: upgrade to bullseye

(cherry picked from commit a0d3acff25a92627186ee43bead110aef416f59a)

Merge pull request #11934 from Habbie/auth47-compiler-warnings

auth-4.7.x: backport two compiler warning fixes

auth LUA: fix "braces around scalar initializer" warning

inspired by #6188

(cherry picked from commit d27a2d307e4a0dcf0671046910994a2bf3ba945e)

auth: fix gcc warning, no prevous declaration for ‘void carbonDumpThread()’

(cherry picked from commit 9edbd73fc06c2f784619402e26cd9a67bc7cf114)

Merge pull request #11930 from Habbie/backport-11929-to-auth-4.7.x

auth-4.7.x: LUA records: we only need one IsUpOracle checker thread

auth LUA records: we only need one IsUpOracle checker thread

(cherry picked from commit 37f625b0af0b5e818de97b83dd96709df118ad6b)

Merge pull request #11928 from Habbie/backport-11826-to-auth-4.7.x

auth-4.7.x: somewhat cleanup global symbols

Rename g_distributors to s_distributors

(cherry picked from commit 346872ff95155be9fa20764e709418393881a2dd)

Rename g_udpReceivers to s_udpReceivers

(cherry picked from commit fcab180dad765004e403f59c350ec002e1168351)

Rename g_DynListener to s_dynListener

(cherry picked from commit a270fbcb50335aaf1dd48e8754d513268633d1a8)

Rename s_starttime, s_programname

(cherry picked from commit c509c9fad48a04a9b23ebb783c01a5c7ec648147)

auth: rename dl to g_DynListener

(cherry picked from commit aa6051682015d107eabef8d0c7ba1ea2e264b7b8)

auth: rename TN to s_tcpNameserver and make static

(cherry picked from commit 6738003ecb7313fda1672a71c283f7c4f652d5af)

auth: rename N to s_udpNameserver and make static

(cherry picked from commit dd81fb3bc4e45a63eb0e230e4a1004e988db4fc0)

auth: remove unnecessary, duplicate extern defines

(cherry picked from commit 5d8d903eb6553f911f4484919dcf28929fd19f1c)

auth: make most startup functions static

(cherry picked from commit 8de023151800de71b262e1806addc9166530fc4b)

auth: make g_udpReceivers static

(cherry picked from commit bee7d177b2b6463b2f9348b2357dca08d52e28c2)