]> git.ipfire.org Git - thirdparty/pdns.git/log
thirdparty/pdns.git
2 weeks agorec: Prevent a crash in the ZoneToCache unit tests 15932/head
Remi Gacogne [Fri, 20 Jun 2025 11:23:01 +0000 (13:23 +0200)] 
rec: Prevent a crash in the ZoneToCache unit tests

Since 753ad2390bfbc90f6bc1b68f980ef4bcdc2cfddc ZoneToCache checks
whether a given zone has a recursive forward rule, so we need the
Domain map to be properly initialized in all tests, as they can be
executed in random order.

Fixes:
```
ThreadSanitizer:DEADLYSIGNAL
==35969==ERROR: ThreadSanitizer: SEGV on unknown address 0x000000000018 (pc 0x5568e9f8bb04 bp 0x4c00000000000 sp 0x7ffcc13b77f0 T35969)
==35969==The signal is caused by a READ memory access.
==35969==Hint: address points to the zero page.
    #0 std::_Hashtable<DNSName, std::pair<DNSName const, SyncRes::AuthDomain>, std::allocator<std::pair<DNSName const, SyncRes::AuthDomain> >, std::__detail::_Select1st, std::equal_to<DNSName>, std::hash<DNSName>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::empty() const /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/hashtable.h:653:23 (testrunner+0x47fb04)
    #1 std::unordered_map<DNSName, SyncRes::AuthDomain, std::hash<DNSName>, std::equal_to<DNSName>, std::allocator<std::pair<DNSName const, SyncRes::AuthDomain> > >::empty() const /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/unordered_map.h:306:21 (testrunner+0x47fb04)
    #2 SyncRes::getBestAuthZone(DNSName*) /__w/pdns/pdns/pdns/recursordist/pdns-recursor-0.0.0-git1/syncres.cc:2464:29 (testrunner+0x47fb04)
    #3 SyncRes::isRecursiveForward(DNSName const&) /__w/pdns/pdns/pdns/recursordist/pdns-recursor-0.0.0-git1/syncres.cc:1098:21 (testrunner+0x47fb04)
    #4 ZoneData::ZoneToCache(RecZoneToCache::Config const&) /__w/pdns/pdns/pdns/recursordist/pdns-recursor-0.0.0-git1/rec-zonetocache.cc:423:28 (testrunner+0x404931)
    #5 RecZoneToCache::ZoneToCache(RecZoneToCache::Config const&, RecZoneToCache::State&) /__w/pdns/pdns/pdns/recursordist/pdns-recursor-0.0.0-git1/rec-zonetocache.cc:473:10 (testrunner+0x4059fd)
    #6 rec_zonetocache::zonemdGenericTest(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, pdns::ZoneMD::Config, pdns::ZoneMD::Config, unsigned long) /__w/pdns/pdns/pdns/recursordist/pdns-recursor-0.0.0-git1/test-rec-zonetocache.cc:157:3 (testrunner+0x7a7113)
    #7 rec_zonetocache::test_zonetocachegeneric::test_method() /__w/pdns/pdns/pdns/recursordist/pdns-recursor-0.0.0-git1/test-rec-zonetocache.cc:177:3 (testrunner+0x7a60a5)
    #8 rec_zonetocache::test_zonetocachegeneric_invoker() /__w/pdns/pdns/pdns/recursordist/pdns-recursor-0.0.0-git1/test-rec-zonetocache.cc:173:1 (testrunner+0x7a60a5)
    #9 boost::detail::function::void_function_invoker0<void (*)(), void>::invoke(boost::detail::function::function_buffer&) /usr/include/boost/function/function_template.hpp:117:11 (testrunner+0x57dfab)
    #10 <null> <null> (libboost_unit_test_framework.so.1.74.0+0x323fd)
    #11 boost::execution_monitor::catch_signals(boost::function<int ()> const&) <null> (libboost_unit_test_framework.so.1.74.0+0x30b0c)
    #12 boost::execution_monitor::execute(boost::function<int ()> const&) <null> (libboost_unit_test_framework.so.1.74.0+0x30b90)
    #13 boost::execution_monitor::vexecute(boost::function<void ()> const&) <null> (libboost_unit_test_framework.so.1.74.0+0x30c60)
    #14 boost::unit_test::unit_test_monitor_t::execute_and_translate(boost::function<void ()> const&, unsigned long) <null> (libboost_unit_test_framework.so.1.74.0+0x5f1a0)
    #15 <null> <null> (libboost_unit_test_framework.so.1.74.0+0x37cdf)
    #16 <null> <null> (libboost_unit_test_framework.so.1.74.0+0x381d0)
    #17 <null> <null> (libboost_unit_test_framework.so.1.74.0+0x381d0)
    #18 boost::unit_test::framework::run(unsigned long, bool) <null> (libboost_unit_test_framework.so.1.74.0+0x3bf36)
    #19 boost::unit_test::unit_test_main(bool (*)(), int, char**) <null> (libboost_unit_test_framework.so.1.74.0+0x5e10d)
    #20 main /__w/pdns/pdns/pdns/recursordist/pdns-recursor-0.0.0-git1/testrunner.cc:84:10 (testrunner+0xc85591)
    #21 <null> <null> (libc.so.6+0x27249)
    #22 __libc_start_main <null> (libc.so.6+0x27304)
    #23 _start <null> (testrunner+0x1b79e0)
```

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit b3c90a2a8863b32484c2d42885cba738d71a102b)

3 weeks agoMerge pull request #15851 from omoerbeek/backport-ecs-to-5.2.x rec-5.2.4
Otto Moerbeek [Thu, 17 Jul 2025 08:59:42 +0000 (10:59 +0200)] 
Merge pull request #15851 from omoerbeek/backport-ecs-to-5.2.x

rec: Backport to 5.2.x: chain and harden ECS enabled queries

3 weeks agoFix test, it was using a feature only available on master 15851/head
Otto Moerbeek [Wed, 16 Jul 2025 07:52:21 +0000 (09:52 +0200)] 
Fix test, it was using a feature only available on master

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
3 weeks agoBackport of Fix two issues with chaining ECS enabled queries
Otto Moerbeek [Tue, 15 Jul 2025 14:39:47 +0000 (16:39 +0200)] 
Backport of Fix two issues with chaining ECS enabled queries

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
7 weeks agoSwitch off leak detect in CI
Otto Moerbeek [Thu, 19 Jun 2025 12:54:43 +0000 (14:54 +0200)] 
Switch off leak detect in CI

2 months agoAlwas detect mismatches in outgoing and incoming ECS; add tests for that as well
Otto Moerbeek [Mon, 19 May 2025 12:31:38 +0000 (14:31 +0200)] 
Alwas detect mismatches in outgoing and incoming ECS; add tests for that as well

2 months agoRefactor: get rid of an unneccesary loop
Otto Moerbeek [Fri, 16 May 2025 09:01:19 +0000 (11:01 +0200)] 
Refactor: get rid of an unneccesary loop

2 months agoRun all ECS tests also in hardened mode and add a specific hardened mode test
Otto Moerbeek [Thu, 8 May 2025 12:05:39 +0000 (14:05 +0200)] 
Run all ECS tests also in hardened mode and add a specific hardened mode test

2 months agoAdd setting and metric
Otto Moerbeek [Thu, 8 May 2025 10:25:36 +0000 (12:25 +0200)] 
Add setting and metric

2 months agoParse ECS info if relevant and act on it if it mismatches
Otto Moerbeek [Wed, 23 Apr 2025 11:50:51 +0000 (13:50 +0200)] 
Parse ECS info if relevant and act on it if it mismatches

Moved slowParseEDNSOptions() from dnsdist specific code to common code

2 months agoFix invalid scope test to do what I think is actually intended
Otto Moerbeek [Mon, 20 Jan 2025 13:08:02 +0000 (14:08 +0100)] 
Fix invalid scope test to do what I think is actually intended

2 months agoTo match incoming, don't look at subnet
Otto Moerbeek [Fri, 17 Jan 2025 10:49:21 +0000 (11:49 +0100)] 
To match incoming, don't look at subnet

2 months agoChain on ECS matching, and consider a mismatch in returned ECS as a spoof attempt
Otto Moerbeek [Wed, 15 Jan 2025 13:23:04 +0000 (14:23 +0100)] 
Chain on ECS matching, and consider a mismatch in returned ECS as a spoof attempt

2 months agoPass actual (optional) ecs instead of bool to asendto()
Otto Moerbeek [Wed, 15 Jan 2025 11:21:07 +0000 (12:21 +0100)] 
Pass actual (optional) ecs instead of bool to asendto()

4 months agoMerge pull request #15403 from omoerbeek/rec-5.2.1-to-be rec-5.2.2
Otto Moerbeek [Tue, 8 Apr 2025 08:48:49 +0000 (10:48 +0200)] 
Merge pull request #15403 from omoerbeek/rec-5.2.1-to-be

rec: Backport of 15396 to 5.2.x: rework of #14822: fix a difference between record-cache hit and miss in some ServFail results

4 months agoMerge pull request #15404 from omoerbeek/backport-15352-to-rec-5.2.x
Otto Moerbeek [Tue, 8 Apr 2025 08:14:18 +0000 (10:14 +0200)] 
Merge pull request #15404 from omoerbeek/backport-15352-to-rec-5.2.x

rec: Backport 15352 to rec 5.2.x: in test_SimpleDot.py make sure we have the root DNSKEY in cache, it might require TCP

4 months agoUpdate regression-tests.recursor-dnssec/test_SimpleDoT.py 15404/head
Otto Moerbeek [Mon, 24 Mar 2025 12:56:17 +0000 (13:56 +0100)] 
Update regression-tests.recursor-dnssec/test_SimpleDoT.py

Co-authored-by: Miod Vallat <miod.vallat@powerdns.com>
(cherry picked from commit 173e64959ab4ea2890d76825be2742601727cc42)

4 months agorec: in test_SimpleDot.py make sure we have the root DNSKEY in cache, it might requir...
Otto Moerbeek [Mon, 24 Mar 2025 12:10:28 +0000 (13:10 +0100)] 
rec: in test_SimpleDot.py make sure we have the root DNSKEY in cache, it might require TCP

Previously we assumed we didn't need TCP at all.

(cherry picked from commit 4025ecc524689b38527e31c1f38aa1ebb23e7bc3)

4 months agorec: rework of #14822: fix a difference between record-cache hit and miss in some... 15403/head rec-5.2.1
Otto Moerbeek [Wed, 19 Mar 2025 10:52:31 +0000 (11:52 +0100)] 
rec: rework of #14822: fix a difference between record-cache hit and miss in some ServFail results

Fixes: CNAME with target non-existent record in auth zone causes segfault
4 months agorec: 5.2.x: Remove formatting and secpoll workflows, update fuzzing to ubuntu 24.04
Otto Moerbeek [Tue, 11 Mar 2025 12:40:26 +0000 (13:40 +0100)] 
rec: 5.2.x: Remove formatting and secpoll workflows, update fuzzing to ubuntu 24.04

5 months agoMerge pull request #15279 from omoerbeek/backport-15254-to-rec-5.2.x
Otto Moerbeek [Tue, 11 Mar 2025 15:30:01 +0000 (16:30 +0100)] 
Merge pull request #15279 from omoerbeek/backport-15254-to-rec-5.2.x

rec: Backport 15254 to rec-5.2.x: If we see both a CNAME and answer records, follow CNAME and discard the answer records

5 months agoMerge pull request #15282 from omoerbeek/rec-stop-using-ubuntu-20-on-rec-5.2.x
Otto Moerbeek [Tue, 11 Mar 2025 15:29:04 +0000 (16:29 +0100)] 
Merge pull request #15282 from omoerbeek/rec-stop-using-ubuntu-20-on-rec-5.2.x

rec: 5.2.x: Remove formatting and secpoll workflows, update fuzzing to ubuntu 24.04

5 months agorec: 5.2.x: Remove formatting and secpoll workflows, update fuzzing to ubuntu 24.04 15282/head
Otto Moerbeek [Tue, 11 Mar 2025 12:40:26 +0000 (13:40 +0100)] 
rec: 5.2.x: Remove formatting and secpoll workflows, update fuzzing to ubuntu 24.04

5 months agoIf we see both a CNAME and answer records, follow CNAME and discard the answer records 15279/head
Otto Moerbeek [Tue, 4 Mar 2025 08:52:15 +0000 (09:52 +0100)] 
If we see both a CNAME and answer records, follow CNAME and discard the answer records

(cherry picked from commit 8eb86803de0d9a61ab5e3984c3e0a43cee37322b)

5 months agoMerge pull request #15212 from omoerbeek/backport-15205-to-rec-5.2.x
Otto Moerbeek [Tue, 25 Feb 2025 07:31:51 +0000 (08:31 +0100)] 
Merge pull request #15212 from omoerbeek/backport-15205-to-rec-5.2.x

rec: Backport 15203 to rec-5.2.x: switch back to serde_yaml

5 months agoMerge pull request #15211 from omoerbeek/backport-15072-to-rec-5.2.x
Otto Moerbeek [Tue, 25 Feb 2025 07:31:32 +0000 (08:31 +0100)] 
Merge pull request #15211 from omoerbeek/backport-15072-to-rec-5.2.x

rec: Backport 15072 to rec-5.2.x: Adjust Content-Type header for Prometheus endpoint to include version

5 months agoMerge pull request #15210 from omoerbeek/backport-15063-to-rec-5.2.x
Otto Moerbeek [Tue, 25 Feb 2025 07:31:16 +0000 (08:31 +0100)] 
Merge pull request #15210 from omoerbeek/backport-15063-to-rec-5.2.x

rec: Backport 15063 to rec-5.2.x: Include cstdint to get uint64_t

5 months agoMerge pull request #15209 from omoerbeek/backport-15023-to-rec-5.2.x
Otto Moerbeek [Tue, 25 Feb 2025 07:31:01 +0000 (08:31 +0100)] 
Merge pull request #15209 from omoerbeek/backport-15023-to-rec-5.2.x

rec: Backport 15023 to rec-5.2.x: remove spurious ] in configure.ac

5 months agoRemove spurious ] causing shell complaints during configure. 15209/head
Miod Vallat [Thu, 9 Jan 2025 09:56:59 +0000 (10:56 +0100)] 
Remove spurious ] causing shell complaints during configure.

(cherry picked from commit b7fbaec29c727898105736f77fb0cce452739a3e)

5 months agoInclude cstdint to get uint64_t 15210/head
Otto Moerbeek [Mon, 20 Jan 2025 10:09:42 +0000 (11:09 +0100)] 
Include cstdint to get uint64_t

Should fix #15060

(cherry picked from commit 23dd0603511f7b34f43e8d6c121aa4277d2cb317)

5 months agoAdjust Content-Type header for Prometheus endpoint to include version 15211/head
Wouter de Vries [Tue, 21 Jan 2025 14:18:57 +0000 (15:18 +0100)] 
Adjust Content-Type header for Prometheus endpoint to include version

Prometheus v3 will, by default, be more strict about the content-types
returned from scrape endpoints. With the current value (just
`text/plain`), it would fail to scrape.

In this commit the value is changed from `text/plain` to `text/plain;
version=0.0.4`.

See also [1] and [2]
[1] https://prometheus.io/docs/instrumenting/exposition_formats/
[2] https://prometheus.io/docs/prometheus/3.0/migration/

(cherry picked from commit f572f31ecd8d76793f1f5864ab740f6f7f7e2b84)

5 months agorec: backport 15203 to rec-5.2.x: switch back to serde_yaml 15212/head
Otto Moerbeek [Mon, 24 Feb 2025 11:00:36 +0000 (12:00 +0100)] 
rec: backport 15203 to rec-5.2.x: switch back to serde_yaml

7 months agoMerge pull request #15015 from omoerbeek/backport-15010-to-rec-5.2.x rec-5.2.0
Otto Moerbeek [Fri, 10 Jan 2025 09:04:52 +0000 (10:04 +0100)] 
Merge pull request #15015 from omoerbeek/backport-15010-to-rec-5.2.x

rec: Backport 15010 to rec 5.2.x: fix protobufServer(.. {taggedOnly=true}) logic for cache-returned responses

7 months agoMerge pull request #15020 from omoerbeek/backport-15019-to-rec-5.2.x
Otto Moerbeek [Wed, 8 Jan 2025 10:54:24 +0000 (11:54 +0100)] 
Merge pull request #15020 from omoerbeek/backport-15019-to-rec-5.2.x

rec: Backport 15019 to rec-5.2.x: explictly log port of listening addresses

7 months agorec: explictly log port of listening addresses 15020/head
Otto Moerbeek [Wed, 8 Jan 2025 08:50:57 +0000 (09:50 +0100)] 
rec: explictly log port of listening addresses

(cherry picked from commit 18afcf446561eaf7e079f7b2514b2f0830f384f6)

7 months agoMerge pull request #15014 from omoerbeek/backport-14991-to-rec-5.2.x
Otto Moerbeek [Mon, 6 Jan 2025 13:01:49 +0000 (14:01 +0100)] 
Merge pull request #15014 from omoerbeek/backport-14991-to-rec-5.2.x

rec: Backport 14991 to rec 5.2.x: zap dangling symlink

7 months agoTest the non-tagged packet cache hit case and test both UDP and TCP clients while... 15015/head
Otto Moerbeek [Mon, 6 Jan 2025 08:57:29 +0000 (09:57 +0100)] 
Test the non-tagged packet cache hit case and test both UDP and TCP clients while there

(cherry picked from commit 5600caff0e8743a77b556f9976acbc5b992868aa)

7 months agorecursor: outgoingProtobufServer() ignores taggedOnly protobuf option,
Tomasz Pala [Sat, 4 Jan 2025 12:55:27 +0000 (13:55 +0100)] 
recursor: outgoingProtobufServer() ignores taggedOnly protobuf option,
therefore do not annouce it; outgoing server is used as outgoingLoggers
in LWResult::Result asyncresolve(); after being introduced in
4898a34 filtering of outgoingP..S..() was not implemented since b790ef3

(cherry picked from commit d840333d03b1d3dbf15c2160a44dfa940ccf5533)

7 months agotypo
Tomasz Pala [Sat, 4 Jan 2025 04:36:48 +0000 (05:36 +0100)] 
typo

(cherry picked from commit fb07dc11102eb108b1ada8d01768cf61dc072c2b)

7 months agorec: TCP counterpart to protobufServer(.. {taggedOnly=true}) fix
Tomasz Pala [Sat, 4 Jan 2025 02:55:20 +0000 (03:55 +0100)] 
rec: TCP counterpart to protobufServer(.. {taggedOnly=true}) fix

(cherry picked from commit fc26c932d050d3f05e008f9f8864b66989d3b4d0)

7 months agorecursor: fix protobufServer(.. {taggedOnly=true}) logic for
Tomasz Pala [Fri, 3 Jan 2025 23:44:55 +0000 (00:44 +0100)] 
recursor: fix protobufServer(.. {taggedOnly=true}) logic for
cache-returned responses (problem existing since initial ac10822)
fixes #15007

(cherry picked from commit 647162c4cb641d9368ddf9f992a351c1cacf222a)

7 months agorec: zap dangling symlink, leftover of #14926 15014/head
Otto Moerbeek [Fri, 20 Dec 2024 13:35:21 +0000 (14:35 +0100)] 
rec: zap dangling symlink, leftover of #14926

(cherry picked from commit 472b550479aa41bb08ff76b356f454ff8e4b7c9f)

7 months agoMerge pull request #14962 from omoerbeek/backport-14957-to-rec-5.2.x rec-5.2.0-rc1
Otto Moerbeek [Fri, 13 Dec 2024 09:29:36 +0000 (10:29 +0100)] 
Merge pull request #14962 from omoerbeek/backport-14957-to-rec-5.2.x

rec: backport 14957 to rec-5.2.x: Avoid local source port 4791

7 months agoUpdate pdns/recursordist/settings/table.py 14962/head
Otto Moerbeek [Fri, 13 Dec 2024 08:26:14 +0000 (09:26 +0100)] 
Update pdns/recursordist/settings/table.py

Co-authored-by: Miod Vallat <miod.vallat@open-xchange.com>
(cherry picked from commit 5feb5df99f3e592634469ad723083551891e1b14)

7 months agoAdd versionchanged clause
Otto Moerbeek [Fri, 13 Dec 2024 08:24:19 +0000 (09:24 +0100)] 
Add versionchanged clause

(cherry picked from commit f25df44319183845034bff7a0c96cc406961fc15)

7 months agosort udp_source_port_avoid list
zhaojs [Thu, 12 Dec 2024 11:04:16 +0000 (19:04 +0800)] 
sort udp_source_port_avoid  list

(cherry picked from commit 7b8207b1c96b85579bb6d9e69e499be9c518ddae)

7 months agorecursor local udp port avoid 4791
zhaojingshi [Thu, 12 Dec 2024 08:57:44 +0000 (16:57 +0800)] 
recursor local udp port avoid 4791

When the recursor sends a DNS request and the local port is specified as 4791, if there is RDMA hardware on the machine, when the response with dst as port 4791 reaches the network card driver, it will be directly processed by the hardware as Roce v2 protocol, and the recursor will not get a response to this request.

(cherry picked from commit d0b0158ef76e556c88ab59b2baad8c8d9970543e)

7 months agoMerge pull request #14949 from omoerbeek/rec-specialize-5.2.x-branch
Otto Moerbeek [Fri, 13 Dec 2024 08:23:11 +0000 (09:23 +0100)] 
Merge pull request #14949 from omoerbeek/rec-specialize-5.2.x-branch

rec: specialize rec-5.2.x branch

8 months agorec: specialize rec-5.2.x branch 14949/head
Otto Moerbeek [Tue, 10 Dec 2024 11:10:54 +0000 (12:10 +0100)] 
rec: specialize rec-5.2.x branch

8 months agoMerge pull request #14942 from omoerbeek/rec-sockets-less-chatty
Otto Moerbeek [Tue, 10 Dec 2024 10:07:12 +0000 (11:07 +0100)] 
Merge pull request #14942 from omoerbeek/rec-sockets-less-chatty

rec: log only one line per protocol for listening sockets,

8 months agoMerge pull request #14941 from omoerbeek/rec-meson-gen-metrics-fixup
Otto Moerbeek [Tue, 10 Dec 2024 09:56:46 +0000 (10:56 +0100)] 
Merge pull request #14941 from omoerbeek/rec-meson-gen-metrics-fixup

rec: generate metrics files (also) where meson expects them

8 months agoAdd comments about the prupose of the added arguments to make{UDP,TCP}ServerSockets 14942/head
Otto Moerbeek [Tue, 10 Dec 2024 09:20:58 +0000 (10:20 +0100)] 
Add comments about the prupose of the added arguments to make{UDP,TCP}ServerSockets

8 months agoAdd FIXME comment 14941/head
Otto Moerbeek [Tue, 10 Dec 2024 09:16:44 +0000 (10:16 +0100)] 
Add FIXME comment

8 months agoMerge pull request #14947 from rgacogne/ddist-doc-dq-elapsedus
Remi Gacogne [Mon, 9 Dec 2024 15:49:56 +0000 (16:49 +0100)] 
Merge pull request #14947 from rgacogne/ddist-doc-dq-elapsedus

dnsdist: Document that `DNSQuestion::getElapsedUs` will be added in 1.9.8

8 months agodnsdist: Document that `DNSQuestion::getElapsedUs` will be added in 1.9.8 14947/head
Remi Gacogne [Mon, 9 Dec 2024 15:08:57 +0000 (16:08 +0100)] 
dnsdist: Document that `DNSQuestion::getElapsedUs` will be added in 1.9.8

8 months agoMerge pull request #14938 from karelbilek/keylogfile_master
Remi Gacogne [Mon, 9 Dec 2024 15:01:01 +0000 (16:01 +0100)] 
Merge pull request #14938 from karelbilek/keylogfile_master

dnsdist: allow setting keyLogFile to DoT/DoH backends

8 months agoMerge pull request #14930 from rgacogne/ddist-fix-WeightedBalancingFactor
Remi Gacogne [Mon, 9 Dec 2024 13:05:03 +0000 (14:05 +0100)] 
Merge pull request #14930 from rgacogne/ddist-fix-WeightedBalancingFactor

dnsdist: Fix issues with the balancing factors

8 months agoSimple regression test for existence of SSL keys 14938/head
Karel Bilek [Mon, 9 Dec 2024 12:32:07 +0000 (13:32 +0100)] 
Simple regression test for existence of SSL keys

There is no test for actual validity of the files... just if there is something there.

8 months agoAllow setting keyLogFile to DoT/DoH backends
Karel Bilek [Mon, 9 Dec 2024 08:44:51 +0000 (09:44 +0100)] 
Allow setting keyLogFile to DoT/DoH backends

8 months agoMerge pull request #14943 from omoerbeek/rec-ds-zonecut-invalid
Otto Moerbeek [Mon, 9 Dec 2024 11:45:55 +0000 (12:45 +0100)] 
Merge pull request #14943 from omoerbeek/rec-ds-zonecut-invalid

rec: Skip the current zone when looking for a cut after an invalid DS denial proof

8 months agorec: Skip the current zone when looking for a cut after an invalid DS denial proof 14943/head
Otto Moerbeek [Tue, 3 Dec 2024 10:57:23 +0000 (11:57 +0100)] 
rec: Skip the current zone when looking for a cut after an invalid DS denial proof

8 months agorec: log only one line per protocol for listening sockets,
Otto Moerbeek [Mon, 9 Dec 2024 08:32:02 +0000 (09:32 +0100)] 
rec: log only one line per protocol for listening sockets,

Instead of addresses * threads * protocol lines

8 months agoUpdate pdns/recursordist/metrics.py
Otto Moerbeek [Mon, 9 Dec 2024 08:28:33 +0000 (09:28 +0100)] 
Update pdns/recursordist/metrics.py

Co-authored-by: Miod Vallat <miod.vallat@open-xchange.com>
8 months agoMerge pull request #14913 from miodvallat/bugfix/12650
Miod Vallat [Mon, 9 Dec 2024 06:41:25 +0000 (07:41 +0100)] 
Merge pull request #14913 from miodvallat/bugfix/12650

[bugfix] Reject hexadecimal blobs with odd number of characters

8 months agorec: generate metrics files (also) where meson expects them
Otto Moerbeek [Fri, 6 Dec 2024 15:42:19 +0000 (16:42 +0100)] 
rec: generate metrics files (also) where meson expects them

This avoids unneccesary regeneration of files

8 months agodnsdist: Add a regression tests for whashed and chashed 14930/head
Remi Gacogne [Fri, 6 Dec 2024 10:27:13 +0000 (11:27 +0100)] 
dnsdist: Add a regression tests for whashed and chashed

8 months agoMerge pull request #14936 from rgacogne/gate-daily-packages-build
Remi Gacogne [Fri, 6 Dec 2024 10:28:00 +0000 (11:28 +0100)] 
Merge pull request #14936 from rgacogne/gate-daily-packages-build

CI: Run the daily package building workflow only if requested

8 months agoCI: Run the daily package building workflow only if requested 14936/head
Remi Gacogne [Fri, 6 Dec 2024 09:39:13 +0000 (10:39 +0100)] 
CI: Run the daily package building workflow only if requested

After this commit, the `build-packages-daily-master` workflow will
only be executed on repositories that have a `SCHEDULED_PACKAGES_DAILY`
variable set to a non-negative value.

8 months agoMerge pull request #14926 from miodvallat/feature/12953
Peter van Dijk [Fri, 6 Dec 2024 09:15:07 +0000 (10:15 +0100)] 
Merge pull request #14926 from miodvallat/feature/12953

[feature] remove support for libdecaf

8 months agoAdd unit test for invalid NSEC3 hex blob. 14913/head
Miod Vallat [Fri, 6 Dec 2024 07:35:59 +0000 (08:35 +0100)] 
Add unit test for invalid NSEC3 hex blob.

8 months agoRemove support for libdecaf. 14926/head
Miod Vallat [Wed, 4 Dec 2024 08:39:02 +0000 (09:39 +0100)] 
Remove support for libdecaf.

Fixes #12953

8 months agoMerge pull request #14934 from omoerbeek/gh-action-build-name
Otto Moerbeek [Thu, 5 Dec 2024 10:51:21 +0000 (11:51 +0100)] 
Merge pull request #14934 from omoerbeek/gh-action-build-name

GH workflow for building packages: change name so target isn't chopped off

8 months agodnsdist: Fix the consistency check for the balancing factors
Remi Gacogne [Wed, 4 Dec 2024 14:29:45 +0000 (15:29 +0100)] 
dnsdist: Fix the consistency check for the balancing factors

Zero is the initial value, but until now it was only possible to pass a value greater than or equal to 1.0 to `setWeightedBalancingFactor()` so it was not possible to reset it to the default value.

8 months agodnsdist: Fix `whashed` and `wrandom` using the wrong parameter for consistent hashing
Remi Gacogne [Wed, 4 Dec 2024 14:28:50 +0000 (15:28 +0100)] 
dnsdist: Fix `whashed` and `wrandom` using the wrong parameter for consistent hashing

8 months agoMerge pull request #14923 from belminf/master
Remi Gacogne [Wed, 4 Dec 2024 08:16:29 +0000 (09:16 +0100)] 
Merge pull request #14923 from belminf/master

dnsdist: Fix addMaintenanceCallback example

8 months agoMerge pull request #14925 from milzi234/bugfix/recursor-docs-build
Peter van Dijk [Tue, 3 Dec 2024 21:51:08 +0000 (22:51 +0100)] 
Merge pull request #14925 from milzi234/bugfix/recursor-docs-build

adjusted paths

8 months agoadjusted paths 14925/head
milzi234 [Tue, 3 Dec 2024 21:17:28 +0000 (22:17 +0100)] 
adjusted paths

8 months agodnsdist: Fix addMaintenanceCallback example 14923/head
Belmin Fernandez [Tue, 3 Dec 2024 18:57:18 +0000 (13:57 -0500)] 
dnsdist: Fix addMaintenanceCallback example

8 months agoMerge pull request #14922 from milzi234/bugfix/pdfs-in-wrong-location
milzi234 [Tue, 3 Dec 2024 18:53:30 +0000 (19:53 +0100)] 
Merge pull request #14922 from milzi234/bugfix/pdfs-in-wrong-location

put pdfs in latex subdirectory before uploading to web1

8 months agoor remove the extra upload step :) 14922/head
milzi234 [Tue, 3 Dec 2024 16:46:11 +0000 (17:46 +0100)] 
or remove the extra upload step :)

8 months agoput pdfs in latex subdirectory before uploading to web1
milzi234 [Tue, 3 Dec 2024 16:23:14 +0000 (17:23 +0100)] 
put pdfs in latex subdirectory before uploading to web1

8 months agoGH workflow for building packages: change name so target isn't chopped off 14934/head
Otto Moerbeek [Tue, 3 Dec 2024 15:54:32 +0000 (16:54 +0100)] 
GH workflow for building packages: change name so target isn't chopped off

8 months agoMerge pull request #14921 from milzi234/bugfix/missing-pdfs
Peter van Dijk [Tue, 3 Dec 2024 14:09:57 +0000 (15:09 +0100)] 
Merge pull request #14921 from milzi234/bugfix/missing-pdfs

also add the PDFs to the websites

8 months agoalso add the PDFs to the websites 14921/head
milzi234 [Tue, 3 Dec 2024 12:39:06 +0000 (13:39 +0100)] 
also add the PDFs to the websites

8 months agoMerge pull request #14919 from milzi234/bugfix/untar-docs-before-pushing-to-web2
Peter van Dijk [Tue, 3 Dec 2024 11:49:14 +0000 (12:49 +0100)] 
Merge pull request #14919 from milzi234/bugfix/untar-docs-before-pushing-to-web2

Fix for upload to web1

8 months agountar the html docs before syncing them to web1. Remove tar.bz2 of documentation... 14919/head
milzi234 [Tue, 3 Dec 2024 11:16:30 +0000 (12:16 +0100)] 
untar the html docs before syncing them to web1. Remove tar.bz2 of documentation sites

8 months agoMerge pull request #14912 from PowerDNS/dependabot/github_actions/actions/setup-node-4
Remi Gacogne [Tue, 3 Dec 2024 10:16:49 +0000 (11:16 +0100)] 
Merge pull request #14912 from PowerDNS/dependabot/github_actions/actions/setup-node-4

build(deps): bump actions/setup-node from 3 to 4

8 months agoMerge pull request #14917 from omoerbeek/rec-dockerfile
Otto Moerbeek [Tue, 3 Dec 2024 09:28:11 +0000 (10:28 +0100)] 
Merge pull request #14917 from omoerbeek/rec-dockerfile

rec: sync Dockerfile build options with packages

8 months agoMerge pull request #14916 from omoerbeek/docs-modernize-urls
Otto Moerbeek [Tue, 3 Dec 2024 08:53:41 +0000 (09:53 +0100)] 
Merge pull request #14916 from omoerbeek/docs-modernize-urls

Fix a few URLs to point directly to the powerdns website

8 months agorec: sync Dockerfile build options with packages 14917/head
Otto Moerbeek [Tue, 3 Dec 2024 08:25:19 +0000 (09:25 +0100)] 
rec: sync Dockerfile build options with packages

Fixes #14915

Before:
Features: libcrypto-ecdsa libcrypto-ed25519 libcrypto-ed448 libcrypto-eddsa lua nod protobuf dnstap-framestream sodium curl scrypt

After:
Features: libcrypto-ecdsa libcrypto-ed25519 libcrypto-ed448 libcrypto-eddsa lua nod protobuf dnstap-framestream snmp sodium curl DoT scrypt

8 months agoFix a few URLs to point directly to the powerdns website 14916/head
Otto Moerbeek [Tue, 3 Dec 2024 07:49:51 +0000 (08:49 +0100)] 
Fix a few URLs to point directly to the powerdns website

8 months agoMerge pull request #14910 from milzi234/bugfix/push-docs-to-web1
Peter van Dijk [Mon, 2 Dec 2024 17:12:00 +0000 (18:12 +0100)] 
Merge pull request #14910 from milzi234/bugfix/push-docs-to-web1

Install inv before using it

8 months agobuild(deps): bump actions/setup-node from 3 to 4 14912/head
dependabot[bot] [Mon, 2 Dec 2024 15:55:43 +0000 (15:55 +0000)] 
build(deps): bump actions/setup-node from 3 to 4

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
8 months agoReject hexadecimal blobs with odd number of characters, fixes #12650.
Miod Vallat [Mon, 2 Dec 2024 15:47:11 +0000 (16:47 +0100)] 
Reject hexadecimal blobs with odd number of characters, fixes #12650.

Changes in 4e75f84ac9a0ad451d096d8c9cad58fd3b5574dd to allow ignoring
non-hexa characters (such as whitespace) have also allowed dangling
hex digits, which were then padded with an implicit 0. This restores
the original behaviour of throwing an exception for these inputs.

8 months agoremoves cargo culted lines 14910/head
milzi234 [Mon, 2 Dec 2024 11:22:21 +0000 (12:22 +0100)] 
removes cargo culted lines

8 months agoInstall inv before using it
milzi234 [Mon, 2 Dec 2024 10:09:25 +0000 (11:09 +0100)] 
Install inv before using it

8 months agoMerge pull request #14767 from milzi234/master
Peter van Dijk [Mon, 2 Dec 2024 09:18:57 +0000 (10:18 +0100)] 
Merge pull request #14767 from milzi234/master

Publish Docs to Netlify and AWS

8 months agoMerge pull request #14909 from omoerbeek/rec-startstop-fix
Otto Moerbeek [Mon, 2 Dec 2024 09:01:29 +0000 (10:01 +0100)] 
Merge pull request #14909 from omoerbeek/rec-startstop-fix

re: followup to 14796: also call stop hook in 1 thread case

8 months agoMerge pull request #14892 from omoerbeek/rec-docs-runtime-quoting
Otto Moerbeek [Mon, 2 Dec 2024 08:49:42 +0000 (09:49 +0100)] 
Merge pull request #14892 from omoerbeek/rec-docs-runtime-quoting

rec: fix quoting issue in #14886

8 months agore: followup to 14796: also call stop hook in 1 thread case 14909/head
Otto Moerbeek [Mon, 2 Dec 2024 08:19:52 +0000 (09:19 +0100)] 
re: followup to 14796: also call stop hook in 1 thread case