fix(player.c): increase the log level of the constantly repeated resend check startup message ("check start") from "2" to "3" as to maintain readabiility of log verbosity level 2.
commit 7dc145361186806a560495d8171a387f5856f2f0
Author: Mike Brady <mikebrady@eircom.net>
Replace the code for determining when resends should be sent for missing audio packets.
Multiple sequential resend requests are now rolled up into one.
Mike Brady [Tue, 10 Sep 2019 12:03:54 +0000 (13:03 +0100)]
ensure alsa mixer is initialised before trying to set volume. Normalise the 'pvol' volume mesasages to the hardware devices' maximum volume when using combined hardware and software attenuation.
Mike Brady [Tue, 10 Sep 2019 09:08:47 +0000 (10:08 +0100)]
Bug fixes
Fixes an error whereby the 'pvol' volume metadata was no longer sent if Shairport Sync was configured to ignore volume control information coming from the audio source. Addresses issue #903.
Fixes a compilation error if including the MQTT client.
Mike Brady [Wed, 4 Sep 2019 08:24:34 +0000 (09:24 +0100)]
Fix occasional crashing bug in Ububntu 14.04 (sometimes triggered by DHCP renewal and Avahi / dbus issues) by removing second avahi threaded poll and an unnecessary avahi service client (very sparse Avahi documentation), also remove obselete SIG setup code.
Mike Brady [Thu, 29 Aug 2019 10:56:13 +0000 (11:56 +0100)]
Fix Issue #890 -- https://github.com/mikebrady/shairport-sync/issues/890
Fix metadata issues with the dbus and the MPRIS interfaces -- handle missing artwork properly, make the 'available' property more resilient.
Mike Brady [Thu, 29 Aug 2019 10:47:49 +0000 (11:47 +0100)]
Squashed commit of the following:
Fix Issue #890 -- https://github.com/mikebrady/shairport-sync/issues/890
Recognise situation where a track has no artwork properly.
Less likely to drop the 'availabile' property.
Always output the full metadata whenever any part of it has changed.
Metadata coming from dacp is now incorporated,
Henrik Nilsson [Wed, 31 Jul 2019 12:16:06 +0000 (14:16 +0200)]
Check help and version argument early
Check for the help and version arguments makes sure that it's
always possible to get the version and usage even if there are
issues in other parts of the code.
Chris Boot [Sat, 27 Jul 2019 03:05:38 +0000 (00:05 -0300)]
More typo fixes across the tree
Previously I have made spelling changes as caught by Debian's lintian
tool, which has a short list of common misspellings that it tests for.
This time I decided to run codespell against the source and fix all the
obvious problems it came up with. It also uses a list of misspellings
but it's much larger than lintian's, but also has some false positives
so I went over the list by hand.
The command I used to do check the source was:
git ls-tree -rz --name-only HEAD | xargs -0 codespell -L minimise,errorstring
Mike Brady [Sun, 21 Jul 2019 07:06:37 +0000 (09:06 +0200)]
Fix a bug that sometimes caused a crash when a service name was specified in the configuration file. The fix was to be more systematic in allocating and deallocating memory for termporary strings. Thanks to Chris Boot, Ari Sovijarvi and Jeroen Massar for the bug report. Fixes Debian Bug report #925577.
Allow the rtsp_listen_loop to exit if the RTSP port (usually port 5000) is not available. This allows the system to exit cleanly rather than abort.
Mike Brady [Thu, 20 Jun 2019 09:45:27 +0000 (10:45 +0100)]
Expose some of the settings used in the disable_standby_mode.
Specifically, firstly, the disable_standby_mode_silence_threshold, which is the
amount of audio in the output device's hardware buffer. It should normally
be close to the value givein in the audio_backend_buffer_desired_length_in_seconds
setting. If it drops to this value, silence is added to the buffer to prevent
the output device from becoming idle.
Secondly, the disable_standby_mode_silence_scan_interval is the time between checks
of the output device's hardware buffer.
The code for generating frames of possibly-dithered silence has been simplified.
Mike Brady [Wed, 5 Jun 2019 14:05:54 +0000 (15:05 +0100)]
*Bug Fixes*
* Fix a bug in the MQTT documentation and add sanity checking for the port chosen.
* Fix a bug that caused manual format and rate setting to be ignored.
* Add missing support for format settings S24_LE, S24_BE, S32_LE and S32_BE.
* Fix a bug that caused dither to be too loud.
* Fix error message for invalid standby mode choice.
enable specification of specific formats and/or speeds to turn off automatic format/speed selection, fixing a bug. Clarify some of the warnings. Fix a few typos in the configuration file sample.
Merge pull request #855 from idcrook/conf_mqtt_port
mqtt port config changes – fix error in the configuration file and check port number for sanity.
Many thanks, David. It'll find it's easy into the next release.
Mike Brady [Wed, 29 May 2019 15:00:47 +0000 (16:00 +0100)]
enable specification of specific formats and/or speeds to turn off automatic format/speed selection, fixing a bug. Clarify some of the warnings. Fix a few typos in the configuration file sample.
Mike Brady [Mon, 27 May 2019 08:30:57 +0000 (09:30 +0100)]
Merge pull request #855 from idcrook/conf_mqtt_port
mqtt port config changes – fix error in the configuration file and check port number for sanity.
Many thanks, David. It'll find it's easy into the next release.