Ruben Kerkhof [Fri, 18 Mar 2016 11:59:03 +0000 (12:59 +0100)]
Fix build on Solaris 10 i386
AC_SYS_LARGEFILE defines _FILE_OFFSET_BITS in src/config.h,
so we need this header first before including system headers.
Thanks to @dago for the report.
Fixes:
CC collectd-utils_random.o
In file included from collectd.h:31:0,
from utils_random.c:29:
../../src/config.h:1646:0: error: "_FILE_OFFSET_BITS" redefined
[-Werror]
#define _FILE_OFFSET_BITS 64
^
In file included from
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/pthread.h:20:0,
from utils_random.c:27:
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/sys/feature_tests.h:196:0:
note: this is the location of the previous definition
#define _FILE_OFFSET_BITS 32
^
cc1: all warnings being treated as errors
Ruben Kerkhof [Fri, 18 Mar 2016 11:59:03 +0000 (12:59 +0100)]
Fix build on Solaris 10 i386
AC_SYS_LARGEFILE defines _FILE_OFFSET_BITS in src/config.h,
so we need this header first before including system headers.
Thanks to @dago for the report.
Fixes:
CC collectd-utils_random.o
In file included from collectd.h:31:0,
from utils_random.c:29:
../../src/config.h:1646:0: error: "_FILE_OFFSET_BITS" redefined
[-Werror]
#define _FILE_OFFSET_BITS 64
^
In file included from
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/pthread.h:20:0,
from utils_random.c:27:
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/sys/feature_tests.h:196:0:
note: this is the location of the previous definition
#define _FILE_OFFSET_BITS 32
^
cc1: all warnings being treated as errors
Ruben Kerkhof [Sat, 12 Mar 2016 16:30:58 +0000 (17:30 +0100)]
onewire plugin: fix two compiler warnings
onewire.c:418:31: warning: comparison of integers of different signs:
'int' and 'unsigned long' [-Wsign-compare]
if ((status > 0) && (status < sizeof (subpath)))
~~~~~~ ^ ~~~~~~~~~~~~~~~~
onewire.c:422:31: warning: comparison of integers of different signs:
'int' and 'unsigned long' [-Wsign-compare]
if ((status > 0) && (status < sizeof (subpath)))
~~~~~~ ^ ~~~~~~~~~~~~~~~~
Collection3: Graphing speed improvements with many hosts
At present graph.cgi is extremely slowly on servers with large numbers of
RRD files. This is because it issues an unnecessary stat() call to _every_
RRD file on the local system before loading and rendering graph data.
Patch originally from:
http://mailman.verplant.org/pipermail/collectd/2011-May/004519.html
The patch was improved so that it correctly handles multiple hostnames.
I'm seeing a 5x improvement in speed, the original patch creator
had a 24x speedup.
Ruben Kerkhof [Wed, 9 Mar 2016 22:44:42 +0000 (23:44 +0100)]
Revert "Fix building with older versions of libtool"
While this fixed building from git on EL5, it broke
building from tarballs. Since the latter is more important,
revert this until I can get to the bottom of it.
Ruben Kerkhof [Sun, 6 Mar 2016 17:08:38 +0000 (18:08 +0100)]
Revert "Turbostat: add missing types in configure.ac"
These autoconf tests were introduced in autoconf 2.60.
We still support older versions.
We've assumed for a while now that any platform we build
on has the types and functionality tested here available, and supports
a reasonable subset of the C99 and Posix standards.
Seen on FreeBSD:
curl_json.c: In function 'cj_sock_perform':
curl_json.c:864:10: warning: missing initializer for field 'sun_len' of 'struct sockaddr_un' [-Wmissing-field-initializers]
struct sockaddr_un sa_unix = {};
^
In file included from curl_json.c:32:0:
/usr/include/sys/un.h:48:16: note: 'sun_len' declared here
unsigned char sun_len; /* sockaddr len including null */
^
Ruben Kerkhof [Sun, 6 Mar 2016 11:46:15 +0000 (12:46 +0100)]
Travis: build python plugin
The Travis image has various python versions installed in /opt,
none of which have development headers, and they are first in
the PATH. Explicitly use the python in /usr/bin instead.