]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/log
thirdparty/foundation/foundation-sites.git
6 years agoMerge branch 'develop' into refactor/mouseleave-special-case 11418/head
Nicolas Coden [Mon, 10 Sep 2018 20:37:41 +0000 (22:37 +0200)] 
Merge branch 'develop' into refactor/mouseleave-special-case

6 years agostyle: remove extranous linebreak in Touch
Nicolas Coden [Sun, 9 Sep 2018 21:51:25 +0000 (23:51 +0200)] 
style: remove extranous linebreak in Touch

6 years agoMerge pull request #11491 from ncoden/chore/fix-gulp-sass-watch
Nicolas Coden [Sun, 9 Sep 2018 18:59:11 +0000 (20:59 +0200)] 
Merge pull request #11491 from ncoden/chore/fix-gulp-sass-watch

chore: update docs styles when SCSS change

6 years agoMerge pull request #11497 from ncoden/docs/js-tree-shaking-path
Harry Manchanda [Sun, 9 Sep 2018 18:45:46 +0000 (00:15 +0530)] 
Merge pull request #11497 from ncoden/docs/js-tree-shaking-path

docs: use named imports in javascript documentation

6 years agodocs: use named import for javascript "direct import" fallback 11497/head
Nicolas Coden [Sun, 9 Sep 2018 18:15:14 +0000 (20:15 +0200)] 
docs: use named import for javascript "direct import" fallback

6 years agodocs: fix "zplugin" typo in Accordion & Tabs events 11477/head
Nicolas Coden [Sun, 9 Sep 2018 16:35:23 +0000 (18:35 +0200)] 
docs: fix "zplugin" typo in Accordion & Tabs events

6 years agofix: close the active Tab when going back to a "tab-less" history state
Nicolas Coden [Sun, 9 Sep 2018 16:33:17 +0000 (18:33 +0200)] 
fix: close the active Tab when going back to a "tab-less" history state

See https://github.com/zurb/foundation-sites/pull/11477#issuecomment-419678146

6 years agorefactor: clean up the Tab initialization
Nicolas Coden [Sun, 9 Sep 2018 16:31:54 +0000 (18:31 +0200)] 
refactor: clean up the Tab initialization

6 years agofeat: add "Tabs._collapse()" to collapse the active tab
Nicolas Coden [Sun, 9 Sep 2018 16:30:21 +0000 (18:30 +0200)] 
feat: add "Tabs._collapse()" to collapse the active tab

6 years agoMerge pull request #11445 from ncoden/chore/tree-shaking
Nicolas Coden [Sat, 8 Sep 2018 21:59:34 +0000 (23:59 +0200)] 
Merge pull request #11445 from ncoden/chore/tree-shaking

chore: improve "tree shaking" support and documentation

6 years agoRevert "chore: add default export as it may be sometimes required for tree-shaking" 11445/head
Nicolas Coden [Sat, 8 Sep 2018 21:16:17 +0000 (23:16 +0200)] 
Revert "chore: add default export as it may be sometimes required for tree-shaking"

This reverts commit 5d9373b3dce67e29769a7afd73598dc609dc7dc1.

6 years agoMerge pull request #11495 from gforcada/patch-1
Nicolas Coden [Fri, 7 Sep 2018 21:55:20 +0000 (23:55 +0200)] 
Merge pull request #11495 from gforcada/patch-1

Fix swipe docs

6 years agoFix swipe docs 11495/head
Gil Forcada Codinachs [Fri, 7 Sep 2018 20:10:48 +0000 (22:10 +0200)] 
Fix swipe docs

See discussion on https://github.com/zurb/foundation-sites/issues/11490

6 years agotest: add OffCanvas tests for openedEnd and closedEnd events 10408/head
Nicolas Coden [Fri, 7 Sep 2018 06:36:45 +0000 (08:36 +0200)] 
test: add OffCanvas tests for openedEnd and closedEnd events

6 years agotest: use "openedEnd" event in OffCanvas tests instead of low-level listenners
Nicolas Coden [Fri, 7 Sep 2018 06:36:22 +0000 (08:36 +0200)] 
test: use "openedEnd" event in OffCanvas tests instead of low-level listenners

6 years agofeat: add the "openedEnd" event to OffCanvas after opening transition
Nicolas Coden [Fri, 7 Sep 2018 06:34:20 +0000 (08:34 +0200)] 
feat: add the "openedEnd" event to OffCanvas after opening transition

6 years agotest: wait for OffCanvas to fully open then close to check for removed classes
Nicolas Coden [Fri, 7 Sep 2018 06:15:40 +0000 (08:15 +0200)] 
test: wait for OffCanvas to fully open then close to check for removed classes

6 years agofix: fix OffCanvas namespace fpr closed/closedEnd events
Nicolas Coden [Fri, 7 Sep 2018 06:14:45 +0000 (08:14 +0200)] 
fix: fix OffCanvas namespace fpr closed/closedEnd events

6 years agorefactor: lint and simplify OffCanvas "sticky" methods
Nicolas Coden [Thu, 6 Sep 2018 22:05:02 +0000 (00:05 +0200)] 
refactor: lint and simplify OffCanvas "sticky" methods

6 years agofix: only stick elements inside the OffCanvas content
Nicolas Coden [Thu, 6 Sep 2018 21:51:03 +0000 (23:51 +0200)] 
fix: only stick elements inside the OffCanvas content

Elements outside of the OffCanvas content are not affected by the "transform" property and should not be sticked.

6 years agodocs: add missing code-block ending characters in OffCanvas doc
Nicolas Coden [Thu, 6 Sep 2018 21:49:59 +0000 (23:49 +0200)] 
docs: add missing code-block ending characters in OffCanvas doc

6 years agoMerge branch 'develop' into SassNinja/feature/offcanvas-fixed-sticky
Nicolas Coden [Wed, 5 Sep 2018 20:06:38 +0000 (22:06 +0200)] 
Merge branch 'develop' into SassNinja/feature/offcanvas-fixed-sticky

6 years agoMerge branch 'develop' into refactor/xy-cell
Nicolas Coden [Tue, 4 Sep 2018 21:43:37 +0000 (23:43 +0200)] 
Merge branch 'develop' into refactor/xy-cell

6 years agochore: update docs styles when SCSS change 11491/head
Nicolas Coden [Tue, 4 Sep 2018 21:09:07 +0000 (23:09 +0200)] 
chore: update docs styles when SCSS change

Documentation styles uses the SCSS mixins/functions, so they must be recompiled when the SCSS change.

Introduced in https://github.com/zurb/foundation-sites/pull/11454

6 years agoMerge pull request #11488 from ncoden/chore/update-dependencies-2018-09-03
Nicolas Coden [Tue, 4 Sep 2018 21:01:06 +0000 (23:01 +0200)] 
Merge pull request #11488 from ncoden/chore/update-dependencies-2018-09-03

chore: update dependencies (2018-09-03)

6 years agochore: update dependencies (2018-09-03) 11488/head
Nicolas Coden [Mon, 3 Sep 2018 21:15:11 +0000 (23:15 +0200)] 
chore: update dependencies (2018-09-03)

Major bump:

| Package                         | From          | To     |
| :------------------------------ | :------------ | :----- |
| gulp-postcss                    | 7.0.0         | 8.0.0  |
| gulp-babel                      | 8.0.0-beta.2  | 8.0.0  |
| @babel/core                     | 7.0.0-beta.54 | 7.0.0  |
| babel-loader                    | 8.0.0-beta.0  | 8.0.2  |
| @babel/preset-env               | 7.0.0-beta.54 | 7.0.0  |
| browserstack-runner             | 0.7.0         | 0.9.0  |

Minor bump:

| Package                         | From          | To     |
| :------------------------------ | :------------ | :----- |
| @commitlint/cli                 | 7.0.0         | 7.1.1  |
| @commitlint/config-conventional | 7.0.1         | 7.1.1  |
| autoprefixer                    | 9.0.1         | 9.1.3  |
| browser-sync                    | 2.24.6        | 2.24.7 |
| gulp-cache-bust                 | 1.3.0         | 1.4.0  |
| gulp-clean-css                  | 3.9.4         | 3.10.0 |
| gulp-prompt                     | 1.0.1         | 1.1.0  |
| gulp-zip                        | 4.1.0         | 4.2.0  |
| inquirer                        | 6.0.0         | 6.2.0  |
| sinon                           | 6.1.4         | 6.1.5  |
| webpack                         | 4.16.2        | 4.17.2 |
| webpack-stream                  | 5.0.0         | 5.1.1  |

6 years agoMerge pull request #11485 from ncoden/fix/tabs-deep-link-custom-target-11484
Nicolas Coden [Mon, 3 Sep 2018 19:56:09 +0000 (21:56 +0200)] 
Merge pull request #11485 from ncoden/fix/tabs-deep-link-custom-target-11484

fix: use data-tabs-target to update history in Tabs deep-linking #11484

6 years agoMerge pull request #11486 from cyChop/develop
Nicolas Coden [Sun, 2 Sep 2018 20:51:07 +0000 (22:51 +0200)] 
Merge pull request #11486 from cyChop/develop

Fix a bug in tab changing

6 years agofix: use a safer selector for targetted tab title in "Tabs.selectTab" 11486/head
Nicolas Coden [Sun, 2 Sep 2018 20:32:25 +0000 (22:32 +0200)] 
fix: use a safer selector for targetted tab title in "Tabs.selectTab"

See https://github.com/zurb/foundation-sites/pull/11486

6 years agoMerge pull request #11487 from palicko/develop
Nicolas Coden [Sun, 2 Sep 2018 20:08:40 +0000 (22:08 +0200)] 
Merge pull request #11487 from palicko/develop

Fix wrong responsive spacing prototype classes

6 years agodocs: improve "tree shaking" documentation to promote named imports
Nicolas Coden [Sun, 2 Sep 2018 19:54:45 +0000 (21:54 +0200)] 
docs: improve "tree shaking" documentation to promote named imports

6 years agochore: remove redundant "pkg.browser" field
Nicolas Coden [Sun, 2 Sep 2018 19:42:27 +0000 (21:42 +0200)] 
chore: remove redundant "pkg.browser" field

According to the specification for `pkg.browser`, there is no reason for us to use this field as the package itself it only for browsers (or any environement with a DOM). Without the field, ESM-compliant transpilers/bundlers will pick `module`, and the others will pick `main`.

https://github.com/defunctzombie/package-browser-field-spec

6 years agoFix wrong responsive spacing classes #11236 11487/head
Pavol Caban [Sun, 2 Sep 2018 19:32:40 +0000 (21:32 +0200)] 
Fix wrong responsive spacing classes #11236

6 years agoFix a bug in tab changing
Cyrille Chopelet [Sat, 1 Sep 2018 13:04:16 +0000 (15:04 +0200)] 
Fix a bug in tab changing

When using deepLink options, the handleTabChange will fail if using a non-standard markup (if there are DOM levels between the `.tabs-title` and the `a`).

This commit fixes precisely that.

6 years agofix: use data-tabs-target to update history in Tabs deep-linking #11484 11485/head
Nicolas Coden [Fri, 31 Aug 2018 21:40:57 +0000 (23:40 +0200)] 
fix: use data-tabs-target to update history in Tabs deep-linking #11484

Closes https://github.com/zurb/foundation-sites/issues/11484

6 years agodocs: remove outdated comments in Accordion related to the initial state
Nicolas Coden [Thu, 30 Aug 2018 22:06:29 +0000 (00:06 +0200)] 
docs: remove outdated comments in Accordion related to the initial state

6 years agorefactor: move "init only" Accordion logic to its own methods
Nicolas Coden [Thu, 30 Aug 2018 22:00:02 +0000 (00:00 +0200)] 
refactor: move "init only" Accordion logic to its own methods

6 years agorefactor: split DOM operations from logics in Accordion
Nicolas Coden [Thu, 30 Aug 2018 21:42:48 +0000 (23:42 +0200)] 
refactor: split DOM operations from logics in Accordion

Split DOM operations from logics in Accordion "up" and "down" methods

6 years agofix: fix initial state for Accordion without any panel active
Nicolas Coden [Wed, 29 Aug 2018 21:57:57 +0000 (23:57 +0200)] 
fix: fix initial state for Accordion without any panel active

When going back in history, the Accordion without any panel active is still considered as in its "initial state".

6 years agofix: return to initial state when reseting hash in Accordion & Tabs #11100
Nicolas Coden [Sun, 26 Aug 2018 21:35:54 +0000 (23:35 +0200)] 
fix: return to initial state when reseting hash in Accordion & Tabs #11100

When deep-linking is enabled and the user goes back in the history up to when no hash is set, display the initially-selected content/tab instead of staying with the content/tab that was selected the first.

Closes https://github.com/zurb/foundation-sites/issues/11100
Replaces https://github.com/zurb/foundation-sites/issues/11101

Co-authored-by: Jamie Chong <jamie@hippocurious.com>
6 years agoMerge pull request #11466 from ncoden/chore/simplify-github-template
Nicolas Coden [Sun, 26 Aug 2018 19:54:14 +0000 (21:54 +0200)] 
Merge pull request #11466 from ncoden/chore/simplify-github-template

chore: simplify GitHub templates

6 years agoMerge pull request #11475 from Harmageddon/patch-1
Nicolas Coden [Sun, 26 Aug 2018 19:52:02 +0000 (21:52 +0200)] 
Merge pull request #11475 from Harmageddon/patch-1

fix: Added missing quotation mark in documentation

6 years agoAdded missing quotation mark. 11475/head
Constantin Romankiewicz [Sun, 26 Aug 2018 16:59:39 +0000 (18:59 +0200)] 
Added missing quotation mark.

6 years agoMerge pull request #11472 from ncoden/fix/xy-grid-offset-zero-margin-11471
Nicolas Coden [Sun, 26 Aug 2018 13:55:36 +0000 (15:55 +0200)] 
Merge pull request #11472 from ncoden/fix/xy-grid-offset-zero-margin-11471

fix: fix offset when gutters are 0 in "xy-cell-offset" #11471

6 years agofix: fix offset calculation in "xy-cell-offset" 11472/head
Nicolas Coden [Sun, 26 Aug 2018 10:24:58 +0000 (12:24 +0200)] 
fix: fix offset calculation in "xy-cell-offset"

6 years agofix: fix generated offset for zero gutters in "xy-cell-offset" #11471
Nicolas Coden [Sat, 25 Aug 2018 21:53:49 +0000 (23:53 +0200)] 
fix: fix generated offset for zero gutters in "xy-cell-offset" #11471

Closes https://github.com/zurb/foundation-sites/issues/11471

6 years agoUse pull request #11469 from ncoden/fix/clear-nest-submenu-classes-11467 for v6.5.0
Nicolas Coden [Sat, 25 Aug 2018 20:34:54 +0000 (22:34 +0200)] 
Use pull request #11469 from ncoden/fix/clear-nest-submenu-classes-11467 for v6.5.0

fcd02bdfc fix: clear submenu item classe in Nest #11467

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11462 from ncoden/fix/reveal-mobile-full-height-10879 for v6.5.0
Nicolas Coden [Sat, 25 Aug 2018 20:34:54 +0000 (22:34 +0200)] 
Use pull request #11462 from ncoden/fix/reveal-mobile-full-height-10879 for v6.5.0

fd0479899 fix: avoid viewport height for fullscreen Reveal as it may be incorrect #10879

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11454 from ncoden/fix/split-gulp-tasks-11452 for v6.5.0
Nicolas Coden [Sat, 25 Aug 2018 20:34:54 +0000 (22:34 +0200)] 
Use pull request #11454 from ncoden/fix/split-gulp-tasks-11452 for v6.5.0

6c45b451e fix: remove broken Sass linting from Sass compilation task and move it to build task
80c6def1f refactor: split the docs build task to `docs:pages` and `docs:search`
6b12883d6 refactor: move the customizer ZIPing to `customizer:zip` and `customizer:clean`

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11464 from ncoden/docs/remove-vertical-block-grid-11463 for v6.5.0
Nicolas Coden [Sat, 25 Aug 2018 20:34:53 +0000 (22:34 +0200)] 
Use pull request #11464 from ncoden/docs/remove-vertical-block-grid-11463 for v6.5.0

2bb3df02d docs: remove mentions of unsupported Y Grid from block grids section

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11458 from SassNinja/docs/foundation-cli for v6.5.0
SassNinja [Sat, 25 Aug 2018 20:34:53 +0000 (22:34 +0200)] 
Use pull request #11458 from SassNinja/docs/foundation-cli for v6.5.0

be886fb2f add more foundation-cli install instructions for windows user

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11450 from DanielRuf/fix/correct-selector-11447 for v6.5.0
Daniel Ruf [Sat, 25 Aug 2018 20:33:43 +0000 (22:33 +0200)] 
Use pull request #11450 from DanielRuf/fix/correct-selector-11447 for v6.5.0

b5452e883 fix: use correct selector, fixes #11447

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11444 from aorinevo/I-11443_develop_AN_gulp_fix for v6.5.0
Aori Nevo [Sat, 25 Aug 2018 20:33:42 +0000 (22:33 +0200)] 
Use pull request #11444 from aorinevo/I-11443_develop_AN_gulp_fix for v6.5.0

d0f405400 fix: i11443 gulp watch
c90c048cc fix: prevent "test:reload" task to block future reloads

Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11448 from melek/patch-1 for v6.5.0
Lionel [Sat, 25 Aug 2018 20:33:42 +0000 (22:33 +0200)] 
Use pull request #11448 from melek/patch-1 for v6.5.0

47264afbf Update installation.md
9e5f5e228 docs: fix Foundation 6 CLI uninstallation note phrasing

Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11435 from ncoden/docs/motion-ui-components for v6.5.0
Nicolas Coden [Sat, 25 Aug 2018 20:33:42 +0000 (22:33 +0200)] 
Use pull request #11435 from ncoden/docs/motion-ui-components for v6.5.0

b08a56da4 docs: move Motion UI Toggler example to its own section
bd4bf11d2 docs: add a simpler example in Motion UI docs header

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11433 from ncoden/fix/dropdown-menu-top-level-items-11412 for v6.5.0
Nicolas Coden [Sat, 25 Aug 2018 20:33:41 +0000 (22:33 +0200)] 
Use pull request #11433 from ncoden/fix/dropdown-menu-top-level-items-11412 for v6.5.0

6a0e3240b fix: fix Dropdown Menu top level item properties #11412

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11425 from ncoden/fix/drilldown-submenu-height-11416 for v6.5.0
Nicolas Coden [Sat, 25 Aug 2018 20:33:41 +0000 (22:33 +0200)] 
Use pull request #11425 from ncoden/fix/drilldown-submenu-height-11416 for v6.5.0

c7ce8d5b9 fix: set the Drilldown height for on the currently opened (sub)menu #11416
43c1fac65 test: add unit tests for Drilldown resizing on toggling
7f7dfd83a test: check the Drilldrown wrapper height instead of the element height
90c4e45f8 fix: set a default for the current menu in Drilldown before it is used
1db6a1f2a test: add unit test for the Drilldown height when reopened from a submenu #11416
d4617ac08 clean: remove infinite timeout used for development in Drilldown tests

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11419 from ncoden/chore/update-dependencies-2018-07-26 for v6.5.0
Nicolas Coden [Sat, 25 Aug 2018 20:33:40 +0000 (22:33 +0200)] 
Use pull request #11419 from ncoden/chore/update-dependencies-2018-07-26 for v6.5.0

d70627374 chore: update dependencies (2018-07-26)
4ed0ec2a9 chore: update lockfiles (2018-07-26)

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11411 from arloduff/fix/check-for-null-related-target for v6.5.0
Arlo Duff [Sat, 25 Aug 2018 20:33:39 +0000 (22:33 +0200)] 
Use pull request #11411 from arloduff/fix/check-for-null-related-target for v6.5.0

ac88dac72 fix: resolve dropdown menu disappearing for #11410
ae8fa2def fix: move relatedTarget null check to setTimeout for #11410
a25180c3d style: improve dropdown hiding event readability in dropdownMenu
e46ddd1cc docs: improve description of #11410 bug fix in dropdownMenu
ebc4be784 docs: fix typo in bug description in dropdownMenu

Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11409 from veselinn/fix/slider-handle-negative-data-start for v6.5.0
Veselin Nikolov [Sat, 25 Aug 2018 20:33:39 +0000 (22:33 +0200)] 
Use pull request #11409 from veselinn/fix/slider-handle-negative-data-start for v6.5.0

81fc284e9 fix: slider handle negative data-start values
da0b014de fix: remove unnecessary if from slider
9851a17ff test: add tests for Slider._adjustValue

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11393 from DanielRuf/fix/matchmedia-polyfill-window-fix-ie11 for...
Daniel Ruf [Sat, 25 Aug 2018 20:33:38 +0000 (22:33 +0200)] 
Use pull request #11393 from DanielRuf/fix/matchmedia-polyfill-window-fix-ie11 for v6.5.0

e7554d60d fix: set matchMedia on window to fix issue on IE11, fixes #11358
1a36a44e7 chore: update MatchMedia polyfill to v0.3.1

Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11397 from ncoden/fix/xy-grid-responsive-modifiers-reset-10891...
Nicolas Coden [Sat, 25 Aug 2018 20:33:38 +0000 (22:33 +0200)] 
Use pull request #11397 from ncoden/fix/xy-grid-responsive-modifiers-reset-10891-2 for v6.5.0

7e34dc3b5 perf: factorize XY grid responsive modifiers
21be51d21 fix: add missing flex reset in XY Grid responsive vertical cell widths

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoUse pull request #11394 from ncoden/chore/dist-js-plugins-sourcemaps for v6.5.0
Nicolas Coden [Sat, 25 Aug 2018 20:33:37 +0000 (22:33 +0200)] 
Use pull request #11394 from ncoden/chore/dist-js-plugins-sourcemaps for v6.5.0

09a46c612 chore: update sourcemaps of distributed JS plugins

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
6 years agoMerge branch 'master-v6.5' into develop-v6.5
Nicolas Coden [Sat, 25 Aug 2018 17:27:52 +0000 (19:27 +0200)] 
Merge branch 'master-v6.5' into develop-v6.5

6 years agoMerge pull request #11469 from ncoden/fix/clear-nest-submenu-classes-11467
Nicolas Coden [Fri, 24 Aug 2018 21:22:56 +0000 (23:22 +0200)] 
Merge pull request #11469 from ncoden/fix/clear-nest-submenu-classes-11467

fix: clean submenu items classes in Nest #11467

6 years agoMerge pull request #11462 from ncoden/fix/reveal-mobile-full-height-10879
Nicolas Coden [Thu, 23 Aug 2018 21:54:52 +0000 (23:54 +0200)] 
Merge pull request #11462 from ncoden/fix/reveal-mobile-full-height-10879

fix: avoid viewport height for fullscreen Reveal as it may be incorrect #10879

6 years agodocs: make "direct import" for tree shaking sounds less imperative
Nicolas Coden [Thu, 23 Aug 2018 21:47:40 +0000 (23:47 +0200)] 
docs: make "direct import" for tree shaking sounds less imperative

6 years agochore: add missing "sideEffects" flag to ensure tree shaking with webpack
Nicolas Coden [Thu, 23 Aug 2018 21:46:09 +0000 (23:46 +0200)] 
chore: add missing "sideEffects" flag to ensure tree shaking with webpack

6 years agoMerge pull request #11454 from ncoden/fix/split-gulp-tasks-11452
Nicolas Coden [Thu, 23 Aug 2018 21:38:26 +0000 (23:38 +0200)] 
Merge pull request #11454 from ncoden/fix/split-gulp-tasks-11452

chore: use split gulp tasks instead of the unsuitable "finish" event #11452

7 years agofix: clear submenu item classe in Nest #11467 11469/head
Nicolas Coden [Wed, 22 Aug 2018 20:05:11 +0000 (22:05 +0200)] 
fix: clear submenu item classe in Nest #11467

Closes https://github.com/zurb/foundation-sites/issues/11467

7 years agoMerge pull request #11465 from ncoden/fix/avoid-stop-propagation-11457
Nicolas Coden [Tue, 21 Aug 2018 21:07:00 +0000 (23:07 +0200)] 
Merge pull request #11465 from ncoden/fix/avoid-stop-propagation-11457

fix: avoid stopping propagation when not necessary #11457

7 years agochore: simplify GitHub issue templates 11466/head
Nicolas Coden [Mon, 20 Aug 2018 22:49:52 +0000 (00:49 +0200)] 
chore: simplify GitHub issue templates

7 years agochore: simplify the GitHub pull request template
Nicolas Coden [Mon, 20 Aug 2018 21:50:20 +0000 (23:50 +0200)] 
chore: simplify the GitHub pull request template

7 years agofix: fix DropdownMenu body handler check to ignore the element itself 11465/head
Nicolas Coden [Mon, 20 Aug 2018 20:54:18 +0000 (22:54 +0200)] 
fix: fix DropdownMenu body handler check to ignore the element itself

> `andSelf()` is deprecated and should be replaced with `addBack()`
> -- @SassNinja

Also, `andSelf` cannot be used that way. This commit replace it with the opposite approach: checking if the target is the child of the element or the element itself using `closest()`.

7 years agoMerge pull request #11464 from ncoden/docs/remove-vertical-block-grid-11463
Nicolas Coden [Mon, 20 Aug 2018 19:27:51 +0000 (21:27 +0200)] 
Merge pull request #11464 from ncoden/docs/remove-vertical-block-grid-11463

docs: remove mentions of unsupported Y Grid from block grids section

7 years agoMerge pull request #11458 from SassNinja/docs/foundation-cli
Nicolas Coden [Mon, 20 Aug 2018 13:30:18 +0000 (15:30 +0200)] 
Merge pull request #11458 from SassNinja/docs/foundation-cli

foundation-cli docs for windows users

7 years agofix: avoid stopping event propagation when not necessary
Nicolas Coden [Sun, 19 Aug 2018 21:50:03 +0000 (23:50 +0200)] 
fix: avoid stopping event propagation when not necessary

Stopping the event propagation prevent the user to watch for the event at an higher level. If it was needed to prevent a duplicate behavior in a component, others methods should be used like debouncing the event.

Changes:
- Remove `stopPropagation` and `stopImmediatePropagation` from everywhere we do not want to cancel the event (AccordionMenu, Drilldown, DropdownMenu, Tabs, Tooltip).
- Update `DropdownMenu._removeBodyHandler` to also ignore click events on the element itself.

Others changes:
- Clean up `DropdownMenu._events` a bit.
- Add explainaitions where `stopPropagation` is still used (Triggers).

See https://github.com/zurb/foundation-sites/issues/11457

7 years agofix: prevent double Keyboard events handling without stopping propagation
Nicolas Coden [Sun, 19 Aug 2018 21:41:23 +0000 (23:41 +0200)] 
fix: prevent double Keyboard events handling without stopping propagation

Stopping the event propagation prevent the user to watch for the event at an higher level. If it was needed to prevent a duplicate behavior in a component, others methods should be used like debouncing the event.

Changes:
- Save and check for `event.zfIsKeyHandled` in Keyboard utility to prevent to handle twice the same event in different components.
- Remove `event.stopPropagation` from components' keyboard handlers (Accordion, DropdownMenu, OffCanvas and Tabs).

See https://github.com/zurb/foundation-sites/issues/11457

7 years agodocs: add docs about "mobile scroll" bug #9707 in OffCanvas
Nicolas Coden [Sun, 19 Aug 2018 21:33:22 +0000 (23:33 +0200)] 
docs: add docs about "mobile scroll" bug #9707 in OffCanvas

Add documentation for the OffCanvas private methods `_recordScrollable` and `_stopScrollPropagation` to explicitely justify the need for `stopPropagation`.

See #9707

7 years agodocs: remove mentions of unsupported Y Grid from block grids section 11464/head
Nicolas Coden [Sun, 19 Aug 2018 15:43:46 +0000 (17:43 +0200)] 
docs: remove mentions of unsupported Y Grid from block grids section

Block Grid is not supported for Y Grid and will not be implemented. It would add too much code for a feature that is will not be used in most projects.

Plus, Block Grid classes are not namespaced for the horizontal or vertical grid. Adding block grid classes for the vertical grid would lead of inconstencies or backward incompatibility and increased specificity.

Closes https://github.com/zurb/foundation-sites/issues/11463

7 years agoMerge pull request #11434 from ncoden/feat/orbit-slide-active-state-attribute
Nicolas Coden [Sat, 18 Aug 2018 21:59:36 +0000 (23:59 +0200)] 
Merge pull request #11434 from ncoden/feat/orbit-slide-active-state-attribute

feat: add Orbit element "data-slide-active-label" to target the bullet span to move

7 years agofix: avoid viewport height for fullscreen Reveal as it may be incorrect #10879 11462/head
Nicolas Coden [Sat, 18 Aug 2018 21:45:12 +0000 (23:45 +0200)] 
fix: avoid viewport height for fullscreen Reveal as it may be incorrect #10879

The CSS viewport is the larger possible view height and does not change with the visible area height. This is an intended behavior for optimization reason. See this article:

See: https://nicolas-hoizey.com/2015/02/viewport-height-is-taller-than-the-visible-part-of-the-document-in-some-mobile-browsers.html
See: https://github.com/zurb/foundation-sites/issues/10879#issuecomment-414087274

Closes https://github.com/zurb/foundation-sites/issues/10879

7 years agoMerge pull request #11461 from DanielRuf/fix/interchange-remove-extraneous-regular...
Nicolas Coden [Fri, 17 Aug 2018 20:33:01 +0000 (22:33 +0200)] 
Merge pull request #11461 from DanielRuf/fix/interchange-remove-extraneous-regular-expression-11460

fix: remove extraneous regular expression in interchange, closes #11460

7 years agofix: remove extraneous regular expression in interchange, closes #11460 11461/head
Daniel Ruf [Fri, 17 Aug 2018 19:40:36 +0000 (21:40 +0200)] 
fix: remove extraneous regular expression in interchange, closes #11460

7 years agoadd more foundation-cli install instructions for windows user 11458/head
SassNinja [Fri, 17 Aug 2018 10:26:24 +0000 (12:26 +0200)] 
add more foundation-cli install instructions for windows user

7 years agoMerge pull request #10884 from ncoden/feat/interchange-type-option-10883
Nicolas Coden [Thu, 16 Aug 2018 21:37:06 +0000 (23:37 +0200)] 
Merge pull request #10884 from ncoden/feat/interchange-type-option-10883

feat: add "type" option to force interchange replacement method #10883

7 years agoMerge branch 'develop' into feat/interchange-type-option-10883 10884/head
Nicolas Coden [Thu, 16 Aug 2018 21:25:47 +0000 (23:25 +0200)] 
Merge branch 'develop' into feat/interchange-type-option-10883

7 years agofeat: add support for "JPEG" picture in Interchange
Nicolas Coden [Thu, 16 Aug 2018 21:25:36 +0000 (23:25 +0200)] 
feat: add support for "JPEG" picture in Interchange

7 years agodocs: fix typos in Interchange
Nicolas Coden [Thu, 16 Aug 2018 21:24:28 +0000 (23:24 +0200)] 
docs: fix typos in Interchange

7 years agoMerge pull request #11450 from DanielRuf/fix/correct-selector-11447
Nicolas Coden [Wed, 15 Aug 2018 21:52:16 +0000 (23:52 +0200)] 
Merge pull request #11450 from DanielRuf/fix/correct-selector-11447

fix: use correct selector, fixes #11447

7 years agorefactor: move the customizer ZIPing to `customizer:zip` and `customizer:clean` 11454/head
Nicolas Coden [Wed, 15 Aug 2018 20:42:05 +0000 (22:42 +0200)] 
refactor: move the customizer ZIPing to `customizer:zip` and `customizer:clean`

The `finish` gulp event is an stream internal event and is not suitable to chain tasks.

Changes:
- Move the custom ZIP file generation to the `customizer:zip` task
- Move the cleaning of the customizer build directory to `customizer:clean` task

7 years agorefactor: split the docs build task to `docs:pages` and `docs:search`
Nicolas Coden [Wed, 15 Aug 2018 20:39:26 +0000 (22:39 +0200)] 
refactor: split the docs build task to `docs:pages` and `docs:search`

The `finish` gulp event is an stream internal event and is not suitable to chain tasks.

Changes:
- Move pages building to the `docs:pages` and `docs:pages:all` subtasks
- Move search entries building to the `docs:search` subtask

7 years agofix: remove broken Sass linting from Sass compilation task and move it to build task
Nicolas Coden [Wed, 15 Aug 2018 20:35:39 +0000 (22:35 +0200)] 
fix: remove broken Sass linting from Sass compilation task and move it to build task

Changes:
- Remove broken Sass linting from the `sass:foundation` task. The `finish` gulp event is an stream internal event and is not suitable to chain tasks.
- Add `lint:graceful`, `lint:graceful:sass` and `lint:graceful:javascript` to check for linting errors without throwing errors and breaking the chain of tasks.
- Call `lint:graceful` on the build task. For now, there is too much linting issues to display them at each Sass/Javascript compilation.

7 years agofix: use correct selector, fixes #11447 11450/head
Daniel Ruf [Tue, 14 Aug 2018 07:57:08 +0000 (09:57 +0200)] 
fix: use correct selector, fixes #11447

7 years agoMerge pull request #11444 from aorinevo/I-11443_develop_AN_gulp_fix
Nicolas Coden [Mon, 13 Aug 2018 21:28:25 +0000 (23:28 +0200)] 
Merge pull request #11444 from aorinevo/I-11443_develop_AN_gulp_fix

fix: i11443 gulp watch

7 years agoMerge pull request #11448 from melek/patch-1
Nicolas Coden [Mon, 13 Aug 2018 21:01:19 +0000 (23:01 +0200)] 
Merge pull request #11448 from melek/patch-1

docs: Fix sentence fragment in installation.md

7 years agofix: prevent "test:reload" task to block future reloads 11444/head
Nicolas Coden [Mon, 13 Aug 2018 20:55:59 +0000 (22:55 +0200)] 
fix: prevent "test:reload" task to block future reloads

7 years agodocs: fix Foundation 6 CLI uninstallation note phrasing 11448/head
Nicolas Coden [Mon, 13 Aug 2018 20:48:06 +0000 (22:48 +0200)] 
docs: fix Foundation 6 CLI uninstallation note phrasing

7 years agochore: remove unrecommended "grouped" default exports
Nicolas Coden [Mon, 13 Aug 2018 20:30:56 +0000 (22:30 +0200)] 
chore: remove unrecommended "grouped" default exports

Default exports should only be used for "primary" objects or classes, not for libraries for which individual named exports should be prefered.

7 years agoUpdate installation.md
Lionel [Mon, 13 Aug 2018 19:33:37 +0000 (12:33 -0700)] 
Update installation.md