]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
9 months agoAdd fr_tolower to smash strings to lowercase
Arran Cudbard-Bell [Sun, 3 Nov 2024 05:39:21 +0000 (07:39 +0200)] 
Add fr_tolower to smash strings to lowercase

9 months agoSupport adding non-nested attributes to dynamic clients
Arran Cudbard-Bell [Fri, 1 Nov 2024 21:08:20 +0000 (23:08 +0200)] 
Support adding non-nested attributes to dynamic clients

We could support nested attributes are create nested attributes, not its not necessary for now.

9 months agoDuplicate cookie is not an error
Nick Porter [Thu, 31 Oct 2024 19:27:57 +0000 (19:27 +0000)] 
Duplicate cookie is not an error

sync_new_cookie returns -1 for error and -2 for duplicate

9 months agoadd the worker directly to the network thread
Alan T. DeKok [Wed, 30 Oct 2024 13:44:36 +0000 (09:44 -0400)] 
add the worker directly to the network thread

@todo - perhaps assert that we don't mix "same-thread" workers
with "different-thread" workers?

9 months agoSearch protocol flags first
Arran Cudbard-Bell [Tue, 29 Oct 2024 18:25:41 +0000 (19:25 +0100)] 
Search protocol flags first

9 months agopull "raw" out as separate flag for unknown attributes
Alan T. DeKok [Tue, 29 Oct 2024 13:48:32 +0000 (09:48 -0400)] 
pull "raw" out as separate flag for unknown attributes

and update for key fields

9 months agoremove debugging text
Alan T. DeKok [Tue, 29 Oct 2024 11:57:31 +0000 (07:57 -0400)] 
remove debugging text

9 months agoa bit better decoding of structs with raw fields
Alan T. DeKok [Mon, 28 Oct 2024 23:34:28 +0000 (19:34 -0400)] 
a bit better decoding of structs with raw fields

9 months agofr_struct_from_network() always creates nested attributes
Alan T. DeKok [Mon, 28 Oct 2024 23:27:52 +0000 (19:27 -0400)] 
fr_struct_from_network() always creates nested attributes

9 months agoFix protocol-specific flags docs
Arran Cudbard-Bell [Tue, 29 Oct 2024 12:04:12 +0000 (13:04 +0100)] 
Fix protocol-specific flags docs

9 months ago"to" is not const
Arran Cudbard-Bell [Tue, 29 Oct 2024 12:00:36 +0000 (13:00 +0100)] 
"to" is not const

9 months agoThe default type for unknown attributes is octets...
Arran Cudbard-Bell [Tue, 29 Oct 2024 11:37:48 +0000 (12:37 +0100)] 
The default type for unknown attributes is octets...

9 months agoAdd support for custom protocol-specific flag copy functions and comparators
Arran Cudbard-Bell [Tue, 29 Oct 2024 11:22:58 +0000 (12:22 +0100)] 
Add support for custom protocol-specific flag copy functions and comparators

9 months agoFix additional uses of subtype in the dns encoder and decoder
Arran Cudbard-Bell [Tue, 29 Oct 2024 11:22:32 +0000 (12:22 +0100)] 
Fix additional uses of subtype in the dns encoder and decoder

9 months agoMove flags into their own struct within fr_dict_protocol_t
Arran Cudbard-Bell [Tue, 29 Oct 2024 11:20:08 +0000 (12:20 +0100)] 
Move flags into their own struct within fr_dict_protocol_t

9 months agoClear errors
Arran Cudbard-Bell [Tue, 29 Oct 2024 09:31:06 +0000 (10:31 +0100)] 
Clear errors

9 months agodon't depend on file which no longer exists
Alan T. DeKok [Mon, 28 Oct 2024 19:19:31 +0000 (15:19 -0400)] 
don't depend on file which no longer exists

it prevents the unit tests from running

9 months agono need to copy the entire hierarchy
Alan T. DeKok [Mon, 28 Oct 2024 19:09:14 +0000 (15:09 -0400)] 
no need to copy the entire hierarchy

9 months agoCorrect fixup of TLS session cache mode
Nick Porter [Mon, 28 Oct 2024 20:14:08 +0000 (20:14 +0000)] 
Correct fixup of TLS session cache mode

9 months agorename fr_dict_unknown... to fr_dict_attr_unknown...
Alan T. DeKok [Mon, 28 Oct 2024 18:28:07 +0000 (14:28 -0400)] 
rename fr_dict_unknown... to fr_dict_attr_unknown...

for API consistency

9 months agomove fr_dict_unknown_attr_afrom_num() to common function
Alan T. DeKok [Mon, 28 Oct 2024 18:11:57 +0000 (14:11 -0400)] 
move fr_dict_unknown_attr_afrom_num() to common function

9 months agomove r_dict_unknown_vendor_afrom_num() to common function
Alan T. DeKok [Mon, 28 Oct 2024 18:07:57 +0000 (14:07 -0400)] 
move r_dict_unknown_vendor_afrom_num() to common function

9 months agoda_p is used
Alan T. DeKok [Mon, 28 Oct 2024 18:07:36 +0000 (14:07 -0400)] 
da_p is used

9 months agorename unknown_tlv_afrom_num() to unknown_typed_afrom_num()
Alan T. DeKok [Mon, 28 Oct 2024 17:06:49 +0000 (13:06 -0400)] 
rename unknown_tlv_afrom_num() to unknown_typed_afrom_num()

in preparation for allowing unknown attributes with known types
in the DER decoder.

10 months agoRemove subtype table
Arran Cudbard-Bell [Fri, 25 Oct 2024 05:45:11 +0000 (23:45 -0600)] 
Remove subtype table

10 months agoSwitch DNS to using custom flag parsers
Arran Cudbard-Bell [Fri, 25 Oct 2024 05:42:49 +0000 (23:42 -0600)] 
Switch DNS to using custom flag parsers

10 months agoSwitch DHCPv6 to using custom flag parsers
Arran Cudbard-Bell [Fri, 25 Oct 2024 05:20:36 +0000 (23:20 -0600)] 
Switch DHCPv6 to using custom flag parsers

10 months agoSwitch DHCPv4 to using custom flag parsers
Arran Cudbard-Bell [Fri, 25 Oct 2024 05:03:32 +0000 (23:03 -0600)] 
Switch DHCPv4 to using custom flag parsers

10 months agoSwitch EAP-AKA-SIM to using custom flag parsers
Arran Cudbard-Bell [Fri, 25 Oct 2024 03:53:11 +0000 (21:53 -0600)] 
Switch EAP-AKA-SIM to using custom flag parsers

10 months agoRefactor protocol specific attribute validation functions
Arran Cudbard-Bell [Fri, 25 Oct 2024 03:06:57 +0000 (21:06 -0600)] 
Refactor protocol specific attribute validation functions

Switch RADIUS to using custom flags parsers

10 months agoRead custom dictionary _AFTER_ bootstrap has completed
Arran Cudbard-Bell [Thu, 24 Oct 2024 23:03:33 +0000 (17:03 -0600)] 
Read custom dictionary _AFTER_ bootstrap has completed

10 months agoAllow certain structural attirbutes to contain duplicates
Arran Cudbard-Bell [Thu, 24 Oct 2024 23:02:44 +0000 (17:02 -0600)] 
Allow certain structural attirbutes to contain duplicates

10 months agoAdd comparator for dictionary attributes based on their contents
Arran Cudbard-Bell [Thu, 24 Oct 2024 23:00:50 +0000 (17:00 -0600)] 
Add comparator for dictionary attributes based on their contents

10 months agoRemove unused code
Arran Cudbard-Bell [Thu, 24 Oct 2024 23:00:29 +0000 (17:00 -0600)] 
Remove unused code

10 months agoDon't load the RADIUS dictionary in the xlat library
Arran Cudbard-Bell [Thu, 24 Oct 2024 23:00:10 +0000 (17:00 -0600)] 
Don't load the RADIUS dictionary in the xlat library

10 months agoDon't load the RADIUS dictionary in our TLS library
Arran Cudbard-Bell [Thu, 24 Oct 2024 22:59:49 +0000 (16:59 -0600)] 
Don't load the RADIUS dictionary in our TLS library

10 months agoRemove the explicit checks for flags values
Arran Cudbard-Bell [Wed, 23 Oct 2024 17:31:40 +0000 (11:31 -0600)] 
Remove the explicit checks for flags values

10 months agoAllow "needs_value" to be set for flag parsing so that flag parsing functions don...
Arran Cudbard-Bell [Wed, 23 Oct 2024 17:30:48 +0000 (11:30 -0600)] 
Allow "needs_value" to be set for flag parsing so that flag parsing functions don't need to explicitly check

10 months agoWe now just use aliases so this is no longer needed
Arran Cudbard-Bell [Wed, 23 Oct 2024 17:01:27 +0000 (11:01 -0600)] 
We now just use aliases so this is no longer needed

10 months agoldap: Check for the presence of cache_da
Arran Cudbard-Bell [Wed, 23 Oct 2024 16:47:00 +0000 (10:47 -0600)] 
ldap: Check for the presence of cache_da

10 months agoFix clang scan errors
Arran Cudbard-Bell [Wed, 23 Oct 2024 06:27:06 +0000 (00:27 -0600)] 
Fix clang scan errors

10 months agoRework flag, ref, and alias parsing
Arran Cudbard-Bell [Wed, 23 Oct 2024 06:12:54 +0000 (00:12 -0600)] 
Rework flag, ref, and alias parsing

Move duplicates to aliases, and disallow duplicate attribute names and numbers

10 months agoBreak up attribute initialisation into phases
Arran Cudbard-Bell [Wed, 23 Oct 2024 06:10:03 +0000 (00:10 -0600)] 
Break up attribute initialisation into phases

10 months agofr_dict_attr_by_name_substr sets its own errors
Arran Cudbard-Bell [Wed, 23 Oct 2024 06:08:43 +0000 (00:08 -0600)] 
fr_dict_attr_by_name_substr sets its own errors

10 months agoCheck we didn't run out of parents
Arran Cudbard-Bell [Wed, 23 Oct 2024 06:08:17 +0000 (00:08 -0600)] 
Check we didn't run out of parents

10 months agoAdd fields to store attribute location
Arran Cudbard-Bell [Wed, 23 Oct 2024 06:08:00 +0000 (00:08 -0600)] 
Add fields to store attribute location

10 months agoRework protocol flag types
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:58:46 +0000 (23:58 -0600)] 
Rework protocol flag types

10 months agoCan't produce errors using name beause it might not be set yet
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:57:12 +0000 (23:57 -0600)] 
Can't produce errors using name beause it might not be set yet

10 months agoFormatting
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:54:33 +0000 (23:54 -0600)] 
Formatting

10 months agoUse "namespace" consistently
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:54:01 +0000 (23:54 -0600)] 
Use "namespace" consistently

10 months agoAdd utility functions for applying alias fixups
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:37:35 +0000 (23:37 -0600)] 
Add utility functions for applying alias fixups

10 months agoExplicitly mark up attributes as name only instead of using magic numbers
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:30:52 +0000 (23:30 -0600)] 
Explicitly mark up attributes as name only instead of using magic numbers

10 months agoAlias the "Compatible" vendor to cisco.vpn5000 to avoid conflicts
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:28:24 +0000 (23:28 -0600)] 
Alias the "Compatible" vendor to cisco.vpn5000 to avoid conflicts

10 months agoWe don't need the length passed to dict_fixup_clone
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:18:53 +0000 (23:18 -0600)] 
We don't need the length passed to dict_fixup_clone

10 months agoRemove double declaration of KDF
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:16:40 +0000 (23:16 -0600)] 
Remove double declaration of KDF

10 months agoHave the tests load their own custom dictionaries
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:13:08 +0000 (23:13 -0600)] 
Have the tests load their own custom dictionaries

10 months agoFormatting and minor fixups in unit_test_attribute
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:07:45 +0000 (23:07 -0600)] 
Formatting and minor fixups in unit_test_attribute

10 months agoFix obvious, yet hidden, numbering error in dictionary.h3c
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:04:51 +0000 (23:04 -0600)] 
Fix obvious, yet hidden, numbering error in dictionary.h3c

10 months agoAlias Vendor-Discrimination-Str to Ethernet-Interface... they're both octets types
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:03:37 +0000 (23:03 -0600)] 
Alias Vendor-Discrimination-Str to Ethernet-Interface... they're both octets types

10 months agoFix obvious error in Site-Specific numbered attributes
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:03:02 +0000 (23:03 -0600)] 
Fix obvious error in Site-Specific numbered attributes

...which was hidden previously by the fact we allowed numbering conflicts

10 months agoFor why not can sentence sense make
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:01:20 +0000 (23:01 -0600)] 
For why not can sentence sense make

10 months agoWS
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:00:19 +0000 (23:00 -0600)] 
WS

10 months agointernal encoder: ACTUALLY skip name only attributes, instead of just infinitely...
Arran Cudbard-Bell [Wed, 23 Oct 2024 05:00:11 +0000 (23:00 -0600)] 
internal encoder: ACTUALLY skip name only attributes, instead of just infinitely looping

10 months agoIf the input arguments were invalid... error out, don't just fail silently
Arran Cudbard-Bell [Wed, 23 Oct 2024 04:55:36 +0000 (22:55 -0600)] 
If the input arguments were invalid... error out, don't just fail silently

10 months agoeap-aka: Use enumv values from KDF instead of definitions
Arran Cudbard-Bell [Sun, 20 Oct 2024 02:42:40 +0000 (20:42 -0600)] 
eap-aka: Use enumv values from KDF instead of definitions

10 months agotimeouts are perhaps not quite errors
Alan T. DeKok [Thu, 24 Oct 2024 20:24:00 +0000 (16:24 -0400)] 
timeouts are perhaps not quite errors

10 months agoMRC of 1 is really MRD
Alan T. DeKok [Thu, 24 Oct 2024 20:23:39 +0000 (16:23 -0400)] 
MRC of 1 is really MRD

i.e. a simple duration, and not a repeated count

10 months agoBetter handling of SQL rcodes in xlats
Nick Porter [Thu, 24 Oct 2024 07:59:40 +0000 (08:59 +0100)] 
Better handling of SQL rcodes in xlats

If RLM_SQL_ALT_QUERY is treated as an error, then redundant SQL xlats
will try the same query again on each database host (with the same
result).

To handle switching to a different query if an INSERT fails due to key
contraints, then the return value of the xlat, which is the number of
affected rows should be checked instead.

10 months agoNo data returned is not a failure
Nick Porter [Wed, 23 Oct 2024 08:55:59 +0000 (09:55 +0100)] 
No data returned is not a failure

10 months agoUpdate MS SQL default schema
Nick Porter [Wed, 23 Oct 2024 08:32:47 +0000 (09:32 +0100)] 
Update MS SQL default schema

When using FreeTDS driver, `char` fields are returned with trailing
spaces, which causes "=" in the [op] field to become "= " - which fails
to parse.
Using `varchar` ensures only the real data length is returned.

10 months agoAlign rlm_sql_freetds NULL behaviour with other drivers
Nick Porter [Tue, 22 Oct 2024 16:54:06 +0000 (17:54 +0100)] 
Align rlm_sql_freetds NULL behaviour with other drivers

10 months agoRemove unused function
Nick Porter [Tue, 22 Oct 2024 16:53:11 +0000 (17:53 +0100)] 
Remove unused function

10 months agoFreeTDS doesn't return the number of rows from a SELECT
Nick Porter [Tue, 22 Oct 2024 16:28:41 +0000 (17:28 +0100)] 
FreeTDS doesn't return the number of rows from a SELECT

10 months agoUpdate rlm_sql_freetds to use trunk connections
Nick Porter [Tue, 22 Oct 2024 14:09:37 +0000 (15:09 +0100)] 
Update rlm_sql_freetds to use trunk connections

Unfortunately FreeTDS doesn't have the Async support that the Sybase
client library does.

10 months agoRemove needless function
Nick Porter [Tue, 22 Oct 2024 10:26:55 +0000 (11:26 +0100)] 
Remove needless function

10 months agoAdd basic test of redundant SQL modules
Nick Porter [Tue, 22 Oct 2024 08:44:29 +0000 (09:44 +0100)] 
Add basic test of redundant SQL modules

10 months agoClosed SQL connections can't be used for escaping
Nick Porter [Tue, 22 Oct 2024 08:30:17 +0000 (09:30 +0100)] 
Closed SQL connections can't be used for escaping

The handle gets freed when the connection is closed

10 months agoSet return type for escape functions to ssize_t
Nick Porter [Tue, 22 Oct 2024 08:15:08 +0000 (09:15 +0100)] 
Set return type for escape functions to ssize_t

So failures can be reported back

10 months agoMove tests to be used by all SQL flavours
Nick Porter [Tue, 22 Oct 2024 07:10:13 +0000 (08:10 +0100)] 
Move tests to be used by all SQL flavours

10 months agoSet safe_for child xlats inside a redundant xlat
Nick Porter [Tue, 22 Oct 2024 06:36:09 +0000 (07:36 +0100)] 
Set safe_for child xlats inside a redundant xlat

10 months agoCorrect comparison for end of retry period
Nick Porter [Mon, 21 Oct 2024 18:37:30 +0000 (19:37 +0100)] 
Correct comparison for end of retry period

10 months agoRevert "Don't load the RADIUS dictionary in the xlat code"
Nick Porter [Mon, 21 Oct 2024 16:44:49 +0000 (17:44 +0100)] 
Revert "Don't load the RADIUS dictionary in the xlat code"

This reverts commit 6cf9cd8db3a700b1ceb056cc14a0d03201966ed8.

Breaks CI tests of foreign protocol decoding

10 months agoUse mod_accounting in send Accounting-Response
Nick Porter [Mon, 21 Oct 2024 15:16:27 +0000 (16:16 +0100)] 
Use mod_accounting in send Accounting-Response

There's very little point in logging accouning responses in detail
files, and the sample config calls "detail" in the send
Accounting-Response section.

10 months agoAdd test of NULL SQL value handling
Nick Porter [Mon, 21 Oct 2024 14:05:03 +0000 (15:05 +0100)] 
Add test of NULL SQL value handling

10 months agoAlign Firebird results handling with that of other database drivers
Nick Porter [Mon, 21 Oct 2024 14:00:38 +0000 (15:00 +0100)] 
Align Firebird results handling with that of other database drivers

10 months agoHandle NULL return values in PostgreSQL
Nick Porter [Mon, 21 Oct 2024 12:53:37 +0000 (13:53 +0100)] 
Handle NULL return values in PostgreSQL

10 months agoHandle NULL return values in MySQL
Nick Porter [Mon, 21 Oct 2024 11:36:44 +0000 (12:36 +0100)] 
Handle NULL return values in MySQL

10 months agoHandle NULL fields returned in unixodbc
Nick Porter [Mon, 21 Oct 2024 11:35:31 +0000 (12:35 +0100)] 
Handle NULL fields returned in unixodbc

ODBC uses the data length indicator to report NULL return values.

10 months agoProtect against NULL return values from SQL queries
Nick Porter [Mon, 21 Oct 2024 11:16:09 +0000 (12:16 +0100)] 
Protect against NULL return values from SQL queries

Won't happen with the default schemas, but always possible with custom
schemas

10 months agoHandle NULL returns from SQL when parsing map values
Nick Porter [Mon, 21 Oct 2024 11:12:21 +0000 (12:12 +0100)] 
Handle NULL returns from SQL when parsing map values

10 months agoadd this, too
Alan T. DeKok [Mon, 21 Oct 2024 15:37:03 +0000 (11:37 -0400)] 
add this, too

10 months agothis is static
Alan T. DeKok [Mon, 21 Oct 2024 15:10:57 +0000 (11:10 -0400)] 
this is static

10 months agoremove call to write_flush
Alan T. DeKok [Mon, 21 Oct 2024 15:07:58 +0000 (11:07 -0400)] 
remove call to write_flush

10 months agowe don't need write_flush
Alan T. DeKok [Mon, 21 Oct 2024 13:11:25 +0000 (09:11 -0400)] 
we don't need write_flush

10 months agoadd and use explicit verify_ctx for BIO
Alan T. DeKok [Thu, 17 Oct 2024 13:34:08 +0000 (09:34 -0400)] 
add and use explicit verify_ctx for BIO

so that bio->ctx can always be application data

10 months agoDon't load the RADIUS dictionary in the xlat code
Arran Cudbard-Bell [Sat, 19 Oct 2024 16:35:08 +0000 (10:35 -0600)] 
Don't load the RADIUS dictionary in the xlat code

We're not a RADIUS server... and this appears to be unused

10 months agoCompiler is correct... if bio is nonnull, this should be do {} while ()
Arran Cudbard-Bell [Sat, 19 Oct 2024 02:24:25 +0000 (20:24 -0600)] 
Compiler is correct... if bio is nonnull, this should be do {} while ()

10 months agoSupport resetting the dictionary root
Arran Cudbard-Bell [Sat, 19 Oct 2024 01:49:35 +0000 (19:49 -0600)] 
Support resetting the dictionary root

10 months agoDon't automatically mark up defines as internal, as this breaks the DER encoder
Arran Cudbard-Bell [Sat, 19 Oct 2024 01:42:35 +0000 (19:42 -0600)] 
Don't automatically mark up defines as internal, as this breaks the DER encoder

10 months agoTrunk "request specific" settings go in request, not requests
Nick Porter [Thu, 17 Oct 2024 08:03:54 +0000 (09:03 +0100)] 
Trunk "request specific" settings go in request, not requests