]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
18 months agoReport what database file is being created
Nick Porter [Fri, 2 Feb 2024 14:50:54 +0000 (14:50 +0000)] 
Report what database file is being created

18 months agoInclude sqlite3 in FreeBSD CI build
Nick Porter [Fri, 2 Feb 2024 15:49:26 +0000 (15:49 +0000)] 
Include sqlite3 in FreeBSD CI build

18 months agoMore GitHub action updates
Nick Porter [Fri, 2 Feb 2024 15:48:13 +0000 (15:48 +0000)] 
More GitHub action updates

Just for allocated_address_attr to start with

19 months agoAttempt to placate Coverity in rs_packet_process() (CID #1587345)
James Jones [Mon, 29 Jan 2024 20:28:05 +0000 (14:28 -0600)] 
Attempt to placate Coverity in rs_packet_process() (CID #1587345)

Coverity infers from the check of original->expect in the call to
fr_radius_decode_simple() that original->expect can be NULL, and
hence the later call to rs_stats_update_latency() call that
dereferences original->expect may fail. It may be that if original
and original->linked are non-NULL, one can infer original->expect
is non-NULL. Coverity can't; hence the added check on that call to
rs_stats_update_latency()..

19 months agoDeal with remaining missing locks (CIDs listed below)
James Jones [Tue, 21 Nov 2023 21:53:47 +0000 (15:53 -0600)] 
Deal with remaining missing locks (CIDs listed below)

CIDs: 1551700155170115517041551705

19 months agoSQL driver config can't refer to ...pool
Nick Porter [Wed, 31 Jan 2024 17:54:44 +0000 (17:54 +0000)] 
SQL driver config can't refer to ...pool

since it is included before the pool section.

19 months agoMinor Oracle fixes
Nick Porter [Wed, 31 Jan 2024 17:51:19 +0000 (17:51 +0000)] 
Minor Oracle fixes

19 months agoAlign Oracle spool.max parsing with pool.max
Nick Porter [Wed, 31 Jan 2024 17:50:41 +0000 (17:50 +0000)] 
Align Oracle spool.max parsing with pool.max

If not set, matches the number of worker threads

19 months agoFix oracle query issue
Nick Porter [Wed, 31 Jan 2024 17:49:31 +0000 (17:49 +0000)] 
Fix oracle query issue

19 months agominor copy editing
Alan T. DeKok [Thu, 1 Feb 2024 14:03:10 +0000 (09:03 -0500)] 
minor copy editing

commas, etc.

19 months agoupdate and clarify
Alan T. DeKok [Thu, 1 Feb 2024 13:48:39 +0000 (08:48 -0500)] 
update and clarify

19 months agoNo need for begin / commit for independent UPDATE queries
Nick Porter [Thu, 1 Feb 2024 13:58:43 +0000 (13:58 +0000)] 
No need for begin / commit for independent UPDATE queries

Whilst Oracle had these set to "COMMIT", queries are actually run with
OCI_COMMIT_ON_SUCCESS so no need for a separate COMMIT

19 months agorefresh antora raddb pages
Matthew Newton [Wed, 31 Jan 2024 17:44:26 +0000 (17:44 +0000)] 
refresh antora raddb pages

19 months agodoc: add letsencrypt howto
Matthew Newton [Wed, 31 Jan 2024 17:43:30 +0000 (17:43 +0000)] 
doc: add letsencrypt howto

19 months agodoc: unlang nav case consistency
Matthew Newton [Tue, 30 Jan 2024 18:33:48 +0000 (18:33 +0000)] 
doc: unlang nav case consistency

19 months agodoc: local variables are not keywords
Matthew Newton [Tue, 30 Jan 2024 18:33:04 +0000 (18:33 +0000)] 
doc: local variables are not keywords

19 months agodoc: fix some antora issues
Matthew Newton [Tue, 30 Jan 2024 17:34:40 +0000 (17:34 +0000)] 
doc: fix some antora issues

19 months agohoist checks for EWOULDBLOCK into function calling read()
Alan T. DeKok [Wed, 31 Jan 2024 15:56:35 +0000 (10:56 -0500)] 
hoist checks for EWOULDBLOCK into function calling read()

19 months agocall _exit() when checking if a debugger is attached.
Alan T. DeKok [Wed, 31 Jan 2024 15:20:19 +0000 (10:20 -0500)] 
call _exit() when checking if a debugger is attached.

Callng exit() not only calls all of the atexit() handlers,
which we don't need for a temporary, throw-away child process,
it also causes many pages to be written to unnecessarily.  Which
causes them to be cloned (due to copy on write), and then the
pages are immediately thrown away.

19 months agoadd asserts
Alan T. DeKok [Wed, 31 Jan 2024 02:49:45 +0000 (21:49 -0500)] 
add asserts

19 months agodelay reading dictionaries until after setting up debug state
Alan T. DeKok [Wed, 31 Jan 2024 14:06:31 +0000 (09:06 -0500)] 
delay reading dictionaries until after setting up debug state

On Linux, fr_get_debug_state() calls fork() to get debugging
status.  It then calls exit(), which calls the atexit() handlers,
which complain that memory isn't cleaned up.

We hoist those checks to above the "read dictionary" call, so that
the atexit() handlers won't trigger.

19 months agoprint system error, not fr_strerror()
Alan T. DeKok [Tue, 30 Jan 2024 22:48:12 +0000 (17:48 -0500)] 
print system error, not fr_strerror()

we also likely need a simple way to say "please close this socket",
other than just returning "socket failed"

19 months agohoist TLS cleanup to before mainconfig cleanup
Alan T. DeKok [Tue, 30 Jan 2024 21:05:41 +0000 (16:05 -0500)] 
hoist TLS cleanup to before mainconfig cleanup

19 months agoadd and use TEST_FINI for acutest
Alan T. DeKok [Tue, 30 Jan 2024 21:03:43 +0000 (16:03 -0500)] 
add and use TEST_FINI for acutest

so that the dictionaries are cleaned up when we exit.

This commit also removes the use of constructors.  While this
change makes the tests slower, we do need everything to be cleaned
up on exit, to avoid errors

19 months agocall request_global_free() after request_global_init()
Alan T. DeKok [Tue, 30 Jan 2024 17:46:13 +0000 (12:46 -0500)] 
call request_global_free() after request_global_init()

19 months agoadd prototype to correct file
Alan T. DeKok [Tue, 30 Jan 2024 15:49:03 +0000 (10:49 -0500)] 
add prototype to correct file

19 months agoadd and use fr_tls_dict_free()
Alan T. DeKok [Tue, 30 Jan 2024 15:11:43 +0000 (10:11 -0500)] 
add and use fr_tls_dict_free()

separate the instance_count for OpenSSL and TLS.

If OpenSSL init doesn't call fr_tls_dict_init(), it shouldn't
call autofree for the tls dict

19 months agoCall dict->proto->free() if we called dict->proto->init()
Alan T. DeKok [Tue, 30 Jan 2024 14:47:53 +0000 (09:47 -0500)] 
Call dict->proto->free() if we called dict->proto->init()

With some complete magic

19 months agoclarify debug text
Alan T. DeKok [Tue, 30 Jan 2024 14:27:59 +0000 (09:27 -0500)] 
clarify debug text

19 months agonope. Back out changes until we fix it
Alan T. DeKok [Tue, 30 Jan 2024 14:04:01 +0000 (09:04 -0500)] 
nope.  Back out changes until we fix it

19 months agoremove extraneous assert
Alan T. DeKok [Tue, 30 Jan 2024 13:47:30 +0000 (08:47 -0500)] 
remove extraneous assert

19 months agocall the proto init() routine from finalize()
Alan T. DeKok [Tue, 30 Jan 2024 12:58:50 +0000 (07:58 -0500)] 
call the proto init() routine from finalize()

so that we can apply fixups, and load any foreign dictionaries.

19 months agoquiet compiler
Alan T. DeKok [Tue, 30 Jan 2024 11:55:08 +0000 (06:55 -0500)] 
quiet compiler

19 months agoThere may already be a packet in the buffer. Helps with #5286
Alan T. DeKok [Tue, 30 Jan 2024 11:49:09 +0000 (06:49 -0500)] 
There may already be a packet in the buffer.  Helps with #5286

19 months agoreset dict_gctx if necessary
Alan T. DeKok [Mon, 29 Jan 2024 20:54:51 +0000 (15:54 -0500)] 
reset dict_gctx if necessary

fr_dict_global_ctx_init() sets dict_gctx, so we need
to clean it up if fr_dict_global_ctx_free() is called

19 months agohandle EWOULDBLOCK. Helps with #5286
Alan T. DeKok [Mon, 29 Jan 2024 19:52:03 +0000 (14:52 -0500)] 
handle EWOULDBLOCK.  Helps with #5286

19 months agoset accept FD to be non blocking. Helps with #5286
Alan T. DeKok [Mon, 29 Jan 2024 19:45:46 +0000 (14:45 -0500)] 
set accept FD to be non blocking.  Helps with #5286

19 months agodisable until we fix loading dictionaries with loops
Alan T. DeKok [Mon, 29 Jan 2024 19:41:20 +0000 (14:41 -0500)] 
disable until we fix loading dictionaries with loops

19 months agonarrow down the checks
Alan T. DeKok [Mon, 29 Jan 2024 19:39:14 +0000 (14:39 -0500)] 
narrow down the checks

19 months agomore checks on init / free
Alan T. DeKok [Mon, 29 Jan 2024 13:50:52 +0000 (08:50 -0500)] 
more checks on init / free

on init, we increment the ref count _before_ autoloading the
dictionaries.  That way if the function is called recursively,
(as when dictionaries reference each other), nothing is done.

On free, assert that the reference count is >0

19 months agoassert that the dictionaries are initialized
Alan T. DeKok [Mon, 29 Jan 2024 13:19:31 +0000 (08:19 -0500)] 
assert that the dictionaries are initialized

19 months agoPacify coverity (CID #1587346)
Nick Porter [Mon, 29 Jan 2024 17:33:10 +0000 (17:33 +0000)] 
Pacify coverity (CID #1587346)

19 months agoAllow request to be optional in PostgreSQL escape function
Nick Porter [Mon, 29 Jan 2024 16:48:24 +0000 (16:48 +0000)] 
Allow request to be optional in PostgreSQL escape function

19 months agoUse correct SQLite syntax for id column to reference ROWID
Nick Porter [Mon, 29 Jan 2024 16:47:42 +0000 (16:47 +0000)] 
Use correct SQLite syntax for id column to reference ROWID

19 months agoadded foreign decode to DHCPv6 and tests
Alan T. DeKok [Sun, 28 Jan 2024 22:17:18 +0000 (17:17 -0500)] 
added foreign decode to DHCPv6 and tests

19 months agojust return on error on TLV decode
Alan T. DeKok [Sun, 28 Jan 2024 21:09:35 +0000 (16:09 -0500)] 
just return on error on TLV decode

19 months agocheck slen
Alan T. DeKok [Sun, 28 Jan 2024 17:21:17 +0000 (12:21 -0500)] 
check slen

19 months agoremove unnecessary comment
Alan T. DeKok [Sun, 28 Jan 2024 17:16:58 +0000 (12:16 -0500)] 
remove unnecessary comment

19 months agoadd foreign encoder to DHCPv6
Alan T. DeKok [Sun, 28 Jan 2024 17:06:40 +0000 (12:06 -0500)] 
add foreign encoder to DHCPv6

update dictionaries and tests

19 months agouse consistent names
Alan T. DeKok [Sun, 28 Jan 2024 16:57:10 +0000 (11:57 -0500)] 
use consistent names

19 months agodon't modify slen on return
Alan T. DeKok [Sun, 28 Jan 2024 16:49:56 +0000 (11:49 -0500)] 
don't modify slen on return

19 months agohoist encode foreign ref to common function
Alan T. DeKok [Sun, 28 Jan 2024 16:37:58 +0000 (11:37 -0500)] 
hoist encode foreign ref to common function

19 months agoset ref correctly. don't set it to itself :(
Alan T. DeKok [Sun, 28 Jan 2024 16:37:28 +0000 (11:37 -0500)] 
set ref correctly.  don't set it to itself :(

and don't over-ride the current dictionary

19 months agoadd foreign handlers for DHCPv6
Alan T. DeKok [Sun, 28 Jan 2024 16:22:37 +0000 (11:22 -0500)] 
add foreign handlers for DHCPv6

19 months agothis attribute encodes other DHCPv6 options, not TLVs
Alan T. DeKok [Sun, 28 Jan 2024 16:21:17 +0000 (11:21 -0500)] 
this attribute encodes other DHCPv6 options, not TLVs

19 months agoupdate test for code changes
Alan T. DeKok [Sun, 28 Jan 2024 15:26:14 +0000 (10:26 -0500)] 
update test for code changes

19 months agoslen maybe SSIZE_MIN :(
Alan T. DeKok [Sun, 28 Jan 2024 15:12:31 +0000 (10:12 -0500)] 
slen maybe SSIZE_MIN :(

19 months agoprint actual reasons
Alan T. DeKok [Sun, 28 Jan 2024 14:54:06 +0000 (09:54 -0500)] 
print actual reasons

19 months agoclean up corner cases for decoder as found by fuzzer
Alan T. DeKok [Sun, 28 Jan 2024 14:53:44 +0000 (09:53 -0500)] 
clean up corner cases for decoder as found by fuzzer

19 months agojust return on error on TLV decode
Alan T. DeKok [Sun, 28 Jan 2024 14:46:22 +0000 (09:46 -0500)] 
just return on error on TLV decode

19 months agodhcp attributes can have zeeo length
Alan T. DeKok [Sun, 28 Jan 2024 14:20:52 +0000 (09:20 -0500)] 
dhcp attributes can have zeeo length

19 months agouse thread-local buffer for decoding
Alan T. DeKok [Sat, 27 Jan 2024 21:41:32 +0000 (16:41 -0500)] 
use thread-local buffer for decoding

to save on heap memory allocation

19 months agochange scope of variable
Alan T. DeKok [Sat, 27 Jan 2024 20:58:22 +0000 (15:58 -0500)] 
change scope of variable

19 months agouse tmp_ctx for decoding, not decode_ctx
Alan T. DeKok [Sat, 27 Jan 2024 16:38:20 +0000 (11:38 -0500)] 
use tmp_ctx for decoding, not decode_ctx

19 months agoadd fragmentation for encoding VSAs
Alan T. DeKok [Sat, 27 Jan 2024 15:53:16 +0000 (10:53 -0500)] 
add fragmentation for encoding VSAs

19 months agoencode groups for VSAs
Alan T. DeKok [Sat, 27 Jan 2024 14:52:18 +0000 (09:52 -0500)] 
encode groups for VSAs

update the dictionaries, and the tests

19 months agoRevert "disable until we figure out why it passes locally but not in CI"
Alan T. DeKok [Sat, 27 Jan 2024 14:30:39 +0000 (09:30 -0500)] 
Revert "disable until we figure out why it passes locally but not in CI"

This reverts commit 7aa50d26d3a963509f3f08ba80385b2e0ed55b17.

19 months agomash protocol names to lowercase
Alan T. DeKok [Sat, 27 Jan 2024 14:47:34 +0000 (09:47 -0500)] 
mash protocol names to lowercase

the names in the dictionaries are case insensitive, but the
file names are lowercase.

19 months agodon't overwrite the upstream error message
Alan T. DeKok [Sat, 27 Jan 2024 14:29:44 +0000 (09:29 -0500)] 
don't overwrite the upstream error message

19 months agoensure the list is freed
Alan T. DeKok [Sat, 27 Jan 2024 13:31:01 +0000 (08:31 -0500)] 
ensure the list is freed

19 months agoVP isn't used
Alan T. DeKok [Fri, 26 Jan 2024 22:11:58 +0000 (17:11 -0500)] 
VP isn't used

19 months agodisable until we figure out why it passes locally but not in CI
Alan T. DeKok [Fri, 26 Jan 2024 21:55:02 +0000 (16:55 -0500)] 
disable until we figure out why it passes locally but not in CI

19 months agoclean up corner case for loading name
Alan T. DeKok [Fri, 26 Jan 2024 21:46:13 +0000 (16:46 -0500)] 
clean up corner case for loading name

19 months agoreturn NULL on error
Alan T. DeKok [Fri, 26 Jan 2024 21:28:20 +0000 (16:28 -0500)] 
return NULL on error

19 months agoadd init/free to fr_dict_protocol_t
Alan T. DeKok [Fri, 26 Jan 2024 21:14:53 +0000 (16:14 -0500)] 
add init/free to fr_dict_protocol_t

and call them for autoref dictionaries

19 months agomove encode_group to its own function
Alan T. DeKok [Fri, 26 Jan 2024 21:14:28 +0000 (16:14 -0500)] 
move encode_group to its own function

so that we can re-use it for VSAs

19 months agoadd foreign decoder for RADIUS and DHCPv4
Alan T. DeKok [Fri, 26 Jan 2024 16:35:16 +0000 (11:35 -0500)] 
add foreign decoder for RADIUS and DHCPv4

19 months agoadd note on how to handle ALIAS
Alan T. DeKok [Fri, 26 Jan 2024 16:34:41 +0000 (11:34 -0500)] 
add note on how to handle ALIAS

which "jumps ahead" in the tree

19 months agoremove limitation which isn't needed
Alan T. DeKok [Fri, 26 Jan 2024 15:06:32 +0000 (10:06 -0500)] 
remove limitation which isn't needed

19 months agocorrectly handle inter-dictionary dependencies.
Alan T. DeKok [Fri, 26 Jan 2024 13:54:24 +0000 (08:54 -0500)] 
correctly handle inter-dictionary dependencies.

when adding them, make the "next" one depend on the one which
loaded it.  Then add the "next" one to the autofree list for the
current dictionary.

When freeing the global context, walk through all of the
dictionaries and free the autoref references first. Then walk through
them again, freeing the externally loaded references.

19 months agoencode foreign references
Alan T. DeKok [Fri, 26 Jan 2024 03:04:20 +0000 (22:04 -0500)] 
encode foreign references

19 months agomake tag limitations more narrow
Alan T. DeKok [Fri, 26 Jan 2024 15:07:43 +0000 (10:07 -0500)] 
make tag limitations more narrow

in preparation for adding groups

19 months agoallow encoding for foreign options
Alan T. DeKok [Fri, 26 Jan 2024 02:59:57 +0000 (21:59 -0500)] 
allow encoding for foreign options

19 months agoexport fr_dict_protocol_t
Alan T. DeKok [Fri, 26 Jan 2024 02:48:35 +0000 (21:48 -0500)] 
export fr_dict_protocol_t

19 months agoencode functions take a "const" list
Alan T. DeKok [Fri, 26 Jan 2024 02:25:08 +0000 (21:25 -0500)] 
encode functions take a "const" list

19 months agoRemove unneeded headers
Nick Porter [Wed, 24 Jan 2024 13:56:09 +0000 (13:56 +0000)] 
Remove unneeded headers

19 months agoRemove unused module option
Nick Porter [Mon, 22 Jan 2024 19:34:45 +0000 (19:34 +0000)] 
Remove unused module option

19 months agoAlign sqlippool behaviour with redis_ippool
Nick Porter [Mon, 22 Jan 2024 13:55:44 +0000 (13:55 +0000)] 
Align sqlippool behaviour with redis_ippool

by updating `gateway` on each address update.

19 months agosqlippool_queries don't use SQL-User-Name attribute, so don't create it
Nick Porter [Mon, 22 Jan 2024 12:31:00 +0000 (12:31 +0000)] 
sqlippool_queries don't use SQL-User-Name attribute, so don't create it

19 months agoMore appropriate debug messages
Nick Porter [Fri, 19 Jan 2024 17:47:40 +0000 (17:47 +0000)] 
More appropriate debug messages

19 months agoRemove un-used pool_name
Nick Porter [Fri, 19 Jan 2024 16:58:02 +0000 (16:58 +0000)] 
Remove un-used pool_name

19 months agoMore tidying up of sqlippool method names
Nick Porter [Fri, 19 Jan 2024 16:15:34 +0000 (16:15 +0000)] 
More tidying up of sqlippool method names

19 months agoReplace mod_accounting with named methods
Nick Porter [Fri, 19 Jan 2024 16:14:07 +0000 (16:14 +0000)] 
Replace mod_accounting with named methods

19 months agoBump github cache action version for newer node.js
Nick Porter [Fri, 26 Jan 2024 08:03:19 +0000 (08:03 +0000)] 
Bump github cache action version for newer node.js

19 months agoVarious fixes
Arran Cudbard-Bell [Fri, 26 Jan 2024 02:04:04 +0000 (20:04 -0600)] 
Various fixes

19 months agoFix redundant declarations
Arran Cudbard-Bell [Fri, 26 Jan 2024 01:02:06 +0000 (19:02 -0600)] 
Fix redundant declarations

19 months agoReplace vb->safe with vb->safe_for
Arran Cudbard-Bell [Fri, 26 Jan 2024 00:19:33 +0000 (18:19 -0600)] 
Replace vb->safe with vb->safe_for

This is usually a pointer to a function used for escaping.  This is still only partially integrated and requires more work.

19 months agoMove instantiation functions in rlm_sql
Arran Cudbard-Bell [Fri, 26 Jan 2024 00:05:24 +0000 (18:05 -0600)] 
Move instantiation functions in rlm_sql

19 months agoMove fr_assert() check of mutex-guarded data after the lock (CID #1587069)
James Jones [Thu, 25 Jan 2024 21:56:41 +0000 (15:56 -0600)] 
Move fr_assert() check of mutex-guarded data after the lock (CID #1587069)

19 months agoFix typos in src
Dimitri Papadopoulos [Thu, 25 Jan 2024 21:52:09 +0000 (22:52 +0100)] 
Fix typos in src

Misspellings found by codespell.