]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
19 months agoMove fr_assert() check of mutex-guarded data after the lock (CID #1587069)
James Jones [Thu, 25 Jan 2024 21:56:41 +0000 (15:56 -0600)] 
Move fr_assert() check of mutex-guarded data after the lock (CID #1587069)

19 months agoFix typos in src
Dimitri Papadopoulos [Thu, 25 Jan 2024 21:52:09 +0000 (22:52 +0100)] 
Fix typos in src

Misspellings found by codespell.

19 months agoUpdate GitHub Actions
Dimitri Papadopoulos [Thu, 25 Jan 2024 22:21:21 +0000 (23:21 +0100)] 
Update GitHub Actions

This should fix this warning:

FreeBSD build

Node.js 16 actions are deprecated. Please update the following
actions to use Node.js 20: actions/checkout@v3, actions/cache@v3,
cross-platform-actions/action@v0.21.0. For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

19 months agoMake foreign dictionary references work.
Alan T. DeKok [Thu, 25 Jan 2024 22:08:33 +0000 (17:08 -0500)] 
Make foreign dictionary references work.

19 months agotypo
Alan T. DeKok [Thu, 25 Jan 2024 17:14:43 +0000 (12:14 -0500)] 
typo

19 months agoFix typos in debian
Dimitri Papadopoulos [Thu, 25 Jan 2024 22:07:17 +0000 (23:07 +0100)] 
Fix typos in debian

Misspellings found by codespell.

19 months agoFix typos in doc
Dimitri Papadopoulos [Thu, 25 Jan 2024 22:03:11 +0000 (23:03 +0100)] 
Fix typos in doc

Misspellings found by codespell.

19 months agoFix typos in scripts
Dimitri Papadopoulos [Thu, 25 Jan 2024 21:58:06 +0000 (22:58 +0100)] 
Fix typos in scripts

Misspellings found by codespell.

19 months agoCorrect auth vector reference
Nick Porter [Thu, 25 Jan 2024 20:55:39 +0000 (20:55 +0000)] 
Correct auth vector reference

19 months agoHandle coverity defects in do_xlats() error messages (CID #1533664)
James Jones [Tue, 26 Sep 2023 20:26:11 +0000 (15:26 -0500)] 
Handle coverity defects in do_xlats() error messages (CID #1533664)

19 months agoHoist remaining locks after tests of fr_io_client ht (CIDs below)
James Jones [Tue, 21 Nov 2023 15:56:51 +0000 (09:56 -0600)] 
Hoist remaining locks after tests of fr_io_client ht (CIDs below)

CIDS: 155170615517031551699

19 months agomutexes near returns (CID #1551697, #1551698)
James Jones [Wed, 22 Nov 2023 18:56:30 +0000 (12:56 -0600)] 
mutexes near returns (CID #1551697, #1551698)

1551697 Guard reference to is_exiting if HAVE_PTHREADS defined
1551698 Annotate leaving exfiles opened for exclusive use locked

19 months agoAdd needed lock/unlock to access t->inst->list (CID 1551705)
James Jones [Mon, 22 Jan 2024 22:36:16 +0000 (16:36 -0600)] 
Add needed lock/unlock to access t->inst->list (CID 1551705)

19 months agoChange redhat similarly to debian
Dimitri Papadopoulos [Mon, 25 Dec 2023 15:53:34 +0000 (16:53 +0100)] 
Change redhat similarly to debian

19 months agoAddress ssues raised durign review
Dimitri Papadopoulos [Mon, 25 Dec 2023 15:48:09 +0000 (16:48 +0100)] 
Address ssues raised durign review

19 months agoUpdate URLs: http:// → https://
Dimitri Papadopoulos [Mon, 25 Dec 2023 14:41:04 +0000 (15:41 +0100)] 
Update URLs: http:// → https://

19 months agoAttempt to keep coverity from being silly (CID #1551707)
James Jones [Tue, 23 Jan 2024 17:21:44 +0000 (11:21 -0600)] 
Attempt to keep coverity from being silly (CID #1551707)

For some unknown reason, Coverity skips the declaration of subst in
fr_vasprintf_internal()...and said declaration initializes it, so
that later, when substr is used, Coverity complains that subst is
not initialized!

To try to avoid this; we move the declaration of subst out of the
do {} while () loop it was in, to the outer block of the function
body, and then just assign to it in the loop.

19 months agoupdate Radius dictionary form Extreme Networks
Markus Nikulski [Thu, 25 Jan 2024 11:12:41 +0000 (12:12 +0100)] 
update Radius dictionary form Extreme Networks

extend the dictionary with the current status of Extreme Networks

19 months agoadd foreign encoders for RADIUS
Alan T. DeKok [Thu, 25 Jan 2024 17:03:37 +0000 (12:03 -0500)] 
add foreign encoders for RADIUS

19 months agoadd encode / decode callbacks for dictionaries
Alan T. DeKok [Thu, 25 Jan 2024 16:49:40 +0000 (11:49 -0500)] 
add encode / decode callbacks for dictionaries

with forward definitions for fr_pair_list_t, and fr_dbuff_t,
so that we don't have circular references

19 months agoadd radclient-ng, and allow it to be used in tests
Alan T. DeKok [Thu, 25 Jan 2024 14:14:17 +0000 (09:14 -0500)] 
add radclient-ng, and allow it to be used in tests

but install it to a build directory, so that it doesn't muck up
the packages

19 months agomove client programs to new API
Alan T. DeKok [Thu, 25 Jan 2024 14:06:53 +0000 (09:06 -0500)] 
move client programs to new API

We're gradually getting rid of the fr_radius_packet_foo() APIs.
They're essentially tiny wrappers around the fr_radius_foo()
functions, and they make it more difficult to switch to using
bios.

19 months agouse better names
Alan T. DeKok [Thu, 25 Jan 2024 14:00:39 +0000 (09:00 -0500)] 
use better names

19 months agotypo
Alan T. DeKok [Thu, 25 Jan 2024 13:33:04 +0000 (08:33 -0500)] 
typo

19 months agoensure that decode_ctx->request_authenticator is initialized
Alan T. DeKok [Thu, 25 Jan 2024 13:31:44 +0000 (08:31 -0500)] 
ensure that decode_ctx->request_authenticator is initialized

19 months agothe expected result should be listed first
Alan T. DeKok [Thu, 25 Jan 2024 13:29:23 +0000 (08:29 -0500)] 
the expected result should be listed first

19 months agohoist reply checks to core code
Alan T. DeKok [Thu, 25 Jan 2024 13:21:45 +0000 (08:21 -0500)] 
hoist reply checks to core code

19 months agoAdd libfreeradius-bio.so to Debian packaging
Nick Porter [Thu, 25 Jan 2024 13:17:21 +0000 (13:17 +0000)] 
Add libfreeradius-bio.so to Debian packaging

19 months agoremove erroneous assert. should help with #5276
Alan T. DeKok [Thu, 25 Jan 2024 08:49:47 +0000 (03:49 -0500)] 
remove erroneous assert.  should help with #5276

The code for NAK later assumes that there is a connection, so the
assert is wrong

19 months agouse length from struct instead of talloc_array_length
Alan T. DeKok [Thu, 25 Jan 2024 01:33:59 +0000 (20:33 -0500)] 
use length from struct instead of talloc_array_length

19 months agostart removing duplicate APIs
Alan T. DeKok [Thu, 25 Jan 2024 01:18:15 +0000 (20:18 -0500)] 
start removing duplicate APIs

19 months agomove to using request_authenticator for encode, too
Alan T. DeKok [Thu, 25 Jan 2024 01:12:48 +0000 (20:12 -0500)] 
move to using request_authenticator for encode, too

19 months agomove to using decode_ctx for public APIs, v2
Alan T. DeKok [Thu, 25 Jan 2024 01:04:19 +0000 (20:04 -0500)] 
move to using decode_ctx for public APIs, v2

19 months agotypo
Alan T. DeKok [Thu, 25 Jan 2024 00:51:27 +0000 (19:51 -0500)] 
typo

19 months agoRevert "move to using decode_ctx for public APIs."
Alan T. DeKok [Thu, 25 Jan 2024 00:16:51 +0000 (19:16 -0500)] 
Revert "move to using decode_ctx for public APIs."

This reverts commit 6bcda326683aea8b877a4c6e2f5fb4dff6eb0871.

19 months agoinitialize rcode
Alan T. DeKok [Thu, 25 Jan 2024 00:07:54 +0000 (19:07 -0500)] 
initialize rcode

19 months agoRename ldap escape and unescape xlats...
Arran Cudbard-Bell [Wed, 24 Jan 2024 23:09:44 +0000 (17:09 -0600)] 
Rename ldap escape and unescape xlats...

19 months agoMerge ERX/Unisphere, nuke ERX
Arran Cudbard-Bell [Wed, 24 Jan 2024 22:41:31 +0000 (16:41 -0600)] 
Merge ERX/Unisphere, nuke ERX

19 months agoclean up duplicate APIs
Alan T. DeKok [Wed, 24 Jan 2024 21:11:01 +0000 (16:11 -0500)] 
clean up duplicate APIs

19 months agomove to using decode_ctx for public APIs.
Alan T. DeKok [Wed, 24 Jan 2024 17:25:52 +0000 (12:25 -0500)] 
move to using decode_ctx for public APIs.

19 months agowhitespace
Alan T. DeKok [Wed, 24 Jan 2024 18:16:19 +0000 (13:16 -0500)] 
whitespace

19 months agoremove unnecessary "break"
Alan T. DeKok [Wed, 24 Jan 2024 18:13:46 +0000 (13:13 -0500)] 
remove unnecessary "break"

19 months agoadd basic test for proxying
Alan T. DeKok [Wed, 24 Jan 2024 15:48:48 +0000 (10:48 -0500)] 
add basic test for proxying

and ensure we re-run the tests when the handlers change

19 months agoAdd test for [*] filter in files comparison
Nick Porter [Wed, 24 Jan 2024 19:36:49 +0000 (19:36 +0000)] 
Add test for [*] filter in files comparison

19 months agoUse tmpl_dcursor in radius_lecacy_map_cmp
Nick Porter [Wed, 24 Jan 2024 19:25:42 +0000 (19:25 +0000)] 
Use tmpl_dcursor in radius_lecacy_map_cmp

Allows for the lhs to use the [*] filter

19 months agobind to unix sockets correctly for ACCEPT
Alan T. DeKok [Wed, 24 Jan 2024 15:27:12 +0000 (10:27 -0500)] 
bind to unix sockets correctly for ACCEPT

19 months agomore sanity checks so that files are only connected bios
Alan T. DeKok [Wed, 24 Jan 2024 14:13:09 +0000 (09:13 -0500)] 
more sanity checks so that files are only connected bios

19 months agomove to run-time error instead of build error
Alan T. DeKok [Wed, 24 Jan 2024 14:11:36 +0000 (09:11 -0500)] 
move to run-time error instead of build error

FreeBSD has IP_RECVIF, not SO_BINDTODEVICE.  And IP_RECVIF only
works for datagram sockets, and has to be used with recvmsg()

So until we get that code working, just disallow binding to an
interface.

19 months agopass original vector to verify / sign
Alan T. DeKok [Wed, 24 Jan 2024 13:31:44 +0000 (08:31 -0500)] 
pass original vector to verify / sign

instead of the complete packet.  This makes later changes easier

19 months ago.diff files can have trailing whitespace
Nick Porter [Wed, 24 Jan 2024 13:42:30 +0000 (13:42 +0000)] 
.diff files can have trailing whitespace

19 months agoFix debian packaging patch file
Nick Porter [Wed, 24 Jan 2024 13:09:48 +0000 (13:09 +0000)] 
Fix debian packaging patch file

19 months agows
Nick Porter [Wed, 24 Jan 2024 12:17:04 +0000 (12:17 +0000)] 
ws

19 months agoInitialise the correct member
Nick Porter [Wed, 24 Jan 2024 12:16:54 +0000 (12:16 +0000)] 
Initialise the correct member

19 months agoQuiet compiler warning
Arran Cudbard-Bell [Wed, 24 Jan 2024 00:58:12 +0000 (18:58 -0600)] 
Quiet compiler warning

19 months agoAllow the OID of a pair to be printed
Arran Cudbard-Bell [Wed, 24 Jan 2024 00:50:31 +0000 (18:50 -0600)] 
Allow the OID of a pair to be printed

19 months agoUse better type to hash/trie/rb mappings
Arran Cudbard-Bell [Tue, 23 Jan 2024 22:53:07 +0000 (16:53 -0600)] 
Use better type to hash/trie/rb mappings

19 months agoFix integer (and other) comparisons for switch
Arran Cudbard-Bell [Tue, 23 Jan 2024 22:35:43 +0000 (16:35 -0600)] 
Fix integer (and other) comparisons for switch

19 months agoaddress coverity issues
Alan T. DeKok [Tue, 23 Jan 2024 21:32:38 +0000 (16:32 -0500)] 
address coverity issues

19 months agoallow domain sockets to be opened as root
Alan T. DeKok [Tue, 23 Jan 2024 19:30:00 +0000 (14:30 -0500)] 
allow domain sockets to be opened as root

which is likely imperfect, but whatever

19 months agoremove old / unused commented-out config items
Alan T. DeKok [Tue, 23 Jan 2024 19:27:47 +0000 (14:27 -0500)] 
remove old / unused commented-out config items

19 months agomake reply checks more stringent
Alan T. DeKok [Tue, 23 Jan 2024 19:23:41 +0000 (14:23 -0500)] 
make reply checks more stringent

19 months agoremove unused macro
Alan T. DeKok [Tue, 23 Jan 2024 19:21:04 +0000 (14:21 -0500)] 
remove unused macro

19 months agomove to using bios for at least part of the control socket
Alan T. DeKok [Tue, 23 Jan 2024 18:55:55 +0000 (13:55 -0500)] 
move to using bios for at least part of the control socket

19 months agoRemove setting of Message-Success-Message from sqlippool
Nick Porter [Tue, 23 Jan 2024 17:05:09 +0000 (17:05 +0000)] 
Remove setting of Message-Success-Message from sqlippool

Equivalent functionality can be done by observing the module return code
and use of xlats.

19 months agouse new defs
Alan T. DeKok [Tue, 23 Jan 2024 17:04:53 +0000 (12:04 -0500)] 
use new defs

19 months agosplit encode / decode context into two different fields
Alan T. DeKok [Tue, 23 Jan 2024 16:22:55 +0000 (11:22 -0500)] 
split encode / decode context into two different fields

and add a common context with secret, etc.

19 months agoallow opening /dev/stdout and /dev/stderr
Alan T. DeKok [Tue, 23 Jan 2024 14:19:40 +0000 (09:19 -0500)] 
allow opening /dev/stdout and /dev/stderr

19 months agoLinux has AF_FILE==AF_LOCAL
Alan T. DeKok [Tue, 23 Jan 2024 13:59:17 +0000 (08:59 -0500)] 
Linux has AF_FILE==AF_LOCAL

so use our own AF_FILE_BIO

19 months agoadd support for file IO in bios
Alan T. DeKok [Tue, 23 Jan 2024 13:51:44 +0000 (08:51 -0500)] 
add support for file IO in bios

19 months agouse AF_LOCAL, as AF_UNIX is deprecated
Alan T. DeKok [Tue, 23 Jan 2024 13:50:50 +0000 (08:50 -0500)] 
use AF_LOCAL, as AF_UNIX is deprecated

19 months agojust call write()
Alan T. DeKok [Tue, 23 Jan 2024 13:19:10 +0000 (08:19 -0500)] 
just call write()

19 months agoadd cfg to alloc routine, too
Alan T. DeKok [Tue, 23 Jan 2024 13:04:17 +0000 (08:04 -0500)] 
add cfg to alloc routine, too

19 months ago<sigh>
Alan T. DeKok [Tue, 23 Jan 2024 12:55:04 +0000 (07:55 -0500)] 
<sigh>

19 months agomight as well cache cfg, too
Alan T. DeKok [Tue, 23 Jan 2024 12:33:51 +0000 (07:33 -0500)] 
might as well cache cfg, too

19 months agotry to quiet the static analyzer
Alan T. DeKok [Tue, 23 Jan 2024 12:30:43 +0000 (07:30 -0500)] 
try to quiet the static analyzer

19 months agodon't return things which are missing in NDEBUG builds
Alan T. DeKok [Tue, 23 Jan 2024 02:38:27 +0000 (21:38 -0500)] 
don't return things which are missing in NDEBUG builds

19 months agothis is unused
Alan T. DeKok [Tue, 23 Jan 2024 02:27:16 +0000 (21:27 -0500)] 
this is unused

add it back in when we fix it, and start using it

19 months agoonly need this for debug builds
Alan T. DeKok [Tue, 23 Jan 2024 02:25:20 +0000 (21:25 -0500)] 
only need this for debug builds

19 months agoshut up stupid compiler
Alan T. DeKok [Tue, 23 Jan 2024 02:24:13 +0000 (21:24 -0500)] 
shut up stupid compiler

19 months agomore quiet static analysis
Alan T. DeKok [Tue, 23 Jan 2024 02:11:19 +0000 (21:11 -0500)] 
more quiet static analysis

19 months agoand more build fixes
Alan T. DeKok [Tue, 23 Jan 2024 00:42:26 +0000 (19:42 -0500)] 
and more build fixes

19 months ago...and RPM fixes
Arran Cudbard-Bell [Tue, 23 Jan 2024 00:25:51 +0000 (18:25 -0600)] 
...and RPM fixes

19 months agoand more build fixes
Alan T. DeKok [Tue, 23 Jan 2024 00:22:13 +0000 (19:22 -0500)] 
and more build fixes

19 months agoDon't apply body restrictions to xlat calls
Arran Cudbard-Bell [Tue, 23 Jan 2024 00:18:49 +0000 (18:18 -0600)] 
Don't apply body restrictions to xlat calls

19 months agomore build fixes
Alan T. DeKok [Tue, 23 Jan 2024 00:06:06 +0000 (19:06 -0500)] 
more build fixes

19 months agoclang on OSX does not produce nearly enough errors.
Alan T. DeKok [Mon, 22 Jan 2024 23:58:45 +0000 (18:58 -0500)] 
clang on OSX does not produce nearly enough errors.

CI produces many more errors and complaints.

19 months agoFirst pass at bio handlers.
Alan T. DeKok [Mon, 22 Jan 2024 23:44:41 +0000 (18:44 -0500)] 
First pass at bio handlers.

The FD bio works.  The others are "compile tested"

19 months agowe don't need these fields. The bio code has been updated
Alan T. DeKok [Mon, 22 Jan 2024 22:09:01 +0000 (17:09 -0500)] 
we don't need these fields.  The bio code has been updated

19 months agostart moving more code to centralized RADIUS library
Alan T. DeKok [Mon, 22 Jan 2024 21:35:38 +0000 (16:35 -0500)] 
start moving more code to centralized RADIUS library

19 months agodocument source of fast rng
Alan T. DeKok [Mon, 22 Jan 2024 19:31:07 +0000 (14:31 -0500)] 
document source of fast rng

19 months agoRename json xlat functions
Arran Cudbard-Bell [Mon, 22 Jan 2024 22:33:53 +0000 (16:33 -0600)] 
Rename json xlat functions

19 months agocall the correct function
Alan T. DeKok [Mon, 22 Jan 2024 19:02:09 +0000 (14:02 -0500)] 
call the correct function

19 months agot_rules may be NULL. CID 1558812
Alan T. DeKok [Mon, 22 Jan 2024 18:51:51 +0000 (13:51 -0500)] 
t_rules may be NULL. CID 1558812

19 months agojust trust /dev/random
Alan T. DeKok [Mon, 22 Jan 2024 14:25:49 +0000 (09:25 -0500)] 
just trust /dev/random

there's little utility in mixing in other data

19 months agominor cleanups
Alan T. DeKok [Mon, 22 Jan 2024 14:19:18 +0000 (09:19 -0500)] 
minor cleanups

19 months agorename functions for clarity
Alan T. DeKok [Mon, 22 Jan 2024 14:08:01 +0000 (09:08 -0500)] 
rename functions for clarity

in preparation for allowing forced seeds

19 months agono need to call encode / sign / write. just call fr_radius_send()
Alan T. DeKok [Mon, 22 Jan 2024 13:04:00 +0000 (08:04 -0500)] 
no need to call encode / sign / write.  just call fr_radius_send()

19 months agoRevert to main eapol_test repo
Nick Porter [Mon, 22 Jan 2024 18:04:53 +0000 (18:04 +0000)] 
Revert to main eapol_test repo

We only pull from the repo if we don't have a cached copy, so don't pull
very often.

19 months agoInvalid comment
Arran Cudbard-Bell [Sat, 20 Jan 2024 15:09:06 +0000 (09:09 -0600)] 
Invalid comment

19 months agoDon't reallocate the uri escape ctx on every request
Arran Cudbard-Bell [Sat, 20 Jan 2024 02:48:47 +0000 (20:48 -0600)] 
Don't reallocate the uri escape ctx on every request