Darren Tucker [Tue, 28 Aug 2012 09:57:19 +0000 (19:57 +1000)]
- (dtucker) [openbsd-compat/bsd-cygwin_util.h] define WIN32_LEAN_AND_MEAN
for compatibility with future mingw-w64 headers. Patch from vinschen at
redhat com.
Damien Miller [Tue, 31 Jul 2012 02:21:34 +0000 (12:21 +1000)]
- djm@cvs.openbsd.org 2012/07/10 02:19:15
[servconf.c servconf.h sshd.c sshd_config]
Turn on systrace sandboxing of pre-auth sshd by default for new installs
by shipping a config that overrides the current UsePrivilegeSeparation=yes
default. Make it easier to flip the default in the future by adding too.
Damien Miller [Fri, 6 Jul 2012 03:45:01 +0000 (13:45 +1000)]
- djm@cvs.openbsd.org 2012/07/06 01:47:38
[ssh.c]
move setting of tty_flag to after config parsing so RequestTTY options
are correctly picked up. bz#1995 patch from przemoc AT gmail.com;
ok dtucker@
Damien Miller [Fri, 6 Jul 2012 03:44:43 +0000 (13:44 +1000)]
- djm@cvs.openbsd.org 2012/07/06 01:37:21
[mux.c]
fix memory leak of passed-in environment variables and connection
context when new session message is malformed; bz#2003 from Bert.Wesarg
AT googlemail.com
Damien Miller [Fri, 6 Jul 2012 03:44:19 +0000 (13:44 +1000)]
- dtucker@cvs.openbsd.org 2012/07/06 00:41:59
[moduli.c ssh-keygen.1 ssh-keygen.c]
Add options to specify starting line number and number of lines to process
when screening moduli candidates. This allows processing of different
parts of a candidate moduli file in parallel. man page help jmc@, ok djm@
Damien Miller [Fri, 6 Jul 2012 01:49:28 +0000 (11:49 +1000)]
- (djm) [configure.ac] Recursively expand $(bindir) to ensure it has no
unexpanded $(prefix) embedded. bz#2007 patch from nix-corp AT
esperi.org.uk; ok dtucker@
Damien Miller [Fri, 6 Jul 2012 00:27:10 +0000 (10:27 +1000)]
- (djm) [sandbox-seccomp-filter.c] fallback to rlimit if seccomp filter is
not available. Allows use of sshd compiled on host with a filter-capable
kernel on hosts that lack the support. bz#2011 ok dtucker@
Darren Tucker [Tue, 3 Jul 2012 12:48:31 +0000 (22:48 +1000)]
- (dtucker) [configure.ac sandbox-rlimit.c] Test whether or not
setrlimit(RLIMIT_FSIZE, rl_zero) and skip it if it's not supported. Its
benefit is minor, so it's not worth disabling the sandbox if it doesn't
work.
Darren Tucker [Mon, 2 Jul 2012 08:54:31 +0000 (18:54 +1000)]
- markus@cvs.openbsd.org 2012/06/30 14:35:09
[sandbox-systrace.c sshd.c]
fix a during the load of the sandbox policies (child can still make
the read-syscall and wait forever for systrace-answers) by replacing
the read/write synchronisation with SIGSTOP/SIGCONT;
report and help hshoexer@; ok djm@, dtucker@
Darren Tucker [Sat, 30 Jun 2012 05:08:53 +0000 (15:08 +1000)]
- dtucker@cvs.openbsd.org 2012/06/28 05:07:45
[regress/try-ciphers.sh regress/cipher-speed.sh]
Remove hmac-sha2-256-96 and hmac-sha2-512-96 MACs since they were removed
from draft6 of the spec and will not be in the RFC when published. Patch
from mdb at juniper net via bz#2023, ok markus
Darren Tucker [Sat, 30 Jun 2012 05:04:13 +0000 (15:04 +1000)]
- djm@cvs.openbsd.org 2012/06/01 00:52:52
[regress/sftp-cmds.sh]
don't delete .* on cleanup due to unintended env expansion; pointed out in
bz#2014 by openssh AT roumenpetrov.info
Darren Tucker [Sat, 30 Jun 2012 05:01:22 +0000 (15:01 +1000)]
- dtucker@cvs.openbsd.org 2012/05/13 01:42:32
[regress/addrmatch.sh]
Add "Match LocalAddress" and "Match LocalPort" to sshd and adjust tests
to match. Feedback and ok djm@ markus@.
Damien Miller [Fri, 29 Jun 2012 22:34:59 +0000 (08:34 +1000)]
- dtucker@cvs.openbsd.org 2012/06/28 05:07:45
[mac.c myproposal.h ssh_config.5 sshd_config.5]
Remove hmac-sha2-256-96 and hmac-sha2-512-96 MACs since they were removed
from draft6 of the spec and will not be in the RFC when published. Patch
from mdb at juniper net via bz#2023, ok markus.
Damien Miller [Fri, 29 Jun 2012 22:33:53 +0000 (08:33 +1000)]
- dtucker@cvs.openbsd.org 2012/06/26 11:02:30
[sandbox-systrace.c]
Add mquery to the list of allowed syscalls for "UsePrivilegeSeparation
sandbox" since malloc now uses it. From johnw.mail at gmail com.
Damien Miller [Fri, 29 Jun 2012 22:33:32 +0000 (08:33 +1000)]
- dtucker@cvs.openbsd.org 2012/06/22 14:36:33
[sftp.c]
Remove unused variable leftover from tab-completion changes.
From Steve.McClellan at radisys com, ok markus@
Damien Miller [Fri, 29 Jun 2012 22:33:17 +0000 (08:33 +1000)]
- dtucker@cvs.openbsd.org 2012/06/22 12:30:26
[monitor.c sshconnect2.c]
remove dead code following 'for (;;)' loops.
From Steve.McClellan at radisys com, ok markus@
Darren Tucker [Thu, 28 Jun 2012 05:21:32 +0000 (15:21 +1000)]
- (dtucker) [openbsd-compat/getrrsetbyname-ldns.c] bz #2022: prevent null
pointer deref in the client when built with LDNS and using DNSSEC with a
CNAME. Patch from gregdlg+mr at hochet info.
Damien Miller [Wed, 20 Jun 2012 11:53:58 +0000 (21:53 +1000)]
- markus@cvs.openbsd.org 2012/06/19 18:25:28
[servconf.c servconf.h sshd_config.5]
sshd_config: extend Match to allow AcceptEnv and {Allow,Deny}{Users,Groups}
this allows 'Match LocalPort 1022' combined with 'AllowUser bauer'
ok djm@ (back in March)
Damien Miller [Wed, 20 Jun 2012 11:52:58 +0000 (21:52 +1000)]
- dtucker@cvs.openbsd.org 2012/06/18 12:07:07
[ssh.1 sshd.8]
Remove mention of 'three' key files since there are now four. From
Steve.McClellan at radisys com.
Damien Miller [Wed, 20 Jun 2012 11:51:29 +0000 (21:51 +1000)]
- djm@cvs.openbsd.org 2012/06/01 00:49:35
[PROTOCOL.mux]
correct types of port numbers (integers, not strings); bz#2004 from
bert.wesarg AT googlemail.com
Damien Miller [Wed, 20 Jun 2012 11:51:11 +0000 (21:51 +1000)]
- djm@cvs.openbsd.org 2012/05/23 03:28:28
[dns.c dns.h key.c key.h ssh-keygen.c]
add support for RFC6594 SSHFP DNS records for ECDSA key types.
patch from bugzilla-m67 AT nulld.me in bz#1978; ok + tweak markus@
Darren Tucker [Sat, 19 May 2012 05:24:37 +0000 (15:24 +1000)]
- (dtucker) [configure.ac contrib/Makefile] bz#1996: use AC_PATH_TOOL to find
pkg-config so it does the right thing when cross-compiling. Patch from
cjwatson at debian org.
Darren Tucker [Fri, 4 May 2012 01:05:45 +0000 (11:05 +1000)]
- (dtucker) [configure.ac] Include <sys/param.h> rather than <sys/types.h>
to fix building on some plaforms. Fom bowman at math utah edu and
des at des no.
Darren Tucker [Fri, 27 Apr 2012 00:55:39 +0000 (10:55 +1000)]
- (dtucker) [regress/addrmatch.sh] skip tests when running on a non-ipv6
platform rather than exiting early, so that we still clean up and return
status to test-exec.sh
Damien Miller [Sun, 22 Apr 2012 01:24:43 +0000 (11:24 +1000)]
- djm@cvs.openbsd.org 2012/04/12 02:42:32
[servconf.c servconf.h sshd.c sshd_config sshd_config.5]
VersionAddendum option to allow server operators to append some arbitrary
text to the SSH-... banner; ok deraadt@ "don't care" markus@
Damien Miller [Sun, 22 Apr 2012 01:24:21 +0000 (11:24 +1000)]
- djm@cvs.openbsd.org 2012/04/11 13:34:17
[ssh-keyscan.1 ssh-keyscan.c]
now that sshd defaults to offering ECDSA keys, ssh-keyscan should also
look for them by default; bz#1971
Damien Miller [Sun, 22 Apr 2012 01:21:10 +0000 (11:21 +1000)]
- djm@cvs.openbsd.org 2012/04/11 13:16:19
[channels.c channels.h clientloop.c serverloop.c]
don't spin in accept() when out of fds (ENFILE/ENFILE) - back off for a
while; ok deraadt@ markus@
Damien Miller [Sun, 22 Apr 2012 01:08:30 +0000 (11:08 +1000)]
- djm@cvs.openbsd.org 2012/03/28 07:23:22
[PROTOCOL.certkeys]
explain certificate extensions/crit split rationale. Mention requirement
that each appear at most once per cert.
Damien Miller [Sun, 22 Apr 2012 01:08:10 +0000 (11:08 +1000)]
- guenther@cvs.openbsd.org 2012/03/15 03:10:27
[session.c]
root should always be excluded from the test for /etc/nologin instead
of having it always enforced even when marked as ignorenologin. This
regressed when the logic was incompletely flipped around in rev 1.251
ok halex@ millert@
Damien Miller [Wed, 4 Apr 2012 01:27:54 +0000 (11:27 +1000)]
- (djm) [Makefile.in configure.ac sandbox-seccomp-filter.c] Add sandbox
mode for Linux's new seccomp filter; patch from Will Drewry; feedback
and ok dtucker@
Damien Miller [Fri, 30 Mar 2012 00:34:27 +0000 (11:34 +1100)]
- (djm) [entropy.c] bz#1991: relax OpenSSL version test to allow running
openssh binaries on a newer fix release than they were compiled on.
with and ok dtucker@
Damien Miller [Thu, 8 Mar 2012 23:25:16 +0000 (10:25 +1100)]
- (djm) [openbsd-compat/port-linux.c] bz#1960: fix crash on SELinux
systems where sshd is run in te wrong context. Patch from Sven
Vermeulen; ok dtucker@
Tim Rice [Tue, 14 Feb 2012 18:03:30 +0000 (10:03 -0800)]
- (tim) [openbsd-compat/bsd-misc.h sshd.c] Fix conflicting return type for
unsetenv due to rev 1.14 change to setenv.c. Cast unsetenv to void in sshd.c
ok dtucker@
Damien Miller [Fri, 10 Feb 2012 21:18:17 +0000 (08:18 +1100)]
- dtucker@cvs.openbsd.org 2012/01/18 21:46:43
[clientloop.c]
Ensure that $DISPLAY contains only valid characters before using it to
extract xauth data so that it can't be used to play local shell
metacharacter games. Report from r00t_ati at ihteam.net, ok markus.
Damien Miller [Fri, 10 Feb 2012 21:17:52 +0000 (08:17 +1100)]
- miod@cvs.openbsd.org 2012/01/16 20:34:09
[ssh-pkcs11-client.c]
Fix a memory leak in pkcs11_rsa_private_encrypt(), reported by Jan Klemkow.
While there, be sure to buffer_clear() between send_msg() and recv_msg().
ok markus@
Darren Tucker [Tue, 17 Jan 2012 03:03:34 +0000 (14:03 +1100)]
- (dtucker) [configure.ac mac.c openbsd-compat/openssl-compat.h] Add
null implementation of HMAC_CTX_init for the benefit of old versions
of OpenSSL that don't have it.