]> git.ipfire.org Git - thirdparty/squid.git/commit
Distinguish FwdState::fail() callers
authorEduard Bagdasaryan <eduard.bagdasaryan@measurement-factory.com>
Tue, 14 Jul 2020 15:06:08 +0000 (18:06 +0300)
committerEduard Bagdasaryan <eduard.bagdasaryan@measurement-factory.com>
Tue, 14 Jul 2020 15:06:08 +0000 (18:06 +0300)
commit0523b9309618c9d2662d4c967cc69efab429156e
treeec84c7bf2cc17c20699625c3701398155176bc3a
parent8ec371fd8e8ba621364ffbf8a051ab09d9c392fc
Distinguish FwdState::fail() callers

The fail() method performs two actions, saving an error and making some
cleanup operations. However, in reality the most of the callers do only
the first step because the second (cleanup) depends on a rare
ERR_ZERO_SIZE_OBJECT condition. We could probably optimize all these
callers, calling saveError() instead of fail() - but this can cause some
difficulties in future if the cleanup condition changes. However, I
think it is reasonable to do this for internal callers only (i.e., in
FwdState itself).
src/FwdState.cc
src/FwdState.h