]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mtk-sd: Fix a pagefault in dma_unmap_sg() for not prepared data
authorMasami Hiramatsu (Google) <mhiramat@kernel.org>
Thu, 5 Jun 2025 01:07:38 +0000 (10:07 +0900)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 9 Jun 2025 13:32:34 +0000 (15:32 +0200)
commit539d80575b810c7a5987c7ac8915e3bc99c03695
treef846b5dbef68764dcaf22c524354cc4b28339afb
parent3358b836d4369ad47823c26834b3613778fe75b2
mtk-sd: Fix a pagefault in dma_unmap_sg() for not prepared data

When swiotlb buffer is full, the dma_map_sg() returns 0 to
msdc_prepare_data(), but it does not check it and sets the
MSDC_PREPARE_FLAG.

swiotlb_tbl_map_single() /* prints "swiotlb buffer is full" */
  <-swiotlb_map()
    <-dma_direct_map_page()
      <-dma_direct_map_sg()
        <-__dma_map_sg_attrs()
          <-dma_map_sg_attrs()
            <-dma_map_sg()  /* returns 0 (pages mapped) */
              <-msdc_prepare_data()

Then, the msdc_unprepare_data() checks MSDC_PREPARE_FLAG and calls
dma_unmap_sg() with unmapped pages. It causes a page fault.

To fix this problem, Do not set MSDC_PREPARE_FLAG if dma_map_sg()
fails because this is not prepared.

Fixes: 208489032bdd ("mmc: mediatek: Add Mediatek MMC driver")
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Tested-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/174908565814.4056588.769599127120955383.stgit@mhiramat.tok.corp.google.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/mtk-sd.c