]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
timekeeping: Zero initialize system_counterval when querying time from phc drivers
authorMarkus Blöchl <markus@blochl.de>
Sun, 20 Jul 2025 13:54:51 +0000 (15:54 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 22 Jul 2025 12:25:21 +0000 (14:25 +0200)
commit67c632b4a7fbd6b76a08b86f4950f0f84de93439
tree480c3a97fbdcdf0299479aa1332485d581f44b1a
parent89be9a83ccf1f88522317ce02f854f30d6115c41
timekeeping: Zero initialize system_counterval when querying time from phc drivers

Most drivers only populate the fields cycles and cs_id of system_counterval
in their get_time_fn() callback for get_device_system_crosststamp(), unless
they explicitly provide nanosecond values.

When the use_nsecs field was added to struct system_counterval, most
drivers did not care.  Clock sources other than CSID_GENERIC could then get
converted in convert_base_to_cs() based on an uninitialized use_nsecs field,
which usually results in -EINVAL during the following range check.

Pass in a fully zero initialized system_counterval_t to cure that.

Fixes: 6b2e29977518 ("timekeeping: Provide infrastructure for converting to/from a base clock")
Signed-off-by: Markus Blöchl <markus@blochl.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: John Stultz <jstultz@google.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/20250720-timekeeping_uninit_crossts-v2-1-f513c885b7c2@blochl.de
kernel/time/timekeeping.c