]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
vsock: Fix transport_* TOCTOU
authorMichal Luczaj <mhal@rbox.co>
Thu, 3 Jul 2025 15:18:19 +0000 (17:18 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 8 Jul 2025 15:39:49 +0000 (08:39 -0700)
commit687aa0c5581b8d4aa87fd92973e4ee576b550cdf
tree48766d82d61a0eac5ff531c05ff2bca00bf68769
parent209fd720838aaf1420416494c5505096478156b4
vsock: Fix transport_* TOCTOU

Transport assignment may race with module unload. Protect new_transport
from becoming a stale pointer.

This also takes care of an insecure call in vsock_use_local_transport();
add a lockdep assert.

BUG: unable to handle page fault for address: fffffbfff8056000
Oops: Oops: 0000 [#1] SMP KASAN
RIP: 0010:vsock_assign_transport+0x366/0x600
Call Trace:
 vsock_connect+0x59c/0xc40
 __sys_connect+0xe8/0x100
 __x64_sys_connect+0x6e/0xc0
 do_syscall_64+0x92/0x1c0
 entry_SYSCALL_64_after_hwframe+0x4b/0x53

Fixes: c0cfa2d8a788 ("vsock: add multi-transports support")
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Michal Luczaj <mhal@rbox.co>
Link: https://patch.msgid.link/20250703-vsock-transports-toctou-v4-2-98f0eb530747@rbox.co
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/vmw_vsock/af_vsock.c