]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/sched: sch_qfq: Avoid triggering might_sleep in atomic context in qfq_delete_class
authorXiang Mei <xmei5@asu.edu>
Thu, 17 Jul 2025 23:01:28 +0000 (16:01 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 22 Jul 2025 09:48:34 +0000 (11:48 +0200)
commitcf074eca0065bc5142e6004ae236bb35a2687fdf
treef549b848ed65c0b66898221fda5f300296f122dc
parentb03f15c0192b184078206760c839054ae6eb4eaa
net/sched: sch_qfq: Avoid triggering might_sleep in atomic context in qfq_delete_class

might_sleep could be trigger in the atomic context in qfq_delete_class.

qfq_destroy_class was moved into atomic context locked
by sch_tree_lock to avoid a race condition bug on
qfq_aggregate. However, might_sleep could be triggered by
qfq_destroy_class, which introduced sleeping in atomic context (path:
qfq_destroy_class->qdisc_put->__qdisc_destroy->lockdep_unregister_key
->might_sleep).

Considering the race is on the qfq_aggregate objects, keeping
qfq_rm_from_agg in the lock but moving the left part out can solve
this issue.

Fixes: 5e28d5a3f774 ("net/sched: sch_qfq: Fix race condition on qfq_aggregate")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Xiang Mei <xmei5@asu.edu>
Link: https://patch.msgid.link/4a04e0cc-a64b-44e7-9213-2880ed641d77@sabinyo.mountain
Reviewed-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/20250717230128.159766-1-xmei5@asu.edu
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/sched/sch_qfq.c