]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ll_temac: Fix missing tx_pending check in ethtools_set_ringparam()
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Thu, 10 Jul 2025 18:06:17 +0000 (11:06 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 11 Jul 2025 14:27:26 +0000 (07:27 -0700)
commite81750b4e3826fedce7362dad839cb40384d60ae
tree0285f7786c64beccdf3167f5bcd776ce8c6ebfa5
parent5b81d59f02a075cd318e898dd1f3644a261bb9c4
net: ll_temac: Fix missing tx_pending check in ethtools_set_ringparam()

The function ll_temac_ethtools_set_ringparam() incorrectly checked
rx_pending twice, once correctly for RX and once mistakenly in place
of tx_pending. This caused tx_pending to be left unchecked against
TX_BD_NUM_MAX.
As a result, invalid TX ring sizes may have been accepted or valid
ones wrongly rejected based on the RX limit, leading to potential
misconfiguration or unexpected results.

This patch corrects the condition to properly validate tx_pending.

Fixes: f7b261bfc35e ("net: ll_temac: Make RX/TX ring sizes configurable")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Link: https://patch.msgid.link/20250710180621.2383000-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/xilinx/ll_temac_main.c