]> git.ipfire.org Git - thirdparty/gcc.git/commit
Move more warning code to gimple-ssa-warn-access etc.
authorMartin Sebor <msebor@redhat.com>
Tue, 17 Aug 2021 20:49:05 +0000 (14:49 -0600)
committerMartin Sebor <msebor@redhat.com>
Tue, 17 Aug 2021 20:49:05 +0000 (14:49 -0600)
commitb48d4e6818674898f90d9358378c127511ef0f9f
tree8a9ba017b48f620474808116b309ca78335e0a94
parent32c3a75390623a0470df52af13f78baddd562981
Move more warning code to gimple-ssa-warn-access etc.

Also resolves:
PR middle-end/101854 - Invalid warning -Wstringop-overflow wrong argument

gcc/ChangeLog:

PR middle-end/101854
* builtins.c (expand_builtin_alloca): Move warning code to check_alloca
in gimple-ssa-warn-access.cc.
* calls.c (alloc_max_size): Move code to check_alloca.
(get_size_range): Move to pointer-query.cc.
(maybe_warn_alloc_args_overflow): Move to gimple-ssa-warn-access.cc.
(get_attr_nonstring_decl): Move to tree.c.
(fntype_argno_type): Move to gimple-ssa-warn-access.cc.
(append_attrname): Same.
(maybe_warn_rdwr_sizes): Same.
(initialize_argument_information): Move code to
gimple-ssa-warn-access.cc.
* calls.h (maybe_warn_alloc_args_overflow): Move to
gimple-ssa-warn-access.h.
(get_attr_nonstring_decl): Move to tree.h.
(maybe_warn_nonstring_arg):  Move to gimple-ssa-warn-access.h.
(enum size_range_flags): Move to pointer-query.h.
(get_size_range): Same.
* gimple-ssa-warn-access.cc (has_location): Remove unused overload
to avoid Clang -Wunused-function.
(get_size_range): Declare static.
(maybe_emit_free_warning): Rename...
(maybe_check_dealloc_call): ...to this for consistency.
(class pass_waccess): Add members.
(pass_waccess::~pass_waccess): Defined.
(alloc_max_size): Move here from calls.c.
(maybe_warn_alloc_args_overflow): Same.
(check_alloca): New function.
(check_alloc_size_call): New function.
(check_strncat): Handle another warning flag.
(pass_waccess::check_builtin): Handle alloca.
(fntype_argno_type): Move here from calls.c.
(append_attrname): Same.
(maybe_warn_rdwr_sizes): Same.
(pass_waccess::check_call): Define.
(check_nonstring_args): New function.
(pass_waccess::check): Call new member functions.
(pass_waccess::execute): Enable ranger.
* gimple-ssa-warn-access.h (get_size_range): Move here from calls.h.
(maybe_warn_nonstring_arg): Same.
* gimple-ssa-warn-restrict.c: Remove #include.
* pointer-query.cc (get_size_range): Move here from calls.c.
* pointer-query.h (enum size_range_flags): Same.
(get_size_range): Same.
* tree.c (get_attr_nonstring_decl): Move here from calls.c.
* tree.h (get_attr_nonstring_decl): Move here from calls.h.

gcc/testsuite/ChangeLog:

* gcc.dg/attr-alloc_size-5.c: Adjust optimization to -O1.
* gcc.dg/attr-alloc_size-7.c: Use #pragmas to adjust optimization.
* gcc.dg/attr-alloc_size-8.c: Adjust optimization to -O1.

PR middle-end/101854
* gcc.dg/Wstringop-overflow-72.c: New test.
14 files changed:
gcc/builtins.c
gcc/calls.c
gcc/calls.h
gcc/gimple-ssa-warn-access.cc
gcc/gimple-ssa-warn-access.h
gcc/gimple-ssa-warn-restrict.c
gcc/pointer-query.cc
gcc/pointer-query.h
gcc/testsuite/gcc.dg/Wstringop-overflow-72.c [new file with mode: 0644]
gcc/testsuite/gcc.dg/attr-alloc_size-5.c
gcc/testsuite/gcc.dg/attr-alloc_size-7.c
gcc/testsuite/gcc.dg/attr-alloc_size-8.c
gcc/tree.c
gcc/tree.h