From 020627fe1289bb234c183b59a1bba607e1b3a5dc Mon Sep 17 00:00:00 2001
From: Christos Tsantilas <christos@chtsanti.net>
Date: Sat, 29 Jun 2019 07:15:34 +0000
Subject: [PATCH] Bug 4842: Memory leak when http_reply_access uses
 external_acl (#424)

Http::One::Server::handleReply() sets AccessLogEntry::reply which may
already be set. It is already set, for example, when the ACL code
has already called syncAle() because external ACLs require an ALE.

This bug was introduced by commit fbbea6620.

This is a Measurement Factory project.
---
 src/servers/Http1Server.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/servers/Http1Server.cc b/src/servers/Http1Server.cc
index 59db6f1e47..73b406d069 100644
--- a/src/servers/Http1Server.cc
+++ b/src/servers/Http1Server.cc
@@ -305,6 +305,7 @@ Http::One::Server::handleReply(HttpReply *rep, StoreIOBuffer receivedData)
     }
 
     assert(rep);
+    HTTPMSGUNLOCK(http->al->reply);
     http->al->reply = rep;
     HTTPMSGLOCK(http->al->reply);
     context->sendStartOfMessage(rep, receivedData);
-- 
2.47.2