From 2116b6a6714586e6775fd20337efa54968d08250 Mon Sep 17 00:00:00 2001 From: Eric Sandeen Date: Fri, 6 Feb 2015 10:24:36 +1100 Subject: [PATCH] xfs_repair: do not check symlink component lengths As reported by Andy Grimm, # ln -s $( python -c 'print "a" * 260' ) /mnt/foo will succeed on xfs, but then xfs_repair will complain: component of symlink in inode 131 too long problem with symbolic link in inode 131 would have cleared inode 131 The kernel checks the total length of the symlink on both read and write, but does not look at component paths. Looking around the kernel, no other filesystem checks component lengths, nor does the vfs. And as Andy points out, the target could even be on a different filesystem, with different limitations. And having a "too-long" component doesn't even seem like something likely to stem from disk corruption anyway, so I'm not sure why repair should care. Therefore I propose removing the component length checks from xfs_repair. Andy Grimm Signed-off-by: Eric Sandeen Reviewed-by: Brian Foster Signed-off-by: Dave Chinner --- repair/dinode.c | 27 +-------------------------- 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/repair/dinode.c b/repair/dinode.c index 38a656234..73e4b9eb3 100644 --- a/repair/dinode.c +++ b/repair/dinode.c @@ -1333,7 +1333,7 @@ process_symlink( xfs_dinode_t *dino, blkmap_t *blkmap) { - char *symlink, *cptr; + char *symlink; char data[MAXPATHLEN]; /* @@ -1380,31 +1380,6 @@ _("found illegal null character in symlink inode %" PRIu64 "\n"), return(1); } - /* - * check for any component being too long - */ - if (be64_to_cpu(dino->di_size) >= MAXNAMELEN) { - cptr = strchr(symlink, '/'); - - while (cptr != NULL) { - if (cptr - symlink >= MAXNAMELEN) { - do_warn( -_("component of symlink in inode %" PRIu64 " too long\n"), - lino); - return(1); - } - symlink = cptr + 1; - cptr = strchr(symlink, '/'); - } - - if (strlen(symlink) >= MAXNAMELEN) { - do_warn( -_("component of symlink in inode %" PRIu64 " too long\n"), - lino); - return(1); - } - } - return(0); } -- 2.47.2