From 2fc63cb18697b81676f2dec952c946cf645aea74 Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Thu, 30 Jan 2025 14:57:27 +0100 Subject: [PATCH] MINOR: quic: mark BBR as stable Pacing has recently been moved out of experimental status and is activated by default. This is a mandatory requirement for BBR. Furthermore, BBR is now considered stable. As such, removes its experimental status with this commit. --- doc/configuration.txt | 4 +--- src/cfgparse-quic.c | 6 ------ 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/doc/configuration.txt b/doc/configuration.txt index 8a0af0f94..ac888590f 100644 --- a/doc/configuration.txt +++ b/doc/configuration.txt @@ -17305,9 +17305,7 @@ quic-cc-algo { cubic | newreno | bbr | nocc }[()] improve throughput. It can be turned off via "tune.quic.disable-tx-pacing" global keyword. In most cases, pacing should remain activated, especially when using BBR as it relies on it to work as expected. Using BBR without - pacing may cause slowdowns or high loss rates during transfers. Also note - that haproxy's BBR implementation is also considered as experimental and - cannot be enabled without "expose-experimental-directives". + pacing may cause slowdowns or high loss rates during transfers. Default value: cubic diff --git a/src/cfgparse-quic.c b/src/cfgparse-quic.c index aa90aa06b..81de95599 100644 --- a/src/cfgparse-quic.c +++ b/src/cfgparse-quic.c @@ -106,12 +106,6 @@ static int bind_parse_quic_cc_algo(char **args, int cur_arg, struct proxy *px, arg += strlen(QUIC_CC_CUBIC_STR); } else if (isteq(algo_ist, ist(QUIC_CC_BBR_STR))) { - if (!experimental_directives_allowed) { - ha_alert("'%s' algo is experimental, must be allowed via a global " - "'expose-experimental-directives'\n", arg); - goto fail; - } - /* bbr */ algo = QUIC_CC_BBR_STR; *cc_algo = quic_cc_algo_bbr; -- 2.47.2