From 42bac29fdcf13717132cded2623c4daa183a24bf Mon Sep 17 00:00:00 2001
From: Karl Berry <karl@freefriends.org>
Date: Sun, 16 Jun 2024 09:20:29 -0700
Subject: [PATCH] test: the instdir-ltlib test is expected to fail.

Discussed in https://bugs.gnu.org/71596.

* t/list-of-tests.mk (handwritten_TESTS): move t/instdir-ltlib.sh
(XFAIL_TESTS): to here. It previously worked by accident
because lib_LTLIBRARIES was misspelled as lib_LTIBRARIES;
Paul Eggert fixed that on June 7,
commit 1d35638b23e95fe6f41c828a3442f6d7f242f4c4, and the
test started failing as a result.

* t/instdir-ltlib.sh: add some doc.
* t/all.sh: likewise. (Another xfail test, which is mysterious to me.)
---
 t/all.sh           |  4 ++++
 t/instdir-ltlib.sh | 12 ++++++++++--
 t/list-of-tests.mk |  2 +-
 3 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/t/all.sh b/t/all.sh
index 526abebd8..faae8ada2 100644
--- a/t/all.sh
+++ b/t/all.sh
@@ -27,6 +27,10 @@ $AUTOMAKE
 
 for target in $targets; do
   grep "${target}-local" Makefile.in # For debugging.
+  
+  # This grep fails, thus the test is listed in XFAIL.
+  # We're checking that (e.g.) all-am does not depend on all-local,
+  # but why?
   grep "${target}-am:.*${target}-local" Makefile.in
 done
 
diff --git a/t/instdir-ltlib.sh b/t/instdir-ltlib.sh
index 7744fd6e6..23fe9c12d 100644
--- a/t/instdir-ltlib.sh
+++ b/t/instdir-ltlib.sh
@@ -15,12 +15,20 @@
 # along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 # If $(libdir) or $(pyexecdir) is the empty string, then nothing should
-# be installed there.
-# This test exercises the libtool code paths.
+# be installed there, and in fact libtool will refuse to link due to the
+# missing argument for -rpath:
+#   /bin/sh ./libtool [...] -rpath  libfoo.lo  
+#   libtool:   error: only absolute run-paths are allowed
+# (Hopefully the error message will be improved.)
+# Thus this test is expected to fail.
+# 
+# This test exercises some of the libtool code paths.
 
 required='cc libtoolize'
 . test-init.sh
 
+# Although LT_INIT is preferred nowadays, keep using AC_PROG_LIBTOOL
+# to help make sure it's still supported.
 cat >>configure.ac <<'END'
 AC_PROG_CC
 AM_PROG_AR
diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk
index 9f6a08685..3761d4ad3 100644
--- a/t/list-of-tests.mk
+++ b/t/list-of-tests.mk
@@ -36,6 +36,7 @@ t/override-conditional-2.sh \
 t/override-conditional-pr13940.sh \
 t/dist-pr109765.sh \
 t/instdir-cond2.sh \
+t/instdir-ltlib.sh \
 t/java-nobase.sh \
 t/objext-pr10128.sh \
 t/remake-timing-bug-pr8365.sh \
@@ -545,7 +546,6 @@ t/instdir-cond2.sh \
 t/instdir-no-empty.sh \
 t/instdir-java.sh \
 t/instdir-lisp.sh \
-t/instdir-ltlib.sh \
 t/instdir-prog.sh \
 t/instdir-python.sh \
 t/instdir-texi.sh \
-- 
2.47.2