From 4fa74fd647ad5b6fa162298cfea5f600a5cd19c4 Mon Sep 17 00:00:00 2001 From: Sami Kerola Date: Sun, 9 Aug 2020 13:58:10 +0100 Subject: [PATCH] sfdisk: do not free device name too soon [coverity scan] Fixes use after free error. CID: 360798 Signed-off-by: Sami Kerola --- disk-utils/sfdisk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/disk-utils/sfdisk.c b/disk-utils/sfdisk.c index 54d3b60e71..2e9e7cd74c 100644 --- a/disk-utils/sfdisk.c +++ b/disk-utils/sfdisk.c @@ -619,7 +619,6 @@ done: if (f) fclose(f); free(buf); - free(devname); free(typescript); if (sf->noact) @@ -630,6 +629,8 @@ done: } else if (rc) warn(_("%s: failed to move data"), devname); + free(devname); + return rc; } -- 2.47.2