From 516e9ccab3689d903408e50251f47da8108a9df2 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Sun, 1 Jun 2025 08:01:23 +0200 Subject: [PATCH] GHA/non-native: un-ignore tests on OpenBSD, bump to `-j8` for NetBSD/FreeBSD - un-ignore tests (3017, FTP, TFTP) on OpenBSD Patch-by: Jacob Mealey Ref: https://github.com/curl/curl/issues/13623#issuecomment-2925129037 Fixes: #13623 - KNOWN_BUGS: drop TFTP failures issue on OpenBSD. Fixes: #13623 - bump test parallelism to `-j8` (from `-j4`) for NetBSD, FreeBSD, to match OpenBSD. Before: https://github.com/curl/curl/actions/runs/15371760479 After: https://github.com/curl/curl/actions/runs/15371937205 - FreeBSD: sync cmake `TFLAGS` with autotools. (This branch is not currently hit in CI.) Follow-up to 7f3d598276e988a46558fe6a2951b1ae354afcdf #15040 Closes #17505 --- .github/workflows/non-native.yml | 7 ++++--- docs/KNOWN_BUGS | 8 -------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/.github/workflows/non-native.yml b/.github/workflows/non-native.yml index b78853b8db..6d36b43741 100644 --- a/.github/workflows/non-native.yml +++ b/.github/workflows/non-native.yml @@ -72,7 +72,7 @@ jobs: bld/src/curl --disable --version if [ '${{ matrix.arch }}' = 'x86_64' ]; then # Slow on emulated CPU time cmake --build bld --target testdeps - export TFLAGS='-j4' + export TFLAGS='-j8' time cmake --build bld --target test-ci fi echo '::group::build examples' @@ -112,7 +112,7 @@ jobs: bld/src/curl --disable --version if [ '${{ matrix.arch }}' = 'x86_64' ]; then # Slow on emulated CPU time cmake --build bld --target testdeps - export TFLAGS='-j8 ~3017 ~TFTP ~FTP' # FIXME: TFTP requests executed twice? Related: `curl: (69) TFTP: Access Violation`? + export TFLAGS='-j8' time cmake --build bld --target test-ci fi echo '::group::build examples' @@ -169,7 +169,7 @@ jobs: if [ '${{ matrix.arch }}' = 'x86_64' ]; then # Slow on emulated CPU time make -C tests if [ "${desc#*!runtests*}" = "${desc}" ]; then - time make test-ci V=1 TFLAGS='-j4' + time make test-ci V=1 TFLAGS='-j8' fi fi if [ "${desc#*!examples*}" = "${desc}" ]; then @@ -206,6 +206,7 @@ jobs: if [ '${{ matrix.arch }}' = 'x86_64' ]; then # Slow on emulated CPU time cmake --build bld --target testdeps if [ "${desc#*!runtests*}" = "${desc}" ]; then + export TFLAGS='-j8' time cmake --build bld --target test-ci fi fi diff --git a/docs/KNOWN_BUGS b/docs/KNOWN_BUGS index 8abec28187..66084032a6 100644 --- a/docs/KNOWN_BUGS +++ b/docs/KNOWN_BUGS @@ -74,7 +74,6 @@ problems may have been fixed or changed somewhat since this was written. 11. Internals 11.1 gssapi library name + version is missing in curl_version_info() 11.2 error buffer not set if connection to multiple addresses fails - 11.3 TFTP tests fail on OpenBSD 11.4 HTTP test server 'connection-monitor' problems 11.5 Connection information when using TCP Fast Open 11.6 test cases sometimes timeout @@ -475,13 +474,6 @@ problems may have been fixed or changed somewhat since this was written. CURLE_COULDNT_CONNECT, but the error buffer set by CURLOPT_ERRORBUFFER remains empty. Issue: https://github.com/curl/curl/issues/544 -11.3 TFTP tests fail on OpenBSD - - When adding an OpenBSD job with tests to GHA, some tests consistently fail - to run. - - See https://github.com/curl/curl/issues/13623 - 11.4 HTTP test server 'connection-monitor' problems The 'connection-monitor' feature of the sws HTTP test server does not work -- 2.47.2