From 528ac2b6c4df4438c83d57fb73f06e3666ce2767 Mon Sep 17 00:00:00 2001 From: Alan Wang Date: Thu, 4 Jun 2020 15:07:59 +0800 Subject: [PATCH] [misc] Update CONTRIBUTING.md (#5579) --- CONTRIBUTING.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 924b05bd6..45fc3d434 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -47,7 +47,7 @@ cd moment npm install -g grunt-cli npm install git checkout develop # all patches against develop branch, please! -grunt # this runs tests and jshint +grunt # this runs tests, eslint and prettier-check ``` Changing locale files @@ -68,12 +68,15 @@ Grunt tasks We use Grunt for managing the build. Here are some useful Grunt tasks: * `grunt` The default task lints the code and runs the tests. You should make sure you do this before submitting a PR. - * `grunt test` run the tests. + * `grunt test` Run the tests. + * `grunt lint` Perform syntax and code style checks. * `grunt release` Build everything, including minified files (do not include those in Pull Requests) * `grunt transpile:fr,ru` Build custom locale bundles `moment-with-locales.custom.js` and `locales.custom.js` inside `build/umd/min` containing just French and Russian. * `grunt size` Print size statistics. +**Note:** If the prompt message is `Code style issues found in the above file(s). Forgot to run Prettier?`, Please run `npm run prettier-fmt`. + Becoming a moment team member ============================= -- 2.47.2