From 55f2a0772e08b9febac3ac0de5cb048d4c60d2f5 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 28 Feb 2021 23:23:16 -0800 Subject: [PATCH] Fix unlikely uninitalized var bug with sparse file * src/sparse.c (sparse_extract_file): Set *SIZE to stat.st_size so that the caller does not use *SIZE when uninitalized. Problem found with GCC 10 and --enable-gcc-warnings CFLAGS='-O2 -flto -fanalyzer'. --- src/sparse.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/sparse.c b/src/sparse.c index 61561f45..22ba32fa 100644 --- a/src/sparse.c +++ b/src/sparse.c @@ -568,7 +568,10 @@ sparse_extract_file (int fd, struct tar_stat_info *st, off_t *size) size_t i; if (!tar_sparse_init (&file)) - return dump_status_not_implemented; + { + *size = st->stat.st_size; + return dump_status_not_implemented; + } file.stat_info = st; file.fd = fd; -- 2.47.2