From 5eac1d728ca4d224287092fc765578a33686fe7c Mon Sep 17 00:00:00 2001 From: Lucas De Marchi Date: Fri, 13 Jun 2025 14:11:08 -0500 Subject: [PATCH] tools/modprobe: --dry-run shouldn't need -v Make sure it shows something when running in dry-run mode. Before: kmod $ lsmod | grep i915 kmod $ ./build/modprobe --dry-run i915 kmod $ ./build/modprobe -v --dry-run i915 insmod /lib/modules/6.14.11-1-MANJARO/kernel/drivers/char/agp/intel-gtt.ko.zst insmod /lib/modules/6.14.11-1-MANJARO/kernel/drivers/gpu/drm/i915/i915.ko.zst After: kmod $ lsmod | grep i915 kmod $ ./build/modprobe --dry-run i915 insmod /lib/modules/6.14.11-1-MANJARO/kernel/drivers/char/agp/intel-gtt.ko.zst insmod /lib/modules/6.14.11-1-MANJARO/kernel/drivers/gpu/drm/i915/i915.ko.zst Signed-off-by: Lucas De Marchi Link: https://github.com/kmod-project/kmod/pull/372 --- tools/modprobe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/modprobe.c b/tools/modprobe.c index fa9757e2..f97b9618 100644 --- a/tools/modprobe.c +++ b/tools/modprobe.c @@ -889,6 +889,7 @@ static int do_modprobe(int argc, char **orig_argv) /* fall through */ case 'n': dry_run = 1; + do_show = 1; break; case 'C': { size_t bytes = sizeof(char *) * (n_config_paths + 2); -- 2.47.2