From 75e1a6137a41d6b388752c103539fa0e4cc7d886 Mon Sep 17 00:00:00 2001 From: drserge Date: Wed, 18 Feb 2015 19:00:51 -0800 Subject: [PATCH] ext_wbinfo_group_acl: Perl 5.20 syntax errors With Perl 5.20 the helper exits with many errors similar to: Global symbol "$groupSID" requires explicit package name at /usr/libexec/squid/ext_wbinfo_group_acl --- .../wbinfo_group/ext_wbinfo_group_acl.pl.in | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/helpers/external_acl/wbinfo_group/ext_wbinfo_group_acl.pl.in b/helpers/external_acl/wbinfo_group/ext_wbinfo_group_acl.pl.in index 5570f1a1df..028fb20455 100755 --- a/helpers/external_acl/wbinfo_group/ext_wbinfo_group_acl.pl.in +++ b/helpers/external_acl/wbinfo_group/ext_wbinfo_group_acl.pl.in @@ -121,6 +121,11 @@ The Squid Configuration Manual http://www.squid-cache.org/Doc/config/ # use vars qw/ %opt /; +my $user; +my $group; +my @groups; +my $ans; + # Disable output buffering $|=1; @@ -132,7 +137,11 @@ sub debug { # Check if a user belongs to a group # sub check { - local($user, $group) = @_; + my $groupSID; + my $groupGID; + my @tmpuser; + + our($user, $group) = @_; if ($opt{K} && ($user =~ m/\@/)) { @tmpuser = split(/\@/, $user); $user = "$tmpuser[1]\\$tmpuser[0]"; -- 2.47.2