From 8370bcc7b7b966ea86a7c87ba1549e607da7ac25 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Fri, 10 Mar 2023 22:16:51 -0700 Subject: [PATCH] Remove a check of VAR_DOMAIN completion_list_add_symbol checks that the returned symbol has VAR_DOMAIN, but also checks that its address class is LOC_BLOCK. The domain check is redundant -- only functions can possibly be LOC_BLOCK -- and leaving this in place will cause a regression when combined with a later patch in this series. This patch preemptively removes the redundant check. --- gdb/symtab.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/symtab.c b/gdb/symtab.c index 7c56dbadf8c..76a771b1166 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -5631,7 +5631,6 @@ completion_list_add_symbol (completion_tracker &tracker, the msymbol name and removes the msymbol name from the completion tracker. */ if (sym->language () == language_cplus - && sym->domain () == VAR_DOMAIN && sym->aclass () == LOC_BLOCK) { /* The call to canonicalize returns the empty string if the input -- 2.47.2