From 967b34569424d2ec7ae7f27e64b1ad9bb2ea124b Mon Sep 17 00:00:00 2001 From: Daniel Lezcano Date: Thu, 2 Jun 2011 09:50:38 +0200 Subject: [PATCH] set close-on-exec flag on command socket When we accept a connection, we have to set the close-on-exec flag, otherwise that won't be possible to reboot a container through a lxc-console command. Reported-by: Katoh Yasufumi Signed-off-by: Daniel Lezcano --- src/lxc/commands.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/lxc/commands.c b/src/lxc/commands.c index b83d65a41..ac75ae476 100644 --- a/src/lxc/commands.c +++ b/src/lxc/commands.c @@ -236,6 +236,11 @@ static int incoming_command_handler(int fd, void *data, return -1; } + if (fcntl(connection, F_SETFD, FD_CLOEXEC)) { + SYSERROR("failed to set close-on-exec on incoming connection"); + goto out_close; + } + if (setsockopt(connection, SOL_SOCKET, SO_PASSCRED, &opt, sizeof(opt))) { SYSERROR("failed to enable credential on socket"); -- 2.47.2