From a2841ce77c9a5688c9c3eba06bf9f19d65df6959 Mon Sep 17 00:00:00 2001 From: Alejandro Colomar Date: Thu, 14 Nov 2024 18:45:07 +0100 Subject: [PATCH] lib/addgrps.c: add_groups(): Simplify redundant code with a goto Reviewed-by: Serge Hallyn Signed-off-by: Alejandro Colomar --- lib/addgrps.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/addgrps.c b/lib/addgrps.c index b64fa4978..e65b06d27 100644 --- a/lib/addgrps.c +++ b/lib/addgrps.c @@ -88,11 +88,8 @@ add_groups(const char *list) } if (added) { - int ret; - - ret = setgroups (ngroups, grouplist); - free (grouplist); - return ret; + if (setgroups(ngroups, grouplist) == -1) + goto free_gids; } free (grouplist); -- 2.47.2