From a77cffaa256e6c4a6dbca115905c09ddbe9c22da Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Mon, 24 Jun 2024 15:19:20 +0200 Subject: [PATCH] s4:torture: Initialize struct wrepl_wins_name "Error: UNINIT (CWE-457): samba-4.20.0rc2/source4/torture/nbt/winsreplication.c:1244: var_decl: Declaring variable ""wins_name1"" without initializer. samba-4.20.0rc2/source4/torture/nbt/winsreplication.c:4835: assign: Assigning: ""wins_name_r1"" = ""&wins_name1"", which points to uninitialized data. samba-4.20.0rc2/source4/torture/nbt/winsreplication.c:4905: uninit_use_in_call: Using uninitialized value ""*wins_name_r1"". Field ""wins_name_r1->is_group"" is uninitialized when calling ""test_wrepl_update_one"". 4903| 4904| /* now apply R1 */ 4905|-> ret &= test_wrepl_update_one(tctx, ctx, records[i].r1.owner, wins_name_r1); 4906| ret &= test_wrepl_is_applied(tctx, ctx, records[i].r1.owner, 4907| wins_name_r1, records[i].r1.apply_expected);" Signed-off-by: Andreas Schneider Reviewed-by: Noel Power Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Fri Jun 28 12:44:31 UTC 2024 on atb-devel-224 --- source4/torture/nbt/winsreplication.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/source4/torture/nbt/winsreplication.c b/source4/torture/nbt/winsreplication.c index 2bfdb84daed..77bef8c81e1 100644 --- a/source4/torture/nbt/winsreplication.c +++ b/source4/torture/nbt/winsreplication.c @@ -1241,8 +1241,12 @@ static bool test_conflict_different_owner(struct torture_context *tctx, struct test_wrepl_conflict_conn *ctx) { bool ret = true; - struct wrepl_wins_name wins_name1; - struct wrepl_wins_name wins_name2; + struct wrepl_wins_name wins_name1 = { + .flags = 0, + }; + struct wrepl_wins_name wins_name2 = { + .flags = 0, + }; struct wrepl_wins_name *wins_name_r1; struct wrepl_wins_name *wins_name_r2; uint32_t i; -- 2.47.2