From a9e13f3590f2e6bdba50eb8a3825d2c8e2362778 Mon Sep 17 00:00:00 2001 From: "W.C.A. Wijngaards" Date: Wed, 14 Oct 2020 14:01:47 +0200 Subject: [PATCH] - Fix that if there are on reply callbacks, those are called per reply and a new message created if that was modified by the call. --- doc/Changelog | 2 ++ services/mesh.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/Changelog b/doc/Changelog index 97959cf26..4d35a747e 100644 --- a/doc/Changelog +++ b/doc/Changelog @@ -2,6 +2,8 @@ - Fix for python reply callback to see mesh state reply_list member, it only removes it briefly for the commpoint call so that it does not drop it and attempt to modify the reply list during reply. + - Fix that if there are on reply callbacks, those are called per + reply and a new message created if that was modified by the call. 13 October 2020: Wouter - Fix #323: unbound testsuite fails on mock build in systemd-nspawn diff --git a/services/mesh.c b/services/mesh.c index 8f746ea8e..c22ef43fa 100644 --- a/services/mesh.c +++ b/services/mesh.c @@ -1235,7 +1235,7 @@ mesh_send_reply(struct mesh_state* m, int rcode, struct reply_info* rep, prev->edns.bits == r->edns.bits && prev->edns.udp_size == r->edns.udp_size && edns_opt_list_compare(prev->edns.opt_list, r->edns.opt_list) - == 0) { + == 0 && !env->inplace_cb_lists[inplace_cb_reply]) { /* if the previous reply is identical to this one, fix ID */ if(prev_buffer != r_buffer) sldns_buffer_copy(r_buffer, prev_buffer); -- 2.47.2