From aa97974c0e42f5eb7c663b05407964ff816dae3b Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Wed, 19 May 2021 02:38:20 +0000 Subject: [PATCH] pytest segfaults: add a couple more failing tests Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- python/samba/tests/segfault.py | 20 +++++++++++++++++++- selftest/knownfail.d/python-segfaults | 2 ++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/python/samba/tests/segfault.py b/python/samba/tests/segfault.py index 1b9c9a0cab6..11d3b3134f4 100644 --- a/python/samba/tests/segfault.py +++ b/python/samba/tests/segfault.py @@ -185,10 +185,28 @@ class SegfaultTests(samba.tests.TestCase): """Inline arrays were incorrectly handled.""" dnsserver.DNS_RPC_SERVER_INFO_DOTNET().pExtensions - @no_gdb_backtrace @segfault_detector def test_dcerpc_idl_set_inline_arrays(self): """Setting an inline array was incorrectly handled.""" a = dnsserver.DNS_EXTENSION(); x = dnsserver.DNS_RPC_DP_INFO(); x.pwszReserved = [a, a, a] + + @no_gdb_backtrace + @segfault_detector + def test_dnsp_string_list(self): + from samba.dcerpc import dnsp + # We segfault if s.count is greater than the length of s.str + s = dnsp.string_list() + s.count = 3 + s.str + + @no_gdb_backtrace + @segfault_detector + def test_dns_record(self): + from samba.dnsserver import TXTRecord + from samba.dcerpc import dnsp, dnsserver + # there are many others here + rec = TXTRecord(["a", "b", "c"]) + rec.wType = dnsp.DNS_TYPE_A + rec.data diff --git a/selftest/knownfail.d/python-segfaults b/selftest/knownfail.d/python-segfaults index 1be0566dcb1..d129dab7d47 100644 --- a/selftest/knownfail.d/python-segfaults +++ b/selftest/knownfail.d/python-segfaults @@ -1 +1,3 @@ samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_net_replicate_init__3 +samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_dnsp_string_list +samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_dns_record -- 2.47.2