From b12d169ea37b0c1740cf5874f870889e3356a91b Mon Sep 17 00:00:00 2001 From: Aurelien DARRAGON Date: Fri, 23 Sep 2022 08:48:34 +0200 Subject: [PATCH] BUG/MINOR: hlua: fixing ambiguous sizeof in hlua_load_per_thread As pointed out by chipitsine in GH #1879, coverity complains about a sizeof with char ** type where it should be char *. This was introduced in 'MINOR: hlua: Allow argument on lua-lod(-per-thread) directives' (ae6b568) Luckily this had no effect so far because on most platforms sizeof(char **) == sizeof(char *), but this can not be safely assumed for portability reasons. The fix simply changes the argument to sizeof so that it refers to '*per_thread_load[len]' instead of 'per_thread_load[len]'. No backport needed. --- src/hlua.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hlua.c b/src/hlua.c index 2fd710d3a5..b0c4444bce 100644 --- a/src/hlua.c +++ b/src/hlua.c @@ -11335,7 +11335,7 @@ static int hlua_load_per_thread(char **args, int section_type, struct proxy *cur /* count args excepting the first, allocate array and copy args */ for (i = 0; *(args[i + 1]) != 0; i++); - per_thread_load[len] = calloc(i + 1, sizeof(per_thread_load[len])); + per_thread_load[len] = calloc(i + 1, sizeof(*per_thread_load[len])); if (per_thread_load[len] == NULL) { memprintf(err, "out of memory error"); return -1; -- 2.47.2