From b6d66e55adce1b8cbbeb0493617db463c62c42bc Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Thu, 20 Jun 2024 14:44:33 +0200 Subject: [PATCH] s4:torture: Initialize struct netr_LogonSamLogonEx "Error: UNINIT (CWE-457): samba-4.20.0rc2/source4/torture/rpc/schannel.c:250: var_decl: Declaring variable ""r"" without initializer. samba-4.20.0rc2/source4/torture/rpc/schannel.c:357: uninit_use_in_call: Using uninitialized value ""r.in.validation_level"" when calling ""torture_comment"". 355| ""LogonSamLogonEx failed""); 356| } else { 357|-> torture_comment(tctx, 358| ""Skip auth_level[%u] Testing LogonSamLogonEx with name %s using %s and validation_level: %d\n"", 359| auth_level, ninfo.identity_info.account_name.string, crypto_alg," Signed-off-by: Andreas Schneider Reviewed-by: Martin Schwenke --- source4/torture/rpc/schannel.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/source4/torture/rpc/schannel.c b/source4/torture/rpc/schannel.c index d6dca366670..04752424cd2 100644 --- a/source4/torture/rpc/schannel.c +++ b/source4/torture/rpc/schannel.c @@ -247,7 +247,11 @@ static bool test_netlogon_ex_bug14932(struct dcerpc_pipe *p, struct netlogon_creds_CredentialState *creds) { NTSTATUS status; - struct netr_LogonSamLogonEx r; + struct netr_LogonSamLogonEx r = { + .in = { + .flags = 0, + } + }; struct netr_NetworkInfo ninfo; union netr_LogonLevel logon; union netr_Validation validation; -- 2.47.2