From c92399c355d1333eff37ea799832a8890acd0d74 Mon Sep 17 00:00:00 2001 From: Yoann Congal Date: Wed, 6 Aug 2025 17:55:49 +0200 Subject: [PATCH] runqemu: refactor a duplicated cleanup statement Refactor using a "finally:" instead of a duplicated statement inside and outside of the try/except block. Signed-off-by: Yoann Congal Signed-off-by: Richard Purdie --- scripts/runqemu | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/scripts/runqemu b/scripts/runqemu index 4fb85177e3..3a339acc2a 100755 --- a/scripts/runqemu +++ b/scripts/runqemu @@ -450,11 +450,10 @@ class BaseConfig(object): try: subprocess.check_call(['zstd', '-d', image_path, '-o', uncompressed_path]) except subprocess.CalledProcessError as e: - self.cleanup_files.append(uncompressed_path) raise RunQemuError(f"Failed to decompress {self.rootfs}: {e}") - - # Mark for deletion at the end - self.cleanup_files.append(uncompressed_path) + finally: + # Mark temporary file for deletion + self.cleanup_files.append(uncompressed_path) # Use the decompressed image as the rootfs self.rootfs = uncompressed_path -- 2.47.2