From d1c44861f9c86ef3ff6e0614e423d86a2a41db4f Mon Sep 17 00:00:00 2001 From: Jacob Keller Date: Fri, 27 Jun 2025 15:09:04 -0700 Subject: [PATCH] send-pack: clean up extra_have oid array Commit c8009635785e ("fetch-pack, send-pack: clean up shallow oid array", 2024-09-25) cleaned up the shallow oid array in cmd_send_pack, but didn't clean up extra_have, which is still leaked at program exit. I suspect the particular tests in t5539 don't trigger any additions to the extra_have array, which explains why the tests can pass leak free despite this gap. Signed-off-by: Jacob Keller Signed-off-by: Junio C Hamano --- builtin/send-pack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/builtin/send-pack.c b/builtin/send-pack.c index 59b626aae8..b28da7ddd7 100644 --- a/builtin/send-pack.c +++ b/builtin/send-pack.c @@ -344,6 +344,7 @@ int cmd_send_pack(int argc, free_refs(remote_refs); free_refs(local_refs); refspec_clear(&rs); + oid_array_clear(&extra_have); oid_array_clear(&shallow); clear_cas_option(&cas); return ret; -- 2.47.2